From: Khoo Yit Phang <khooyp@cs.umd.edu>
To: gdb-patches@sourceware.org
Cc: Khoo Yit Phang <khooyp@cs.umd.edu>
Subject: Re: Make the "python" command resemble the standard Python interpreter
Date: Fri, 13 Jan 2012 21:39:00 -0000 [thread overview]
Message-ID: <34554F70-593C-4128-B2F2-23437C948462@cs.umd.edu> (raw)
In-Reply-To: <m34nvz4sg1.fsf@redhat.com>
(Sorry if you received a duplicate email, my previous reply was rejected by gdb-patches.)
Hi,
On Jan 13, 2012, at 8:56 AM, Phil Muldoon wrote:
> Tom Tromey <tromey@redhat.com> writes:
>
>>>>>>> "Yit" == Khoo Yit Phang <khooyp@cs.umd.edu> writes:
>>
>> Yit> + TRY_CATCH (except, RETURN_MASK_ALL)
>> Yit> + {
>> Yit> + struct cleanup *cleanup = gdbpy_suspend_sigint_handler ();
>> Yit> + p = command_line_input (prompt, 0, "python");
>> Yit> + do_cleanups (cleanup);
>> Yit> + }
>> Yit> +
>> Yit> + /* Detect Ctrl-C and treat as KeyboardInterrupt. */
>> Yit> + if (except.reason == RETURN_QUIT)
>> Yit> + return NULL;
>>
>> Does this case need the Python exception to be set? If not, I think it
>> would be good to expand this comment to explain the situation.
>
> Yes, I think it does. If command_line_input fails for a reason other
> than the one case of Ctrl-C, the exception I believe with be eaten.
Tom's email did not include all the code: the other cases are handled via gdbpy_convert_exception.
> Also, the cleanup in the TRY_CATCH seems weird?
Can you clarify?
In this case, gdbpy_suspend_sigint_handler suspends Python's interrupt handler and reverts to GDB's. The cleanup handler resumes Python's interrupt handler, and additionally captures any changes to GDB's signal handler, and so has to be run before returning to Python.
>> Yit> + d = PyModule_GetDict (m);
>>
>> Do we need error checking?
>> I didn't look at the API docs.
>
> Nope, PyModule_GetDict never fails. But given how things change in
> Python (ie 3.x vs 2.x) it might be cautious just to add a check here
> anyway.
Sounds reasonable.
Yit
January 13, 2012
next prev parent reply other threads:[~2012-01-13 21:37 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 0:31 Khoo Yit Phang
2012-01-11 4:06 ` Joel Brobecker
2012-01-11 10:43 ` Kevin Pouget
2012-01-11 10:59 ` Joel Brobecker
2012-01-11 16:04 ` Khoo Yit Phang
2012-01-11 17:48 ` Khoo Yit Phang
2012-01-11 18:48 ` Kevin Pouget
2012-01-11 19:04 ` Khoo Yit Phang
2012-01-11 19:11 ` Kevin Pouget
2012-01-11 21:06 ` Khoo Yit Phang
2012-01-11 21:33 ` Tom Tromey
2012-01-11 22:22 ` Khoo Yit Phang
2012-01-20 21:25 ` Tom Tromey
2012-01-20 21:31 ` Tom Tromey
2012-01-22 16:42 ` Khoo Yit Phang
2012-01-11 20:56 ` Tom Tromey
2012-01-11 21:30 ` Khoo Yit Phang
2012-01-11 21:41 ` Tom Tromey
2012-01-12 3:07 ` Khoo Yit Phang
2012-01-13 14:09 ` Phil Muldoon
2012-01-13 21:39 ` Khoo Yit Phang [this message]
2012-01-12 16:48 ` Doug Evans
2012-01-12 16:52 ` Khoo Yit Phang
2012-01-12 16:55 ` Paul_Koning
2012-01-12 17:24 ` Joel Brobecker
2012-01-12 17:30 ` Doug Evans
2012-01-12 17:38 ` Paul_Koning
2012-01-12 17:46 ` Doug Evans
2012-01-12 17:48 ` Doug Evans
2012-01-12 17:51 ` Paul_Koning
2012-01-12 18:06 ` Doug Evans
[not found] ` <CADPb22T1ZmfiGeF9g-QZN6pCTBHwT5ByD9ddX_Dhxe4URvTAhw@mail.gmail.com>
2012-01-12 18:21 ` Khoo Yit Phang
2012-01-12 18:36 ` Doug Evans
2012-01-12 18:48 ` Khoo Yit Phang
2012-01-12 21:22 ` Doug Evans
2012-01-12 18:30 ` Doug Evans
2012-01-21 1:56 ` Tom Tromey
2012-01-22 16:57 ` Khoo Yit Phang
2012-01-23 22:17 ` Doug Evans
2012-01-24 17:36 ` Tom Tromey
2012-01-26 18:28 ` Doug Evans
2012-01-30 6:50 ` Khoo Yit Phang
2012-01-30 17:25 ` Doug Evans
2012-01-30 19:57 ` Doug Evans
2012-02-06 20:08 ` Doug Evans
2012-02-06 20:13 ` Paul_Koning
2012-02-06 20:30 ` Khoo Yit Phang
2012-02-06 20:34 ` Doug Evans
2012-02-06 20:59 ` Paul_Koning
2012-02-06 21:54 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34554F70-593C-4128-B2F2-23437C948462@cs.umd.edu \
--to=khooyp@cs.umd.edu \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).