Re: [PATCH 2/2] gdb/testsuite: add a new check-all-boards target

[Tom de Vries <tdevries@suse.de>]

On 11/7/23 19:18, Andrew Burgess wrote:

Hi Andrew,

just a review of the documentation in this reply.

> +GDB_TARGET_USERNAME
> +GDB_HOST_USERNAME
> +
> +These settings are only used with the check-all-boards target, and
> +should be the usernames of two separate users on the local machine,
> +both of which the current user can be ssh to without a password.

can ssh to

> +
> +These users will be used when by board files that simulate remote

used by board files

> +targets by switching to a different user on the same machine.  These
> +users will have random files copied into their $HOME directories, so
> +it is a good idea to setup new users just for this purpose.
> +
> +Testing All Simple Boards
> +*************************
> +
> +There are a number of boards that ship with GDB that simulate common
> +debug scenarios.  For example by sshing to a different user on the
> +local machine and running gdbserver as this alternative user we aim to
> +simulate a true remote debug experience.
> +
> +There is a script binutils-gdb/gdb/testssuite/make-check-all.sh which
> +can be used to run a defined set of tests using all of the available
> +simple board files.  Support for using this script is also included in
> +GDB's makefile, and can be used as:
> +
> +  make check-all-boards GDB_TARGET_USERNAME=remote-target \
> +			GDB_HOST_USERNAME=remote-host \
> +			TESTS="gdb.base/break.exp"
> +
> +The 'remote-target' and 'remote-host' can be replaced with any user
> +names on the local machine, the only requirements are that the current
> +user must be able to ssh to these users without a password, and these
> +users must be happy to have arbitrary files copied into their $HOME
> +directory.  Ideally, these users would be setup just for GDB testing.
> +
> +The check-all-boards target requires that TESTS be defined, though it
> +is fine to include multiple tests.
> +
> +There results are preserved and can be found in

The results

> +gdb/testsuite/check-all/, within this directory the results are split
> +by the board file used.
> +

Thanks,
- Tom