From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 614CE3858288 for ; Mon, 21 Aug 2023 07:23:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 614CE3858288 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692602639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qmf4kjXrr2jYkuwRwb3T+k5BtFaz8ZyJ7+jtdPtqdpg=; b=RQF3nKWtqldqacPO5QDA4DjZ8NzgAuf6SRHcQ4y361N3NInydUex8DvvuCobVfBH8ClYg5 Aqkx/4sOP8u3xWWLck+BrUSHDbeDP70j485fnuWw+JVPOINh3F2s8SWoTt8aCjC8BGP6fE ybEpfcqyqPDd+4TodUW6cw48pymNMDE= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90-B2UZD9GLP3CTA0Qcd-wqcw-1; Mon, 21 Aug 2023 03:23:57 -0400 X-MC-Unique: B2UZD9GLP3CTA0Qcd-wqcw-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4108d23b401so21779951cf.1 for ; Mon, 21 Aug 2023 00:23:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692602636; x=1693207436; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qmf4kjXrr2jYkuwRwb3T+k5BtFaz8ZyJ7+jtdPtqdpg=; b=RaYPFXng7/U/6SR+2/3TUJw8wv7V8G5fSX4MjOaIHDObbNSus0pVGCOAvfOF1BSV4K NrTq5uVIa5yJDVRGMdNf6QQqfriOfzVIzjKhkTc+gCCdBzo9QfRtdAVb1ghUmwODyn/W HXZE4+fZZFU2X7dLY0I/3nrCzu1v25Q70DO+a1P5QEubvi3ZBVGj9OFwv7QN9vKCoz3b jxvshQOQdmqrzusoUWp8xHeSuN0EexZoGUKamp80425KFkimeW1ro/yCuOfQjhNTO0BB piEC+LoYldTWxssFNTG0H8tnf09Pym4n7irb2+kwXJy4crSj1XBq1Jn3aRTalceIn77s l1gA== X-Gm-Message-State: AOJu0YyjlSDNVfAC8sVaAvgQXiAGyfkTACZXNKMltKDm90bbB5hwb5MV o4K49Gr7I1XPepDUUs6BKB0ElKjl5ugqOZUFJl1YHKG8x9BoVWrJe2fq8e5062g5A0nmbnX3h3q b+Cd+xdfs+px8Zsc+A6XMJx8EK0NTLQ== X-Received: by 2002:ac8:5f8f:0:b0:3f9:b8a9:6494 with SMTP id j15-20020ac85f8f000000b003f9b8a96494mr9480186qta.48.1692602636577; Mon, 21 Aug 2023 00:23:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHYSnR3MpQndW/KoFh4b2DmTnaps95myNysXrNldALif6A9kmwDblJ4js7xP3dg3HZSwe8vrQ== X-Received: by 2002:ac8:5f8f:0:b0:3f9:b8a9:6494 with SMTP id j15-20020ac85f8f000000b003f9b8a96494mr9480181qta.48.1692602636336; Mon, 21 Aug 2023 00:23:56 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id e10-20020ac8130a000000b0040553dac952sm2153173qtj.28.2023.08.21.00.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 00:23:56 -0700 (PDT) Message-ID: <3491d433-6d44-51d7-daee-20eae03012f5@redhat.com> Date: Mon, 21 Aug 2023 09:23:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 3/4] gdb/testsuite: fix testing gdb.reverse/step-reverse.exp with clang To: Tom Tromey , Guinevere Larsen via Gdb-patches References: <20230814104819.207097-2-blarsen@redhat.com> <20230814104819.207097-5-blarsen@redhat.com> <87ttsww567.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <87ttsww567.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18/08/2023 20:56, Tom Tromey wrote: >>>>>> "Guinevere" == Guinevere Larsen via Gdb-patches writes: > Guinevere> It also adds a new parameter to get_hexadecimal_valueof, so that we can > Guinevere> use it without generating new passes, otherwise we'd get multiple > Guinevere> duplicate test names. This change shouldn't affect any other test using > Guinevere> this proc. > > I thought there was a different thread about this? > > To me it seems weirder to have the potential for a fail without a > corresponding pass. Though I suppose both situations are lame. You're right, there was a thread about this! I actually removed this change, but forgot to change the commit message. I'll remove this last paragraph completely. -- Cheers, Guinevere Larsen She/Her/Hers