From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2078.outbound.protection.outlook.com [40.107.93.78]) by sourceware.org (Postfix) with ESMTPS id 728733857818 for ; Tue, 1 Feb 2022 14:39:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 728733857818 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EHvhIvHRvohuzzGiHcfzkdmGZY4TKQMjuU4IZix4JR0pG8TSYwwE+ZNp1C72SEdI1Vw70sR8Rk3v4Ivbnfm3I374Rtpk9yzcbPy0jKwxUIm9leYIaJUKlDExO6INZUsG//7lLvGPumqyfUDGVQ5dmRkeV6pr/9mIIiciy4+Q41EXzXpLCno8SMvngN96viC9uBT7BJ5+7IwyIbIhwJ2NqaZj3UC+YtDblVPhffVKeNTNu8/ERZGNl+5OkIHPz7HjyO9UNT5fPxmcFJoUEVxyeff1/ySQrKRcMYniSiG38MWY9qzV/FpTtS+4Cx+wne85BkH9dxn31tmi0FDbLeTBIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j5xLKL3nJKKYmLjFQ1nOrYknaC6nmQ2Yi2gHCnoTM6k=; b=eWLgTvkI4khix4dabzTxGGBVSuIxShpYRsHNa1xXhSkXnd9TBZUoFfW2pe6gRk/NHv7WgavzdLRNY+FurBC5+uvzl8aJe1OuUopQ6TOQJRiUg69YK2sFkmc2X09xiotGkmIPHqfAEfW1YoocaSHWdeYJOxssRrDWsVjF97kZpNhLN/HF/qv+ZuP9IUWva7AmN7Ar0sgis1EdjEBc42/mJJKbw0+C8XLH+8ZMO81V1hsuVETCVh4egG84V5dbDyEOKy7+Rztcb62zbb59OQRQ0tQR5sgOPGH3LMIkBqbkLpNNqqeRj3O9AdQa+oXXqoEKABWVcw/cNsOg/TbIuMDGew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) by SA1PR17MB4739.namprd17.prod.outlook.com (2603:10b6:806:19a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Tue, 1 Feb 2022 14:39:52 +0000 Received: from DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::f544:fbc7:cdfb:3017]) by DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::f544:fbc7:cdfb:3017%6]) with mapi id 15.20.4951.011; Tue, 1 Feb 2022 14:39:52 +0000 Message-ID: <34bea212957111e1b52a414f7be56ce229132c7b.camel@labware.com> Subject: Re: [PATCH] gdb/python: fix gdb.Objfile.__repr__ () for dynamically compiled code From: Jan Vrany To: Simon Marchi , gdb-patches@sourceware.org Date: Tue, 01 Feb 2022 14:39:45 +0000 In-Reply-To: <305de069-6b89-dd99-c011-be3ae7ae44c4@polymtl.ca> References: <20220201130534.1827188-1-jan.vrany@labware.com> <305de069-6b89-dd99-c011-be3ae7ae44c4@polymtl.ca> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0395.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::22) To DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3b7251e6-4234-4eaa-315c-08d9e590b482 X-MS-TrafficTypeDiagnostic: SA1PR17MB4739:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X17jMX14yTp9gSzU3vb/BXcH/QXjOlYbqkYQUX9BzXngJOstu85fvM3miQgX5cR466z6E8+IPfUbHfMUxDHUv5XBf4kHzvZKGOIQMnlxmg97pyWx0v8BADyjSorRdQ7FOJXpbmOgj8wMzgRjG/XuiYRW3K9Qgzj+CvEFb4BwNsKgY01ZdhqqTt9Hn8LMt6PNpohmSF+Xbj8kSzyVQ2tvu6t1z2IQwRivdofL3If8OPa1oLIu6MbxoSMPyP0TkCu5/busogfGIARqQHtp5BOX5PRnfftdrZi8nQRCmQBSpCQp662inx+gNBUBUMAf1f/F0AAPFumrSFBzBY/1PGAFqLdL/30Gnjder4SxGpg5TaKUwFf3EKS4UopxW6JJPRWc4SCTXUjQ6nhFb5lEzoaq6WpEXo4XN2auJbjh9IwGWrgS3Jfz9GP4U/fZSwdUc6UrPoNiCJCH8/BoatJeju9D9sMhZ688m8mtk4MLX13r8inIRLylrXhjVaM5M7jKytx5XlxNNbrGjTxyupTQdvsKkFZLlDm7C8ZatAB44GD3fGaoIZKGCsO64TGMQiN4fj0Fy3vgL+IabM5t0Z/mKK2BPxWti1uR/ud5zGcOzpb6yP9FLwJlrEPf/kNP0Hwv2IRm7fmpahb6PzOjcoOSp4Umgn/4etyfbBOz6bxC4JL/0XrOsvaZuIkxpNVy0sTfzqZd X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR17MB3113.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(53546011)(36756003)(2616005)(52116002)(83380400001)(508600001)(6486002)(186003)(26005)(6506007)(6512007)(6666004)(2906002)(316002)(66556008)(66476007)(8676002)(8936002)(5660300002)(38350700002)(38100700002)(86362001)(44832011)(66946007)(20210929001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0M4cTVmcDlOSUpPekF3NnBPZkVSRVlldHFXZWNMT1gxTExWbXRPaWRFRWNB?= =?utf-8?B?VVpZV0JCVnpMbDNIODdkVEhMS1NOTmM1aU5SRmNTL1ZLc1JUS2tGVkZHejJ6?= =?utf-8?B?T0xvRVJQWDE1SUdQeGprR2ZpZlRZUmxVZjA5WTdJejJMYVF5TytnN0t0dGg5?= =?utf-8?B?UWdaK0JrWGc0N08weVNGWU5OVEg5QThDM0lvNllaVkNhaG5hUEhMZmI5UHhP?= =?utf-8?B?MFhvdm9abVhiRmk3alBtSEVPTmZZSlNNUGFCTHdRNE5kcWtnZHIrL0IxR1lq?= =?utf-8?B?clhsRitUSDFPbCtDU2RWSExnSzQrUStMeE45alRjUXl1WGUvSVBEcTkzZ1ZP?= =?utf-8?B?SG1MT3BRZDVCcHNEUUgxbFQ2Q2hKWGttZzRJYUlERFhsTUovK3dvYXV6cVNZ?= =?utf-8?B?VTR4MEl2RmpNRUVJMFJkN1grYURXSDBJbkowelRTOENscjVEdUh5YldEUEM2?= =?utf-8?B?eDE3Q0JVZU1GTHRNY2xmTUlyeEpFZGhSZXJhc3crWEhveXN6dGE5VUZhdklC?= =?utf-8?B?M2hpTHhoZVEyV041ejZjUGZvQU1Sd0FnZVZleVpXMFkwVEZWU3p2bW1wN2JB?= =?utf-8?B?bWFCeEVWUWhlQkZwS1VORHZDRE9DQ01wNEM2cENvUmdrbHpkL0cvVEhucWRm?= =?utf-8?B?bUliR05YaE5lM1JqSElNdHJkUFo0SHVFYmZ0c2lVUVR5dFdNcnUrS2p4R1V3?= =?utf-8?B?bytDa2NSaFhBWGZDQ0JtSFg3dUNlUHZkbVNJeWVTNTNHTFZiM2t6V1Nhc0JT?= =?utf-8?B?aUNWSE5VZjdFY1FyVXhmMUoyYlUwbWVNZUFYSnNCTUdQOWs0bUVYRTJWZmdv?= =?utf-8?B?UEhvWnFjN3gwS01rcXR1a0ZSZWZGSkpsTXYzdHNLNFk3aTRSbDN5ODFFM0dU?= =?utf-8?B?ZldhZHlFb2YvWnBrZHJOZkJ4SXZodkZlYnNUZXVyaVJ5ZlFyTndPcFhEa1Q4?= =?utf-8?B?dGd1MkxOSTk3VlNjOHBWOXByU09ROHlLWDM4Sk80TTRRQmZ0Sk1Fb1B2NGRW?= =?utf-8?B?YXJTTCtTZGNWR2xIZnlWRVNuZ0RwNUdFQk5vT1VRWW1LelFxREtMM3lhVFVR?= =?utf-8?B?eThPc3RwS3BjMnczWGlDMEdqelBtM1EwWkgyUml6UHJqbUh2ejNaam5BR3Nq?= =?utf-8?B?ZjhHeEI0eXFJVWl6NW9Uem82aTFvTVJKNlFUVnBCMjc1MUY5MVlmUFV6ODZZ?= =?utf-8?B?SXhwa0oyVGNlL3IvazRNZERwamxna1cwUjhrSTQxODF1T081dnFyR1FFSVc2?= =?utf-8?B?TytobzlVRWxSNE5zRnptY0ZZenROMHhaV3I1UTN3ZXV5V0hWelczSk1UNVJl?= =?utf-8?B?ODJMTnc3eWY5WWRYaXd3eWluaCtBbGYzUXAxR2dwK2N3c09JZ0xjdGZvMmgr?= =?utf-8?B?d1g2R0prN09reW1nUzhSMWZiWEplbW5SbGI3Tm9FejVCYlVvVi9weS9BcFFC?= =?utf-8?B?anNTWmtjd2wvaG9VdnhUbTExL2lmd0VpRXEvU3ZEMnM5SXZ2U0t4aTJPMEs2?= =?utf-8?B?VmVVOCsvRFdlVnQ4QmkvWmh4R2lxV3RZRmJES3NzcXpYMWE3d3h6cHFJWUtG?= =?utf-8?B?N3F2Qm1OdHJuNGt6Z3M1Rm45SHQ1M0xma1NXRFh0bVpLQXpiMlZSYVByMTN4?= =?utf-8?B?RFpLVCtIeVhPR1NDMVRBRzg3SjNVdEsyeW9mOWFJT0tqa2JjSTVYaHhXdHlW?= =?utf-8?B?d0FXSzFEVGdVMTFxVlZ4TENVZlpONG5WQVdSTW5KQmhDUW54RWNJNjgvSHNa?= =?utf-8?B?UDZQSURSTi9oZGtNWVF2OXdaeTJlMUhVT1JxeG1hT0p4Nm5XSTlhVTg4am0r?= =?utf-8?B?T25hMkNlVGcvRE5iQUd0NzhMNFVQTjZoSlpmMTNUKzRaVVlnNGFEVkhmcTBv?= =?utf-8?B?U2N6TUt0SjZBY3RRSEdPeWlwcnlieFVsL2hJTmtRRHVJUjFtdzZNV2dBdHlY?= =?utf-8?B?VzVHcmlFODlBUVFTMTBoUXZvbFNqbm5uaHFrOXcyQmlJKzNCQktOL0QyQStK?= =?utf-8?B?RGZwY3UvbmlRc3pjeFozRTRsQjRyeUMvV24zcC9KQkE0R3ZhdzM5UVN3bENj?= =?utf-8?B?Nks5MTh0ZldWQXVHQ0M5VEJ0WVFWUjhmdnBnMFF3MXdRRUVPYlBCR3NWOWJI?= =?utf-8?B?NEo1c0E1R3lvUldoZnN2RDh4S0VtRjJ6OWJURlRSZU5oQmoyZXYxb1F6enBl?= =?utf-8?Q?jgaLM4/4prgQPK+D3gJbLRU=3D?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b7251e6-4234-4eaa-315c-08d9e590b482 X-MS-Exchange-CrossTenant-AuthSource: DM6PR17MB3113.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 14:39:52.1743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0wun+q8JyqdtbLr+k34S8qJQfcHmiENs0wiDZ07lZY8mSpXxfuTCIhQajj0wA/vE8I/byqXrQEgHe9IwwwOO8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR17MB4739 X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2022 14:39:57 -0000 On Tue, 2022-02-01 at 09:22 -0500, Simon Marchi wrote: > > On 2022-02-01 08:05, Jan Vrany via Gdb-patches wrote: > > While experimenting with JIT reader API I realized that calling repr () > > on objfile created by JIT reader crashes GDB. > > > > The problem was that objfpy_repr () called objfile_filename () which > > returned NULL, causing PyString_FromFormat () to crash. > > > > This commit fixes this problem by using objfile_name () instead of > > objfile_filename (). This also makes consistent with the value of gdb.Objfile.filename variable. > > --- > >  gdb/python/py-objfile.c | 2 +- > >  gdb/testsuite/gdb.base/jit-reader.exp | 8 ++++++++ > >  2 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/gdb/python/py-objfile.c b/gdb/python/py-objfile.c > > index 6055a42260b..48d2eb306d1 100644 > > --- a/gdb/python/py-objfile.c > > +++ b/gdb/python/py-objfile.c > > @@ -513,7 +513,7 @@ objfpy_repr (PyObject *self_) > >      return PyString_FromString (""); > >   > > > > > > > >    return PyString_FromFormat ("", > > - objfile_filename (obj)); > > + objfile_name (obj)); > >  } > >   > > > > > > > >  /* Subroutine of gdbpy_lookup_objfile_by_build_id to simplify it. > > diff --git a/gdb/testsuite/gdb.base/jit-reader.exp b/gdb/testsuite/gdb.base/jit-reader.exp > > index 7ee16d69c84..3084f755a02 100644 > > --- a/gdb/testsuite/gdb.base/jit-reader.exp > > +++ b/gdb/testsuite/gdb.base/jit-reader.exp > > @@ -227,6 +227,14 @@ proc jit_reader_test {} { > >   "Attempt to assign to an unmodifiable value\." \ > >   "cannot assign to register" > >   } > > + > > + gdb_test "python print(gdb.objfiles())" \ > > + "$any>>$any" \ > > + "python gdb.Objfile.__repr__ ()" > > + > > + gdb_test "python print(list(map(lambda objf : objf.filename, gdb.objfiles())))" \ > > + "$any'<< JIT compiled code >>'$any" \ > > + "python gdb.Objfile.filename" > >   } > >      } > >   > > > > > > > > LGTM, except that these tests should probably be guarded by a > >   if { ![skip_python_tests] } { >       ... >   } True! I'll add the guard and push. > > so that they don't fail on a build without Python. > > Orthogonal to this patch, but IWBN to make these objfiles have a better > name, at least so that we can differentiate them from one another. > Like, maybe include the address of the jited object: > >   << JIT compiled code at 0x%x >> I'll make another patch for this. Thanks! Jan