From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by sourceware.org (Postfix) with ESMTPS id 7912F385841E for ; Fri, 7 Jul 2023 16:19:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7912F385841E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-3fbca8935bfso23039915e9.3 for ; Fri, 07 Jul 2023 09:19:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688746775; x=1691338775; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YiSwrgixyAikMoOqXNY2ULA4zwX1NREcSMUuaNrbJEY=; b=e7Le05gSih5/scxWfjRLzWq7NRnm0JiDRWSoC5f4+GpDycm0NJp3LBp1CLbLH4li+j yOhiJuj6SG/th+tR+PEcYtyNHIiqpiJYeE5UF/8NM63Ay3kiuyRJZM5f0aEaRbDCF/SF ewIHkbsHHoSsbcgelxKEralkzE2Hi7o3mzNEfxMVJGWm18y5gAawAm5k93Dq9kcjpNxP nIFGUI4Xp8JsbgPt7Xu5KgdRUt7wAz14koPBomCYoTXUDO634LiS4DeSg7OSI5ho+bJy ytWIQ7KmkSc84lmIcnE3EtRMKVmS6CO8t63kLvVU7YJTrIw3cRVlgTN3Ctbrv6yp/jJt IiXw== X-Gm-Message-State: ABy/qLZjgmXogHSu8yK5fPqSclz1uFCKB4iiZV9jXdZwjXlfgH/eeGR3 96OXc/pui+xNPrc0OXzUAF76b1VBAWs= X-Google-Smtp-Source: APBJJlFO7aVkjyLN8Y1augOddx7ezCzPQBQBaUA9yQOMaVH5FrFodHs7ZLY+wB/3aZ9WFALm0Zr3KQ== X-Received: by 2002:a7b:ce8e:0:b0:3fb:40ec:9483 with SMTP id q14-20020a7bce8e000000b003fb40ec9483mr4389647wmj.16.1688746775299; Fri, 07 Jul 2023 09:19:35 -0700 (PDT) Received: from ?IPV6:2001:8a0:f91d:bc00:1b6e:208c:60cc:dcc? ([2001:8a0:f91d:bc00:1b6e:208c:60cc:dcc]) by smtp.gmail.com with ESMTPSA id v13-20020a5d43cd000000b00314427091a2sm4781676wrr.98.2023.07.07.09.19.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 09:19:34 -0700 (PDT) Message-ID: <35169d2a-bd73-d1cc-c0a8-3e8b85618292@palves.net> Date: Fri, 7 Jul 2023 17:19:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCHv5 01/11] gdb: include breakpoint number in testing condition error message Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <24b51a1fbfc6f8b8cc52e3f90d4f36c1d44aaa6b.1678987897.git.aburgess@redhat.com> <3012ae0b-ac62-1b19-e56a-00129205393b@palves.net> <87sf9zk9rs.fsf@redhat.com> From: Pedro Alves In-Reply-To: <87sf9zk9rs.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-07-07 16:43, Andrew Burgess wrote: > Pedro Alves writes: >> Reading this, I was thinking that we should print the breakpoint location number >> as well. We do print it when presenting breakpoint stops nowadays, like: >> >> (top-gdb) b printf >> Breakpoint 3 at 0xee680 (2 locations) >> (top-gdb) r >> ... >> Breakpoint 3.1, ui_file::printf ... >> ... >> >> Did you consider that and decided against? I didn't find any mention of it in previous >> discussions. > > No, this was just an oversight, and would I think be a great > improvement. > > The patch below implements this idea. Let me know what you think. Looks good, thanks! Approved-By: Pedro Alves