From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 541DA3858D1E for ; Thu, 12 Oct 2023 04:41:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 541DA3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 39C4fC3Y018736 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Oct 2023 00:41:16 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 39C4fC3Y018736 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1697085677; bh=9PBLhqcFiVJh92N5ekOJM5jHfGL7f+v6svnezQeuAPA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HzaS8vF97EQA7kIKl5RMlc3rujqgR4vld3DFiONCg2jypy70S6V8vVD9li1rHZSWY pCr+9hDP/znOH+nwoDwZSIDZB9miDcT2mtCPnN1xmiJB5d+V8hEDZkRUQ/5hv6SMHY NroEyokHqol3rrzH7KICnrcHyqMYsyRSc1icOaII= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 098D11E00F; Thu, 12 Oct 2023 00:41:12 -0400 (EDT) Message-ID: <35527e3a-08ec-49c4-9917-127d94ca2111@polymtl.ca> Date: Thu, 12 Oct 2023 00:41:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 06/13] nat/x86-cpuid: Add a function to build the contents of a NT_X86_CPUID note Content-Language: en-US To: John Baldwin , gdb-patches@sourceware.org Cc: Willgerodt@smtp.polymtl.ca, Felix , George@smtp.polymtl.ca, Jini Susan References: <20231009183617.24862-1-jhb@FreeBSD.org> <20231009183617.24862-7-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20231009183617.24862-7-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 12 Oct 2023 04:41:12 +0000 X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-09 14:36, John Baldwin wrote: > +/* See x86-cpuid.h. */ > + > +void > +x86_cpuid_note (gdb::unique_xmalloc_ptr &buf, size_t &len) > +{ I think it would be a bit simpler to make this return a gdb::byte_vector. Simon