From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 26F6E3858D33 for ; Sun, 21 Jan 2024 03:57:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26F6E3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26F6E3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705809474; cv=none; b=YWMXe7AAlqEEBCMxXb+KVjCMolHZX3n2w6F3qRNYp9nYgA0la4zw0U5tYYWAYo/I8RiIMPPYuWRwsDDyk6Ps8/E0RETlVvR8HjqOzWhnF4TL+8YZoTxETi9YPS2rT4/iwNTISIFiohTw1t4wveKlmrmNN07NU+vn7nKNh2bw0o8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705809474; c=relaxed/simple; bh=N6/dfKC7sSWWFjrWFRtNIvn5/bpFVJfhCnC37vs+0J4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LboEj2A0OSXIgxBSRqBEe4mouR5xecVk/gGImespAHsaaAuupxWDAu/RNK6aO1ESArOorn5w5PcWXg1svu8ycf8ukkL/phmFDEA3NHqn/Z3NBdje67f18qE7kbRck3b5Y2ptdZ2yu+Q88XBnJJxdW2XRe9P3Vbtd0rddCy/og6M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705809471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sg2sEZekw/jYVTRcfbaSdZfYWslJQk0bjGG1oB6v0jM=; b=aKz8W6MBXfngEu3goBE0xJSHNuzGLroApUBYh6GJl7yCz10fucj/HnAT29i53Be77GxLuZ HDukSHtwsSWnQgrACHFbJ0c/I9FYrLZpSU87UG2T8irLjQc71050bql/K9T+1oWgZKbpiW o2R1IQW8tpSfFt/BR0apzrB52KP/1Qw= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-zSxqhfgNORmJckRp2el92A-1; Sat, 20 Jan 2024 22:57:50 -0500 X-MC-Unique: zSxqhfgNORmJckRp2el92A-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-6da10578363so1246512b3a.3 for ; Sat, 20 Jan 2024 19:57:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705809449; x=1706414249; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sg2sEZekw/jYVTRcfbaSdZfYWslJQk0bjGG1oB6v0jM=; b=smxIR8CBNZBYK4TijJ86xSMgdfg8uC9sCfZz0M/CPMxrlS9b3iG4H10UUwkqGOnvv1 lbDy4WkRlAzp70xHCNBEgj5QSeZ3b+mragZeVe0lGdLPmbje+c8tzme7KViINgy4191v C/BGp1IpNgWCzAHYPDXMd+6/e0/7FCjZeWM0T3YbqL/rxbbWomtytRkCLe9r1X3RY155 uHYNJuVRsuIKAFIxd43laN/ln2VBhaE9kvvxXea25+ILH96kv6B5MXr2mGtLoFngFR75 7kx8CG22MpmlIcv4rPFoNs97AXjqTGZjZ+hAliymi/UFcDpqodtYiDZR536W3xd11wPM mrpQ== X-Gm-Message-State: AOJu0YxTXMZ+cZ3i4In8T5Oflhb2ZatWCIPZI2tAvZhhRjNcyVa7KDGA YndJp302rleEPy3SV6zLqJf6qwTiYJGbUsCJfIPbv7tjSWUkMKTCnd/VVYPwaq1zHUqAQ8q4tA1 t35TUr7Nn5CDpU+27MPq2Q/1Ln38JigabpX92MdXiqL524DDj8IOJL3N5IjE= X-Received: by 2002:a17:90a:1f4a:b0:290:44c7:96e8 with SMTP id y10-20020a17090a1f4a00b0029044c796e8mr680962pjy.93.1705809449461; Sat, 20 Jan 2024 19:57:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqrqZTY6jLxei6gqQxA3KyNLIVn4ZTF/EqxIdwi0wQQB+UzRCRQ0PLYd23TU9ipwD6cDZLzw== X-Received: by 2002:a17:90a:1f4a:b0:290:44c7:96e8 with SMTP id y10-20020a17090a1f4a00b0029044c796e8mr680959pjy.93.1705809449161; Sat, 20 Jan 2024 19:57:29 -0800 (PST) Received: from [150.1.200.12] (174-21-92-140.tukw.qwest.net. [174.21.92.140]) by smtp.gmail.com with ESMTPSA id db11-20020a17090ad64b00b002900eeada1asm6834134pjb.43.2024.01.20.19.57.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jan 2024 19:57:28 -0800 (PST) Message-ID: <35768eb4-f1b1-4284-89ea-007bcde80f5a@redhat.com> Date: Sat, 20 Jan 2024 19:57:28 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 15/16] gdb: new maintenance command to help debug remote argument issues To: Andrew Burgess , gdb-patches@sourceware.org Cc: Michael Weghorn References: <4d76e490c2285dd7858b853f03465a1d798d6240.1704809585.git.aburgess@redhat.com> From: Keith Seitz In-Reply-To: <4d76e490c2285dd7858b853f03465a1d798d6240.1704809585.git.aburgess@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/9/24 06:26, Andrew Burgess wrote: > diff --git a/gdb/testsuite/gdb.base/maint-test-remote-args.exp b/gdb/testsuite/gdb.base/maint-test-remote-args.exp > new file mode 100644 > index 00000000000..3daf0725932 > --- /dev/null > +++ b/gdb/testsuite/gdb.base/maint-test-remote-args.exp > @@ -0,0 +1,40 @@ > +# Copyright 2024 Free Software Foundation, Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# Test the 'maint test-remote-args' command. > +# > +# We do minimal testing in here. If you are thinking of adding a new > +# test here then you are most likely adding the test in the wrong > +# place. Remote argument testing is checked in the following test > +# scripts: gdb.base/args.exp, gdb.base/inferior-args.exp, > +# gdb.base/startup-with-shell.exp, and gdb.python/py-inferior.exp. > +# The test gdb.gdb/unittest.exp also runs 'maint selftest > +# remote-args', which are the remote argument self tests. > +# > +# If you have a new test for an argument that was being passed > +# incorrectly, then add the test to one of those scripts. > +# > +# This file is ONLY for validating that the 'maint test-remote-args' > +# command itself is working. > + > +gdb_start > + > +gdb_test "maint test-remote-args a b c" \ > + [multi_line \ > + "Input \\(a b c\\)" \ > + " \\(a\\)" \ > + " \\(b\\)" \ > + " \\(c\\)" \ > + "Output \\(a b c\\)"] Is it possible to add a test to exercise the failure mode, too? Keith