From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AB123385773C for ; Tue, 18 Jul 2023 14:55:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB123385773C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689692151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zNvQvm5nE1k5WoAhaSvlTZtM2Z25TgycZixRrUkVk8o=; b=L8ais/anNkTSfqshnbOmKP/gMEAjdS9bL/Z7+1fQoAu/LDdPIFJ8PmRPmZiA6X0Qjq2O3W 9BF87yjQZPdR7easjoczFBGIb/ONvhWqxX/G5McvyN9HAFjGG6JzAgudNq+coDtzFsQ/vq Ahtxycy7TL61rDqWOqxP1GaMcC2/+Qo= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-R1i9p6b0OJ-JqM5pgWcYWg-1; Tue, 18 Jul 2023 10:55:49 -0400 X-MC-Unique: R1i9p6b0OJ-JqM5pgWcYWg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-635e6c83d77so39065836d6.0 for ; Tue, 18 Jul 2023 07:55:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689692149; x=1692284149; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zNvQvm5nE1k5WoAhaSvlTZtM2Z25TgycZixRrUkVk8o=; b=YQ4WGZwSeVE1SSce/mlTFO/jRw1WfPzyPuEIBhf+3LhalT1loNGx9+i4Ngt/t+QG4D D0gBzAKUG6yy9yJ7qwJXPa2lNxUP2kFWgw++BbhMu6HckiIqT9UImDlCGtl5DE4oE4zW tXGZ4+mOX6IGsVWKtP85rBOvUNNb9hQq1PVNi7ZRi4Sa3o9a6iht3GgniNvXU8/xBSWZ mU/BjMpPEFCZgYt/RD/CuYpeHgC5/1yPCnWKNlryBGb9GoXZzojJb8PuR9xokddXKZTS 48MPdEfZ2cTyfhMIDX5MFcooOE4vutwtDUyqAthGoWQOGx5MByf2AglHn2EJ6awXorhI 3rSw== X-Gm-Message-State: ABy/qLaIgm8SrgKYT80+8B5vC7RVWWZsuGtSNrOaMFLFVpzKepi17PhK hYIGFmrC6iSdXhfaGz20iuugyaarQS8+9QI79tbvIRmdix8KlFwszOrwgoxiPw1qkYejR9VhA2a GJWoszmJVqy9bZppcJ0qKcH15hCapRw== X-Received: by 2002:a0c:f04e:0:b0:636:4250:7d95 with SMTP id b14-20020a0cf04e000000b0063642507d95mr10989988qvl.39.1689692149219; Tue, 18 Jul 2023 07:55:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlGeYx8MgVqTRwpuzxrOYNRRyfyTm0D/tslS/cTSLjJoecGwMKlhQpBmG2Ut0LU0S1efPhDz5A== X-Received: by 2002:a0c:f04e:0:b0:636:4250:7d95 with SMTP id b14-20020a0cf04e000000b0063642507d95mr10989979qvl.39.1689692148925; Tue, 18 Jul 2023 07:55:48 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id a19-20020a0ce353000000b006363c687cf6sm763149qvm.128.2023.07.18.07.55.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 07:55:48 -0700 (PDT) Message-ID: <359c361e-a38f-67be-271f-2cc8042c1dc3@redhat.com> Date: Tue, 18 Jul 2023 16:55:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] gdb/cli: fixes to newly added "list ." command To: Pedro Alves , gdb-patches@sourceware.org References: <835af40f-edae-ba48-f121-a1cdd1f1147e@palves.net> <20230718112140.1911522-2-blarsen@redhat.com> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18/07/2023 15:43, Pedro Alves wrote: > On 2023-07-18 12:21, Bruno Larsen via Gdb-patches wrote: >> After the series that added this command was pushed, Pedro mentioned >> that the news description could easily be misinterpreted, as well as > Per the discussion, it's more than misinterpreted, it's factually incorrect. :-) > >> some code and test improvements that should be made. >> >> return; >> @@ -2805,7 +2805,7 @@ and send its output to SHELL_COMMAND.")); >> = add_com ("list", class_files, list_command, _("\ >> List specified function or line.\n\ >> With no argument, lists ten more lines after or around previous listing.\n\ >> -\"list .\" lists ten lines arond where the inferior is stopped.\n\ >> +\"list .\" lists ten lines around where the inferior is stopped.\n\ > "where the inferior is stopped" should be fixed here too, as it's not what GDB does. I'm having a hard time thinking of a concise description for it. Best I could come up was +\"list .\" lists ten lines around current location in the selected frame.\n\ but that feels very jargon-y... -- Cheers, Bruno > >> \"list +\" lists the ten lines following a previous ten-line listing.\n\ >> \"list -\" lists the ten lines before a previous ten-line listing.\n\ >> One argument specifies a line, and ten lines are listed around that line.\n\ >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> index cd86da50f46..c9377846bdc 100644 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -9155,9 +9155,9 @@ Same as using with no arguments. >> Print lines just before the lines last printed. >> >> @item list . >> -Print the lines surrounding the location that is where the inferior >> -is stopped. If the inferior is not running, print around the main >> -function instead. >> +Print the lines surrounding the last solitary line printed as part >> +of displaying a fram. If the inferior is not running, print around > "fram" -> "frame". > >> +the main function instead. >> @end table >