From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 65D7B384640C for ; Fri, 19 Apr 2024 18:43:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 65D7B384640C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 65D7B384640C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713552239; cv=none; b=buyIBQrimsPXqfafguNXH0amzrNfAFBFIEKzroZSvW62m9UVCXbtEYK7sOw3Q4/he9tyWGpuvgZ1A1w3f99QKSS2HW3b758rnapL1mVzCAkJlaN57l4Hxy0tw0kzuH8ErB8ovw1tAqZQeg7p6u10eJ0OhNFmAWR8e3DW1VyKgM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713552239; c=relaxed/simple; bh=clO622i0h9npE/KaxeuMKEREzYAvKkSgONuTENeuYoA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WsZXFfUq7MQLRrQJoi+ldTjhnjCnqf0LM0TqtIUVzPNi4sTq9nMrJVjb5tlEUsrQxakfBtUidJIGfQhm7oOzk7saJE1csmfZGFFoqPDUT7aJSvJ4JnwCJVyWCYmKkkZ1QO6Q3EIg3kqqe3u6cteOPsVXS3Ortakx8I0GIocPp4Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1713552236; bh=clO622i0h9npE/KaxeuMKEREzYAvKkSgONuTENeuYoA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=f+EBHkaNlqGFUXPvsILzgrtw4XgmlSzEN3wVoo4eeO9QlhgZluGwU3U8Ys/1CihpR m/nw16CTSbMRPU895hGO0FfBguu/6Cwutmp6G6W0k2eSZZPKceFitFs8xFx33dAn2N S4YyiOgXL4XRZ4naIPRxrTWA8x0Iw5BIQutjvSBo= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A71431E030; Fri, 19 Apr 2024 14:43:56 -0400 (EDT) Message-ID: <35cc3c26-db4a-4594-9a21-9917bd7e41b3@simark.ca> Date: Fri, 19 Apr 2024 14:43:56 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/4] Add include guard checker and reformatter To: Pedro Alves , Tom Tromey , gdb-patches@sourceware.org References: <20240419150427.897379-1-tromey@adacore.com> <177261d7-e29f-477b-9716-f76a919fe1a4@simark.ca> <8498b0b3-5e07-451f-8754-d7825f2d2145@palves.net> Content-Language: en-US From: Simon Marchi In-Reply-To: <8498b0b3-5e07-451f-8754-d7825f2d2145@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-19 12:55, Pedro Alves wrote: > On 2024-04-19 16:26, Simon Marchi wrote: >> So, after patch 4/4, your script doesn't need to handle the the >> `defined(FOO_H)` style (OLDDEF in your script). I think you could >> remove support for that, it would simplify it a little bit. > > Doesn't it need to handle it in case someone creates a new header and writes > defined(FOO_H) manually? You'd still want the hook to fix that. > IMO, after the initial run, the script doesn't really need to auto fix things, it can just check and report errors. Simon