public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Max Filippov <jcmvbkbc@gmail.com>,
	binutils@sourceware.org, gdb-patches@sourceware.org
Cc: Sterling Augustine <augustine.sterling@gmail.com>,
	David Weatherford <weath@cadence.com>,
	Maxim Grigoriev <maxim2405@gmail.com>,
	Woody LaRue <larue@cadence.com>
Subject: Re: [RFC 0/5] xtensa: support dynamic configuration
Date: Tue, 06 Jun 2017 12:41:00 -0000	[thread overview]
Message-ID: <35e4d259-0fcd-520a-51c3-ee7496c303e6@redhat.com> (raw)
In-Reply-To: <1495487553-19078-1-git-send-email-jcmvbkbc@gmail.com>

Hi Max,

> Built toolchain takes configuration
> parameters from the shared object specified in the environment variable.

Using environment variables to pass configuration information is a bad idea.

The problem is that it can be very hard to debug problems when environment
variables are involved.  Often they are not included in bug reports, which
makes reproducing the problem tricky.

At the very least you should also provide a command line option which 
specifies the path to a file containing the configuration information.  If
specified this option should override the environment variable.

There is also the issue of versioning to consider.  Does the configuration
information contain a version number ?  What happens if the configuration
information is out of date with respect to the compiler/linker or if the 
tools are older than the configuration information ?

Cheers
  Nick


  parent reply	other threads:[~2017-06-06 12:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 21:12 Max Filippov
2017-05-22 21:12 ` [RFC 3/5] xtensa: support dynconfig on windows Max Filippov
2017-06-12 15:45   ` Nick Clifton
2017-05-22 21:12 ` [RFC 2/5] xtensa: make configuration dynamic Max Filippov
2017-05-26 18:10   ` augustine.sterling
2017-05-26 18:15     ` augustine.sterling
2017-06-06 12:53       ` Nick Clifton
2017-06-07 19:13         ` Max Filippov
2017-05-22 21:12 ` [RFC 1/5] xtensa: don't expect XCHAL_* macros to be constant Max Filippov
2017-05-26 17:36   ` augustine.sterling
2017-05-22 21:13 ` [RFC 5/5] gdb: xtensa: make tdep and linux-nat dynamically configurable Max Filippov
2017-05-22 21:13 ` [RFC 4/5] xtensa: make xtensa_modules dynamic Max Filippov
2017-06-12 15:49   ` Nick Clifton
2017-06-06 12:41 ` Nick Clifton [this message]
2017-06-07 19:23   ` [RFC 0/5] xtensa: support dynamic configuration Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35e4d259-0fcd-520a-51c3-ee7496c303e6@redhat.com \
    --to=nickc@redhat.com \
    --cc=augustine.sterling@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=larue@cadence.com \
    --cc=maxim2405@gmail.com \
    --cc=weath@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).