From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 73D833856DE0 for ; Tue, 13 Sep 2022 12:58:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 73D833856DE0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 5B5DA300089; Tue, 13 Sep 2022 12:58:25 +0000 (UTC) From: Tsukasa OI To: Tsukasa OI , Andrew Burgess , Mike Frysinger Cc: gdb-patches@sourceware.org Subject: [PATCH 4/4] sim: Suppress non-literal printf warning Date: Tue, 13 Sep 2022 12:57:32 +0000 Message-Id: <35eaee9855aa3882a1ecc9de9d62c0f8b2fe0e7c.1663073826.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2022 12:58:28 -0000 Clang generates a warning if the format parameter of a printf-like function is not a literal. However, on hw_vabort, it's unavoidable to use non- literal as a format string (unless we make huge redesign). We have "include/diagnostics.h" to suppress certain warnings only when necessary. Because DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL can suppress warnings when the format parameter of a printf-like function is not a literal, this commit adds this (only where necessary) to suppress this error with "-Werror", the default configuration. sim/ChangeLog: * common/sim-hw.c (hw_vabort): Suppress non-literal printf warning by using DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL. --- sim/common/sim-hw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sim/common/sim-hw.c b/sim/common/sim-hw.c index cece5638bc9..36f355d2262 100644 --- a/sim/common/sim-hw.c +++ b/sim/common/sim-hw.c @@ -425,10 +425,13 @@ hw_vabort (struct hw *me, strcat (msg, ": "); strcat (msg, fmt); /* report the problem */ + DIAGNOSTIC_PUSH + DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL sim_engine_vabort (hw_system (me), STATE_HW (hw_system (me))->cpu, STATE_HW (hw_system (me))->cia, msg, ap); + DIAGNOSTIC_POP } void -- 2.34.1