From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2055.outbound.protection.outlook.com [40.107.104.55]) by sourceware.org (Postfix) with ESMTPS id 860ED3BF90DF for ; Mon, 3 Jun 2024 13:29:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 860ED3BF90DF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 860ED3BF90DF Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.55 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1717421370; cv=pass; b=M/Lry3Em4Ut4BuzXIc3ptZroAqdi3vLe/ZvRnNVoatI1k2OaYot6kpX8SnuCbwhaaC+GYa+hTm1gSYloDY7QiDJVffFwfex12CozmfEnoNMhLIfouhIHms7DqxToyVZqAdmL+7soxMvv3q/EWIbNmDOSH77Orc8kNbM3E1swNuA= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1717421370; c=relaxed/simple; bh=kKeKKziK3Ax0wJrUDAXCe8Z2QcKiHW37nM/F6/l3t50=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=uS6gnyYwz5Qjkd5cFfpD7Qh0OGQOmVp0B7PwlqxQwpNBTovDdQr7oUODufP6Q4hwnG0i5V4KJLZ+xt7pMIscPMlwO40pG9uCQnvhVpybsW/Ty1QjF2/MBWY67ZCVHK6rIG3xHSSOWE8YL14rZP4g547Ly6r7W4EWOUAoyLR+2/M= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RvrmVSP/iKLhHum+nyQdrOlUS0bL98Ekb9u+Y9Q820uK6nxir5NvBnH4xWduLmaJgSUIe2TqOmQ9Bme54mquWXpdTH/l/+hqzfQH0vUsAqGTCzjiAxKtwVNQpCfWF1xN8rrSGi7m2wV75KnLd9BDrRyVIj2pgvPkE5Rb9QdOGIMTJfEcLcNNNK2RiZgbDIYLTp/3M5Aarvv3nLJKZe7Gyl+CWBbO4uRCXNibUhIoEXrWh5PctdACtrXlKeRXCpvDBck6Fnidud8qpJD6ngBcKnuPEu23fjh/7zSdYiJxkwbsdYAQ6KiYc8tg7bmTFwNajY0zgsDHwPa6L6V1vOIvTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xSCOs+5jH2B3ACQX4O/bXhuNhasn5pBQ0WPs5wH9p5c=; b=isU7dbeVLLM0jMU+u4STmD4hWJ6I/5jCl6O4RB3T2GKQO1oql3/WwoKdBlRtZAWoJwEnPSR6r1nb9h4YwU5QoLztB1m7Y5W7LXmZlx/AV4L1pfmRLwDUyAsSHbCtJuJgtAnIHZLXX1JmhR1rEYrRafgNSzbvctCXy/hCe53A/0DPUcDcuDOqmr6TiKloGicZQPXIhidX3fo1l71AXf1bIZKTBLdXG7LZ0PL95QL08okm/Fo9kREfojMu3KCPFgIrPD62hC8gs1KoMLOQN2JtlGuO4apNuCs93dkRhNcRjxKR3UlR3RayH+N17gjXU2fp0Ubg/EvnCYGKZa5+68i5jg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xSCOs+5jH2B3ACQX4O/bXhuNhasn5pBQ0WPs5wH9p5c=; b=K1+oF5J5EP04bP8ws0cnWMKqSFnOtYF1zvKOUoNbEY3tEwIjHWiH9U4XqsnhxcrBkTSPWwBk3OcaI8n/CCInu1OVwWzuNJFuTrQKXoFzfLHib6fqcQrrASTLLnLI8oTeBONjRrk+Ha1Bgt/2UtSAWLP/EgblRhkgYGjqgR6BUUg= Received: from DUZPR01CA0052.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::8) by GV1PR08MB11091.eurprd08.prod.outlook.com (2603:10a6:150:1f4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.30; Mon, 3 Jun 2024 13:29:22 +0000 Received: from DU6PEPF00009528.eurprd02.prod.outlook.com (2603:10a6:10:469:cafe::23) by DUZPR01CA0052.outlook.office365.com (2603:10a6:10:469::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.25 via Frontend Transport; Mon, 3 Jun 2024 13:29:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU6PEPF00009528.mail.protection.outlook.com (10.167.8.9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7633.15 via Frontend Transport; Mon, 3 Jun 2024 13:29:22 +0000 Received: ("Tessian outbound 53b276c4c668:v327"); Mon, 03 Jun 2024 13:29:22 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e5c262a25557d249 X-CR-MTA-TID: 64aa7808 Received: from ac16757c32d0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6D7E8A00-6852-4EFC-BDCC-F5B18E96015C.1; Mon, 03 Jun 2024 13:29:15 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ac16757c32d0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 03 Jun 2024 13:29:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QCed5tvL3K7FPad8iCQCaUxAbR9vGNuXoiik30jdTLqgNA1wd4Y45xNDDIYRS5M04uArqNDKRHx24aKfk8Ch8EL2L/8b6LQ+j3o9evRLqx+AaWNg9ITdupB/ATU+NnV3toPi5o/fvZ64AivGZPdCp6zcFoLshSbxeuUNvuks4A89+UOZCKnd1ekcFtmT/frcqmiDNd+sVYNz+QAHBXU3FMMwtOMP27fC76N10gPm6PVyt1gHj6ZBBzNq/bnIDzrmcCmns7ChYYNH5Au8uOQvrQl34+bK7pBPDc+xc0PPqSGuBDzsOE0S9QVRKtLt7a3kltVqOPjfoJzUd78mFejW3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xSCOs+5jH2B3ACQX4O/bXhuNhasn5pBQ0WPs5wH9p5c=; b=devdpPnsxRxtE2+ZYvn6hzAN/w6jVkPG0qObXSGT1f+D35ulcdGwPEV8RSwkELfCISN5BamGkSzkx+7klKACXhlSX+BFE1vuKFNLPJO1ujPLGGiwVyFAq3fvmrpFRA/xNoVg20pBtQVM2WsW5oyXLM/cIHI5ErUAIZbVDTYX0zwWxR7Uptb1nVYnhbgXo70oXzsnYkaJEveJSAgHDINk0FZlgdhR0x7vT2boCB4sdiEAhEY27/v3WyRWu7MX6ktp9DUg26Okn/9Vw6MqBbK3/WEo8bqF3R8l36lipMrmqKbnP/kiQalVv8yjto0pX0ZYA/V41YESko7DTs/ftdheeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xSCOs+5jH2B3ACQX4O/bXhuNhasn5pBQ0WPs5wH9p5c=; b=K1+oF5J5EP04bP8ws0cnWMKqSFnOtYF1zvKOUoNbEY3tEwIjHWiH9U4XqsnhxcrBkTSPWwBk3OcaI8n/CCInu1OVwWzuNJFuTrQKXoFzfLHib6fqcQrrASTLLnLI8oTeBONjRrk+Ha1Bgt/2UtSAWLP/EgblRhkgYGjqgR6BUUg= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DU0PR08MB7690.eurprd08.prod.outlook.com (2603:10a6:10:3a6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.24; Mon, 3 Jun 2024 13:29:13 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::14e2:874a:b20b:78e5]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::14e2:874a:b20b:78e5%4]) with mapi id 15.20.7633.021; Mon, 3 Jun 2024 13:29:13 +0000 Message-ID: <360846d7-0eb9-47ae-8d5c-d26120acaaab@arm.com> Date: Mon, 3 Jun 2024 14:29:12 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] gdb: Make tagged pointer support configurable. Content-Language: en-US To: "Schimpe, Christina" , "Willgerodt, Felix" , "gdb-patches@sourceware.org" Cc: "eliz@gnu.org" References: <20240527102423.1361410-1-christina.schimpe@intel.com> <20240527102423.1361410-2-christina.schimpe@intel.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0027.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::19) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DU0PR08MB7690:EE_|DU6PEPF00009528:EE_|GV1PR08MB11091:EE_ X-MS-Office365-Filtering-Correlation-Id: 629c2dcb-fc08-4fff-9ba6-08dc83d12e44 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?NkwwT29RYTc3VCt4MmgxbENqZ09SZVZZY1FBT095WTRteVRtSUkzMXVZR1k3?= =?utf-8?B?NE9hV1p2Zk9oSmtZbmhNOU5wWGdSdmNuejYreVF2TXE2NWtMNjZUMTZpdFln?= =?utf-8?B?ZDBHSkYrVE82eS9XdDY1Z1B0dkxvR20vNHFENURGbGZQSlpyZGJuRWtWenlw?= =?utf-8?B?V1ozY1cvMlB6bXQxZzBhM3I3NVhqRFFsWXdQaGd6TG14SUU4REpJQy9hbkpo?= =?utf-8?B?QllVMGxJYW80a3MvQTBrRDEzcG03OEJEME9JUHpmVFlPbHhaM2dGcENHSUhm?= =?utf-8?B?SWd4cmVMWFlyVUsrMVVjMGo2d0VtaGRjUmhaVXNEMloxSWtsRzRpRm1ueThJ?= =?utf-8?B?NkV4dUdhT2VnbGQ0TG1TTmdCMnJNbWRLT0gvOFlzZWl6b3FRb0l5OFhjTkxx?= =?utf-8?B?WEwrOFJkL21kY0xvQW04UFkwbFdKL2d4cGduVUl6TGJOQ0ZVMEdtUjVqQ1Bz?= =?utf-8?B?bnJTNjVzUisrT0tjVzFwS2lNemNrK1p6REdOY1dTQXdrQ2orTWwweUZJSmx0?= =?utf-8?B?RGNJQnZ1MmtCL3NhUjR6a0E0cmpuVVhaSEVoZ0lqeWQ3S1Uwa3hDb003Z0FU?= =?utf-8?B?dk1LWHZFL29keXdqR01QYVNoOXpCZnVTWURGejNjZ2xEVnJrb0ltRlVRa0ZY?= =?utf-8?B?a1V4ekg5cmJuTlBSb1hJdi85Y2xxOHRzZ3BWdHRPMk9VL0Zkc2UwTm9WNWFH?= =?utf-8?B?aTNzc05xYjduUzgvNll3WGZCN0x6T0h4SUo0ZXc4b2haUzd2Vmo5ZnliWm8z?= =?utf-8?B?Sy9ONmI1Ky9QRnc0eTJYdURCRHNCUEUzSC91TTJkRnpnODVGc1RZdDBCNDEr?= =?utf-8?B?Uzk5cmJuN1hHOXlMUEwrRDFvd0xoQ1lLQ2IwQnFyeTNSNzFBU3d3TlYxZnlW?= =?utf-8?B?a3h6ZVJzUkptaU40QnhDRVpIT3FHdU1pUDA1Sm42Z1BZSkpQRTU3dU51OXdF?= =?utf-8?B?QWorVFgyOWZZVUFTQVNrdWJSYXg5NnRWd0JhUGFzeml5WXMrVWtyRjNNTzZY?= =?utf-8?B?Wm9pUmt5dUtDVUVVRFlwL0RabEZaU0tEL0YzOTVOdlU2ckE5cjh4Zk5WekdB?= =?utf-8?B?MSt5bWs2TFEzNWRKSXNxVExKdkh4TDFSd1BWSUdaVUZUOUJmRHBvSHpaYnkx?= =?utf-8?B?ZDVEMlFvQnRiVkI4dWNrQjNxaUpKQTArOXF3ckNHd1FyRTdwYm1iNGRhOUQr?= =?utf-8?B?eWtMNmJtWDd2VkNPbHJmZmpHSWJUQWhsYmhqRnhHTGdEcjRmRFcxbkQxQjZx?= =?utf-8?B?TDdsemdhclBrUUlDWEFFNkRtT3JSRnBHNk0yblk2NjE5RmNXNHpPQ3dPbzhC?= =?utf-8?B?eFJ2RVJWVEJONW5aZVZHOHVXcEVIekVndnN4OW9zYWRWZXFIcU1lUTB6TElC?= =?utf-8?B?OTdvQnZqSXpGdXQ5OHllbkhpcjFHR0NKWUV5QmxFalNQdGhXTi9KWFAxeUwy?= =?utf-8?B?R1dsZjk5L0RPUDBTcmtRRUxkdEVncHVSbDR4cE4yaGVFbGpRaEUzanhFTjF6?= =?utf-8?B?Sm5VU2xWZW1TdFBVN1lVMWdvelZUMVdFQ3dNNzRKeG4xSHh1c0htRWVFaTMx?= =?utf-8?B?eVFLWWYyUHE1L1hna2Y0TmlVNkt3S3F6QWwvV3llYWNNLzZzZWNsRGMwWkl1?= =?utf-8?Q?5h2szlrm0W7xq/hVEbuOY25wJU23etkhHkPpN7Z9gaEI=3D?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7690 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU6PEPF00009528.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 87446884-2a49-479d-d5b2-08dc83d128b4 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|82310400017|1800799015|35042699013|36860700004; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bzV2SkdPZExEU1NSOFNBVVdnOWNRN1lhNE1QK1ZlRFFkeWNtOThUNjBpTjFG?= =?utf-8?B?VVk4dVpjNmE2OFVZckZZRVFpZzdPVFQwOCs5RTFhQzhoRFo1aDBLakNCZVNu?= =?utf-8?B?SC8xK21sN1NQR1hydEEvN2dPTXhBS0hyMlRkSjQ0OGJNRlllc2N1YnVyZkRq?= =?utf-8?B?MWNUdGs3ZVRYbldpV0RERCtlamo2bjY3RGJZVHBFbTJTdDNkRGV2eHExRW1i?= =?utf-8?B?Y2NUeVJWUnhyVWQ5Zng2ay9LK0JUNlpXcmo0SjNXUVVvdm5vM3g1UnNzNXh3?= =?utf-8?B?NS83MTdNY0JVME85UlFjb3ZYVHc0WGVFaGRCRGdIQ3ZJRjhxVHgxbW5tN1Nl?= =?utf-8?B?eFNSdEdOS01WWTZzWmNHbFd4WUFDa1BTWmtJWlVOU3VTdVhTa3hSOU5VK3Vm?= =?utf-8?B?d0RUR0Z6WWdxUzJVSUJVSGdIcGd6cDhpc2hMLzk2RW12eWRVNHBSMlQ3dGNn?= =?utf-8?B?dGFpWS9wRndmUThjNW1tZHNtZWZRNGhzZGd2U3p5L0cvd3dRTGxiNEhIRXB2?= =?utf-8?B?RERxc3V3S3gvTy9IVW5TQm85UG5KSWVxZ1JnWlR3bzRtRi93bFd0RlhEaEt5?= =?utf-8?B?dHRqeGtnMHJWa3pjTHoxWFlZTnVHeVQvNzJONlRycmpGUVdMNFZwd1lTM3hW?= =?utf-8?B?dWtpUWt2cHNURCsyVEp1Y2YvZGxidkU4L041elhCeGFSbFAvTkZJSGpBSDZw?= =?utf-8?B?cVpzQnBra0dzeXNEb3dGN2lOVTlwa0d0elU0YnMzQ0FabkdKVHBUZkI2cGhl?= =?utf-8?B?MmtQQVVLa3NFTjVuZnVDdE1ZUXUvbDVqQmhpcGpCN0tMMGtYNVQ5cUNNSEdL?= =?utf-8?B?dnBKUFVGbWhRcVB5SWxES2Fua09sSk0yak80S0hjbHVJdW8wNHFGQWFsQkJB?= =?utf-8?B?MnpYdGZnTlI1a2Z4dVIycC9OR1lnWUFZeE9yZEE2ZE04cUFWWmxTS2tHSlBw?= =?utf-8?B?dTVzMCtLU0IralpQZUJ3cTRkYkI5ZW1wMGhjUkJKWUVyN0w1ak5DWGZpMCtX?= =?utf-8?B?alFxOGt2V0FSZlo5eVhwTFA0Kzd6T1VWMTBjdTlBSWdZcDcrU1ZScXN3aUxu?= =?utf-8?B?dUxQN1dGMEFSNW5Nd2FmdXBuYkhNRFEram5aMmRUbE40VWc1VExEL1BqYWov?= =?utf-8?B?SlErblVJS0FIZzZOMlVycWU5dFJiMUVUZTRPVmllVUlqN0x5aSsxMXN3OVk0?= =?utf-8?B?RlhFSzFpaEZkMnZNSk5oQWkyTUl3QjlDMERINUZLWTFsS2NxQktQZEZET3p2?= =?utf-8?B?K3pLNmUzNGFSb3crTFpVZWt0THpBbGNsdkszQjNCWXMxMU9FMHJCaDYvMCsw?= =?utf-8?B?ZHBkUXpqR2dmNlJtaWhuN1JrSzBqUlBNR29rRDVyd0VLb2RoMWJHWXBWQkZL?= =?utf-8?B?SGN1amZrZHdFMXNSZjVMZno0VXRqZmFZT3hqZjl6TmxSZldxMmIrNEVFNkFG?= =?utf-8?B?QUw5MElNVlNKckZHQWxJMFltKzVleVVTRUZOYXc3b0xMcGJkU1BZNWc1T1g3?= =?utf-8?B?RThYTFoxcU1oMDY5eXNnZXlEQXF6eGdKVDB3dGh6S3NxcEl4Nys4bEI0Nzhl?= =?utf-8?B?RkxGVzZEZmQydjNkRjhUWkNCemJGYzZFdEhlRkxFMnN6TXRlODFLNlhQK1Qr?= =?utf-8?B?Y1hzQzN4SWhmbktQMWV4Vkg2Sy8vWXZPaGcrQ2dwc0lZRWZGcm9FQmNGSUgx?= =?utf-8?B?Z3o5VTZJWEg3Q2U3NVRoUm9VdUhCSTVCSTNGSFRJcVFRTURxdW9zcUJ5bkth?= =?utf-8?Q?OrLSUAJSyHkHUav7V/eF8F2JAALInDWRAfTUSgD?= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(376005)(82310400017)(1800799015)(35042699013)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 13:29:22.7419 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 629c2dcb-fc08-4fff-9ba6-08dc83d12e44 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF00009528.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB11091 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/3/24 09:40, Schimpe, Christina wrote: > Thank you for the review, Felix. > > Also it seems that my series introduces a regression on arm detected by linaro CI: > > https://ci.linaro.org/job/tcwg_gdb_check--master-arm-precommit/2549/artifact/artifacts/artifacts.precommit/notify/mail-body.txt > > The reason is probably this patch, but I am unable to reproduce this locally and haven't been able to figure out what might have caused this ... > >>> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index >>> 8d0553f3d7c..af62d3ae1ec 100644 >>> --- a/gdb/aarch64-tdep.c >>> +++ b/gdb/aarch64-tdep.c >>> @@ -4086,10 +4086,7 @@ aarch64_stack_frame_destroyed_p (struct >> gdbarch >>> *gdbarch, CORE_ADDR pc) >>> return streq (inst.opcode->name, "ret"); } >>> >>> -/* AArch64 implementation of the remove_non_address_bits gdbarch >> hook. >>> Remove >>> - non address bits from a pointer value. */ >>> - >>> -static CORE_ADDR >>> +CORE_ADDR >>> aarch64_remove_non_address_bits (struct gdbarch *gdbarch, CORE_ADDR >>> pointer) >> >> Shouldn't there still be some sort of comment for this function in the c file? >> At least some "see header file"? Though it seems like no function in aarch64- >> tdep.h has any comment, and all comments are in aarch64-tdep.c. I would >> also be fine with that for consistency. Maybe Luis can comment how he >> prefers it. >> >> But I am fine with this patch. Let's see if someone else objects this split. >> >> Reviewed-By: Felix Willgerodt >> >> Thanks, >> Felix > > Ok, let's wait for further comments here. Sorry, only spotted this now. The comment on the above function would be a repetition of the hook explanation, and the gdbarch hook explanation covers all the details we need. But if the comment is being removed due to it being in the header, we should point to the header instead. "See aarch64-tdep.h" should do. There is something odd about this patch though. The aarch64 code is being changed to call aarch64_remove_non_address_bits directly, but 3 new hooks are being set: + set_gdbarch_remove_non_address_bits_watchpoint + (gdbarch, aarch64_remove_non_address_bits); + set_gdbarch_remove_non_address_bits_breakpoint + (gdbarch, aarch64_remove_non_address_bits); + set_gdbarch_remove_non_address_bits_memory + (gdbarch, aarch64_remove_non_address_bits); But the above hooks (the gdbarch_remove_non_address_bits_memory at least) never get used in aarch64 code. Is there a reason for that? > > Christina > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928