Re: [PATCH v2 02/29] linux-nat: introduce pending_status_str

[Simon Marchi <simark@simark.ca>]

On 2022-07-13 18:24, Pedro Alves wrote:
> I noticed that some debug log output printing an lwp's pending status
> wasn't considering lp->waitstatus.  This fixes it, by introducing a
> new pending_status_str function.
> 
> Change-Id: I66e5c7a363d30a925b093b195d72925ce5b6b980
> ---
>  gdb/linux-nat.c | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
> index 0a93ab5c6ae..57cab4ce50a 100644
> --- a/gdb/linux-nat.c
> +++ b/gdb/linux-nat.c
> @@ -255,6 +255,17 @@ is_leader (lwp_info *lp)
>    return lp->ptid.pid () == lp->ptid.lwp ();
>  }
>  
> +/* Convert an LWP's pending status to a std::string.  */
> +
> +static std::string
> +pending_status_str (lwp_info *lp)
> +{
> +  if (lp->waitstatus.kind () != TARGET_WAITKIND_IGNORE)
> +    return lp->waitstatus.to_string ();
> +  else
> +    return status_to_str (lp->status);
> +}

IIUC, it is a precondition of this function that LP must have a pending
status?  Otherwise, it would enter status_to_str and return some bogus
string and be really confusing.  I would suggest either:

 - Adding an assert with lwp_status_pending_p.
 - Handling the case where LP does not have a pending status, and return
   a string like "none".  That would allow us to use that function
   without having to check with lwp_status_pending_p first.

Otherwise, LGTM.

Simon