From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A6DEE3858D3C for ; Thu, 10 Nov 2022 11:41:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A6DEE3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668080485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2/bCKbzVD0ShDki1P7YmaEIdJV6gmJbCaEyhiQmOoHc=; b=E/GWjO2JHzNRkQ9lnB1IvOP8rnK0sMTmQrp0I5vrsSHFzLP1MWqOxZQo0WOGt5MRZJF0KI 8QKjl+/TFLO1quHvYamZNFYhx4TO5FZ0tLH9PIPwbmsS52UToz/FZD/nEgOpLthJXRgEz8 bkImPUA5doV5eEQqWNa1ARHbAS3y8Zc= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-458-194H7B1kM72Rmn5LbMg2BA-1; Thu, 10 Nov 2022 06:41:24 -0500 X-MC-Unique: 194H7B1kM72Rmn5LbMg2BA-1 Received: by mail-qt1-f197.google.com with SMTP id f4-20020a05622a114400b003a57f828277so1126296qty.22 for ; Thu, 10 Nov 2022 03:41:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2/bCKbzVD0ShDki1P7YmaEIdJV6gmJbCaEyhiQmOoHc=; b=NZtOcUSWsMGVl3Z674Om7iGvW2V0KUVrG/UwrLuHYHVIVEXWUrWE0MLyO53ZTyj8wv Kjn1dRQrTEG6W3ji+5v7PVzdLHiepDAajNsLN81LlwNQkNQSxN0NjubSmZ5xOF5kdGbw szeeqmGqq2zlAVzKsaSiixrmaeqfWbsKHfcyPSVN1/k3D+obYzA2YjluCX2ST2SQpIpW laroU4HPsigRujLxCNIU/mR+xAGvKcAp21EbgttrgoYuz5YbbbwspFbQ0ENE6E9+EUfu D8zi/kMH6TO/6ieF9kNwfKaC8OzMDbWJnqh0600xd/GC6W6TXDaRfv0y/fOBzIigw5yE IarQ== X-Gm-Message-State: ACrzQf3Up+151m3yeNzb/+HVFyrR5OrzHureKVDKa65rUO+i03hYzs2i VOsZ5W7H3HD1fZcgefX5ePk4Ysr6uSBBLchdutzqciD3q3ouxV72utXQmNBLMmkuB8cBM38g264 k2mODr9jhIwkdGvQB4fDRiw== X-Received: by 2002:a05:6214:29e3:b0:4bb:a93c:6d88 with SMTP id jv3-20020a05621429e300b004bba93c6d88mr58255887qvb.105.1668080483381; Thu, 10 Nov 2022 03:41:23 -0800 (PST) X-Google-Smtp-Source: AMsMyM7K4jx0fS/eELGXzDRW2vuDYqf+ycFYVDqU7f+OA3qXq7Tz/zSEc6hasM5eYIrjdN3oktnZtQ== X-Received: by 2002:a05:6214:29e3:b0:4bb:a93c:6d88 with SMTP id jv3-20020a05621429e300b004bba93c6d88mr58255880qvb.105.1668080483189; Thu, 10 Nov 2022 03:41:23 -0800 (PST) Received: from [10.202.9.92] (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id a3-20020ac84d83000000b003a530a32f67sm10895676qtw.65.2022.11.10.03.41.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Nov 2022 03:41:22 -0800 (PST) Message-ID: <367d2607-6667-cdb2-838f-6b743afbc500@redhat.com> Date: Thu, 10 Nov 2022 12:41:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2 1/2] gdb/testsuite: allowed for function_range to deal with mangled functions To: Tom Tromey , Bruno Larsen via Gdb-patches References: <20221104154744.418906-1-blarsen@redhat.com> <20221104154744.418906-2-blarsen@redhat.com> <874jv82gni.fsf@tromey.com> From: Bruno Larsen In-Reply-To: <874jv82gni.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 09/11/2022 18:15, Tom Tromey wrote: >>>>>> "Bruno" == Bruno Larsen via Gdb-patches writes: > Bruno> When calling get_func_info inside a test case, it would cause failures > Bruno> if the function was printed using a C++ style mangled name. The current > Bruno> patch fixes this by allowing for mangled names along with the current > Bruno> rules. > > Looks good. Thank you. Thanks for the review. Which email should I add to the Approved-by tag? -- Cheers, Bruno > Tom