From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16404 invoked by alias); 31 Aug 2016 17:52:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16391 invoked by uid 89); 31 Aug 2016 17:52:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Aug 2016 17:52:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9D7B8635C8; Wed, 31 Aug 2016 17:52:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7VHqFhQ012609; Wed, 31 Aug 2016 13:52:15 -0400 Subject: Re: [PATCH 1/2] Fix lwp_suspend/unsuspend imbalance in linux_wait_1 To: Antoine Tremblay References: <20160831171406.24057-1-antoine.tremblay@ericsson.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <367f43f2-aacf-672f-5a1f-2d7b16381e85@redhat.com> Date: Wed, 31 Aug 2016 17:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-08/txt/msg00332.txt.bz2 On 08/31/2016 06:50 PM, Antoine Tremblay wrote: > > Pedro Alves writes: > >> On 08/31/2016 06:14 PM, Antoine Tremblay wrote: >>> This patch fixes imbalanced lwp_suspend/unsuspend calls caused by the >>> premature choosing of another event for fairness. >>> >>> select_event_lwp would switch the event before a call to >>> unsuspend_all_lwps, thus it would be called with the wrong event. >> >> Hmm, that does sound wrong. >> >> Patch LGTM. >> > > Thanks, pushed. Could you push it to 7.12 as well? I wonder whether this might fix: https://sourceware.org/bugzilla/show_bug.cgi?id=20176 Thanks, Pedro Alves