From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96485 invoked by alias); 7 Sep 2018 23:13:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96469 invoked by uid 89); 7 Sep 2018 23:13:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=whatsoever, xsave X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Sep 2018 23:13:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1536361991; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kSkYXSPblUs/dYejLLAeE1keMpUM5KSPuib3CpkP7Q4=; b=Rtcbi4Wun3gI6zoazuSrxrHcb00rvsGz3mWjhhOEsU5lhGVm4ulD0sj2ZJowPY7p /hbtJPmIvelJqS6ntTMAvj6kLoXxMVfWW/jxPGMGJhDSHFTy3AzTUn74BQ/lkzdU rUUV9ft18sbEcTBlrgjjaclendtykYKLdZYHq/JVPDU=; Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id DA.6A.31332.706039B5; Sat, 8 Sep 2018 01:13:11 +0200 (CEST) Received: from ESESBMB505.ericsson.se (153.88.183.172) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Sat, 8 Sep 2018 01:12:16 +0200 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Sat, 8 Sep 2018 01:12:16 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gOcDPNnUqkNyGIqZGNoCRIiovQj6lR3w8DJ16gvBlNY=; b=co0/9JPDpVKS6pOf/2iddoaci3cMW4JNZRRX13qR5YqMCvJekH9PzWmX3F8zPukj0CivirTXEvFB8qAWlO8vfSqueufpTJ+2fvVVrqUTzpQR1TRTYsItM0q+4/PwW/1GdG8mI4fYyPYehZjhtSciGKG0ArtPweSu+7+jnXvZTtk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [100.94.56.16] (192.176.1.80) by DM6PR15MB2394.namprd15.prod.outlook.com (2603:10b6:5:8d::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.18; Fri, 7 Sep 2018 23:12:12 +0000 Subject: Re: [PATCH] x86-64: fix ZMM register state tracking To: Jan Beulich , GDB References: <5B8FD8B302000078001E5940@prv1-mh.provo.novell.com> CC: "Wiederhake, Tim" From: Simon Marchi Message-ID: <369f9b84-77e3-3fa4-f363-a89ee503cff4@ericsson.com> Date: Fri, 07 Sep 2018 23:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <5B8FD8B302000078001E5940@prv1-mh.provo.novell.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00143.txt.bz2 Hi Jan, Would it be possible to update or create a test to exercise that? arch-specific tests are in testsuite/gdb.arch. I have some comments about the form. Tim, could you or somebody else from Intel take a look at the functional side of the changes? On 2018-09-05 02:22 PM, Jan Beulich wrote: > The three AVX512 state components are entirely independent - one being > in its "init state" has no implication whatsoever on either of the other > two. Fully separate X86_XSTATE_ZMM_H and X86_XSTATE_ZMM handling, to > prevent upper halves of the upper 16 ZMM registers to display as if they > were zero (when they aren't) after e.g. VZEROALL/VZEROUPPER. > > gdb/ > 2018-09-05 Jan Beulich > > * i387-tdep.c (i387_supply_xsave): Split handling of > X86_XSTATE_ZMM_H and X86_XSTATE_ZMM. > (i387_collect_xsave): Likewise. > > --- a/gdb/i387-tdep.c > +++ b/gdb/i387-tdep.c > @@ -923,7 +923,8 @@ i387_supply_xsave (struct regcache *regc > enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); > struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); > const gdb_byte *regs = (const gdb_byte *) xsave; > - int i; > + int i, zmm_endlo_regnum = I387_ZMM0H_REGNUM (tdep) > + + std::min (tdep->num_zmm_regs, 16); The GNU standard requires to parenthesis when breaking lines: int i, zmm_endlo_regnum = (I387_ZMM0H_REGNUM (tdep) + std::min (tdep->num_zmm_regs, 16)); Simon