public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] gdb/testsuite: fixes for gdb.xml/tdesc-regs.exp
Date: Tue, 16 Jun 2020 15:08:59 -0600	[thread overview]
Message-ID: <369fc78b-2e7c-545d-fc19-53193fa93f64@codesourcery.com> (raw)
In-Reply-To: <20200616204701.GT2737@embecosm.com>

On 6/16/20 2:47 PM, Andrew Burgess wrote:

> I'd be interested to know more about which targets don't place any
> registers in the 'general' group.  This group is used in
> default_print_registers_info to implement 'info registers', so I'd
> like to see what this particular target has done instead.

nios2, for one.  From the original test log for nios2-linux-gnu:

maintenance print reggroups
  Group      Type
  foo        user
(gdb) FAIL: gdb.xml/tdesc-regs.exp: maintenance print reggroups

I don't have a mainline build for ARM handy but the failure reproduces 
on GDB 9 branch for arm-none-eabi.

This is Abid's original summary of his investigation in 2018:

   There are 2 reggroups maintained in the code. One is the
   default_groups which is populated in _initialize_reggroup. This group
   has 'general' group. So if you do 'maint print reggroups without
   loading anything in gdb, you will see 'general' group.

   The other group is stored in reggroups_data. This is populated when we
   load a target description xml file. So it only has group defined in
   xml file. But if has a valid group, then 'maint print reggroups' will
   not use default_groups. So that command will not print 'general' group
   if xml files did not have any.

   For x86, we have slightly different behavior. Its tdep code calls
   i386_add_reggroups which add 'general' group to reggroups_data as
   well.

   So this testcase assumes that 'general' group is always present. This
   asumption is true on x86 only not in general. So I have removed it
   from the match pattern.

-Sandra

  reply	other threads:[~2020-06-16 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16 20:04 Sandra Loosemore
2020-06-16 20:47 ` Andrew Burgess
2020-06-16 21:08   ` Sandra Loosemore [this message]
2020-06-18  9:43     ` Andrew Burgess
2020-06-19  2:18       ` Sandra Loosemore
2020-06-19  8:03         ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=369fc78b-2e7c-545d-fc19-53193fa93f64@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).