From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id B4DA93857C5F for ; Wed, 24 Mar 2021 14:04:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B4DA93857C5F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12OE4cUI014244 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Mar 2021 10:04:42 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12OE4cUI014244 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A89121E789; Wed, 24 Mar 2021 10:04:37 -0400 (EDT) Subject: Re: [PATCH 1/2] gdb: move all "current target" wrapper implementations to target.c To: Andrew Burgess , Simon Marchi Cc: gdb-patches@sourceware.org References: <20210323184138.876503-1-simon.marchi@efficios.com> <20210324092921.GH5520@embecosm.com> From: Simon Marchi Message-ID: <36aa49c4-91f0-c6eb-bc20-d5ace63eda9e@polymtl.ca> Date: Wed, 24 Mar 2021 10:04:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210324092921.GH5520@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 24 Mar 2021 14:04:38 +0000 X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 14:04:46 -0000 >> diff --git a/gdb/target.c b/gdb/target.c >> index afc4b2cbbb6..e7af5e8a9b0 100644 >> --- a/gdb/target.c >> +++ b/gdb/target.c >> @@ -215,6 +215,564 @@ target_has_execution (inferior *inf) >> return false; >> } >> >> +const char * >> +target_shortname () > > There are a few of the functions here missing a header comment. As a general rule, I don't put the /* See header.h. */ comment if the declaration in header.h doesn't have a comment. Otherwise, that's meaningless. Of course, all declarations should have a comment, but it's not in the scope of this patch to add them. target_shortname has a comment above it but... it doesn't really describe what it does... Simon