From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 6374F3893677; Wed, 16 Nov 2022 03:59:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6374F3893677 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52f.google.com with SMTP id f3so9111587pgc.2; Tue, 15 Nov 2022 19:59:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KfpQ454IHWVf+kfCHwEz+htJtVAqfKDGQ/oTsks5gFE=; b=hP0hzxTrdkFX4UHFSKsdLu7MuEiilPYFKIzmNlKF9xFtHwo+zv5uvnJhCwE0BDoLhH ql8yahq3eyL/vt5UKPZrTnvB6f7+omdZAupuPr5CkBL12z/YaJkp0wdjouqX7KM+i/XY GuTuEExxIq5LCTZflCQaA1zG8GamreECkYKHANH1XPNQtNxX+kCdBuBdqMwNxc8R95QY WWFOqJ2inarDJs7Vgd7UZn9Bqoqh+y5MrqMqYGjbLotmZVH8Ug408YYNi/bfqelTO+Zx CVTl0T6EZy1cGnHQOKEtg1rKpc3dxGkr0DZB/4/WN47S08IjdDHq8ubfvjP3SaC5emPY m2xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KfpQ454IHWVf+kfCHwEz+htJtVAqfKDGQ/oTsks5gFE=; b=RVHKMXMWiGS4iV9KumVhosuh4/OJxYynEqaOf6wGQXvy/BiQQ2zhZ9LpseI565em4W J2n0LffiZPY+muymAtb49arOkhpGBp+OoTIXsxl2FbMf79zRF0JHiMGZqaHqAZrxQBQA RPOKpR6Y+wg0h92GiqkbG46Qj8Q+u/SDEV2xxDmsYZqiB4/lqfFGk4NKBDhM0Q8Oikx9 JxWBIATTFenI03gq4j4+ASdtVcI6Azi4KaY/OlAVHnbuWJKpUB0se5/zv3cZxmiets/O SJewJaULL2nAS1F9th3OZWNc6G6l31VDXje5eLroubmNNubr7T9h5B8zWCTuorIMGn8I A0ig== X-Gm-Message-State: ANoB5pnXx4SLBWE8Md0pQ2sUoC3fQcbM0JxAxE4pcoBa0fKeEAWq6/VJ FjS30KLZ2QMlWlXpW88qdZ4= X-Google-Smtp-Source: AA0mqf71n/rXgItmqQPM+QN9fDdVGyhSpHCA5FMOcd0DJGCu2YSUEjw/y8km5Fl8cbq7kHT9tJdgig== X-Received: by 2002:aa7:8c09:0:b0:56c:2a86:d74 with SMTP id c9-20020aa78c09000000b0056c2a860d74mr21154937pfd.73.1668571150566; Tue, 15 Nov 2022 19:59:10 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id d12-20020a630e0c000000b00470537b9b0asm8624662pgl.51.2022.11.15.19.59.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 19:59:09 -0800 (PST) Message-ID: <36e23439-0429-0c02-1998-0b7a025fa64c@gmail.com> Date: Tue, 15 Nov 2022 20:59:07 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCHv2] Use toplevel configure for GMP and MPFR for gdb Content-Language: en-US To: apinski@marvell.com, gdb-patches@sourceware.org, binutils@sourceware.org, gcc-patches@gcc.gnu.org References: <1668107159-16961-1-git-send-email-apinski@marvell.com> From: Jeff Law In-Reply-To: <1668107159-16961-1-git-send-email-apinski@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/10/22 12:05, apinski--- via Gcc-patches wrote: > From: Andrew Pinski > > This patch uses the toplevel configure parts for GMP/MPFR for > gdb. The only thing is that gdb now requires MPFR for building. > Before it was a recommended but not required library. > Also this allows building of GMP and MPFR with the toplevel > directory just like how it is done for GCC. > We now error out in the toplevel configure of the version > of GMP and MPFR that is wrong. > > OK after GDB 13 branches? Build gdb 3 ways: > with GMP and MPFR in the toplevel (static library used at that point for both) > With only MPFR in the toplevel (GMP distro library used and MPFR built from source) > With neither GMP and MPFR in the toplevel (distro libraries used) > > Changes from v1: > * Updated gdb/README and gdb/doc/gdb.texinfo. > * Regenerated using unmodified autoconf-2.69 > > Thanks, > Andrew Pinski > > ChangeLog: > * Makefile.def: Add configure-gdb dependencies > on all-gmp and all-mpfr. > * configure.ac: Split out MPC checking from MPFR. > Require GMP and MPFR if the gdb directory exist. > * Makefile.in: Regenerate. > * configure: Regenerate. > > gdb/ChangeLog: > > PR bug/28500 > * configure.ac: Remove AC_LIB_HAVE_LINKFLAGS > for gmp and mpfr. > Use GMPLIBS and GMPINC which is provided by the > toplevel configure. > * Makefile.in (LIBGMP, LIBMPFR): Remove. > (GMPLIBS, GMPINC): Add definition. > (INTERNAL_CFLAGS_BASE): Add GMPINC. > (CLIBS): Exchange LIBMPFR and LIBGMP > for GMPLIBS. > * target-float.c: Make the code conditional on > HAVE_LIBMPFR unconditional. > * top.c: Remove code checking HAVE_LIBMPFR. > * configure: Regenerate. > * config.in: Regenerate. > * README: Update GMP/MPFR section of the config > options. > * doc/gdb.texinfo: Likewise. If the GDB folks confirm they want this behavior, then the toplevel bits are fine. Jeff