From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 705963858D32 for ; Mon, 16 Jan 2023 16:07:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 705963858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5E52D1E0D3; Mon, 16 Jan 2023 11:07:42 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1673885262; bh=puSFjMJJi4ulmZcwfDS7t44iSAe6a+RjcT7OQgXOzSg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Q0id1zW+4tNI9OZMpLcsM+ckIHkPdueSl76QXxnjBQuaKl29bKcluOqKEFyo7jCgw ctmVJoWmF32NbrjYyrkvSri+Ogcdu22uKFGilNp4wGfxau/4w0vH/A1dY0Tdr/TXGF GwLjtkR8rOE6ov5ab0cc2kWwPBKpkEIRPbnrTvfQ= Message-ID: <36f2e8b0-b5e4-7f0f-8bf0-e4e3f46862f5@simark.ca> Date: Mon, 16 Jan 2023 11:07:41 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 0/9] Fix gdb.dap/basic-dap.exp for PIE Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230106185729.42372-1-simon.marchi@efficios.com> From: Simon Marchi In-Reply-To: <20230106185729.42372-1-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping. On 1/6/23 13:57, Simon Marchi via Gdb-patches wrote: > The last patch of this series fixes a FAIL I get in > gdb.dap/basic-dap.exp. The rest of the patches are small improvements I > made to lib/dap-support.exp that helped me get there. > > Simon Marchi (9): > gdb/testsuite/dap: use gdb_assert in gdb.dap/basic-dap.exp > gdb/testsuite/dap: prefix some procs with _ > gdb/testsuite/dap: write requests to gdb.log > gdb/testsuite/dap: make dap_request_and_response not catch / issue > test result > gdb/testsuite/dap: remove catch from dap_read_event > gdb/testsuite/dap: pass around dicts instead of ton objects > gdb/testsuite/dap: rename dap_read_event to > dap_wait_for_event_and_check > gdb/testsuite/dap: make dap_wait_for_event_and_check return preceding > messages > gdb/testsuite/dap: fix gdb.dap/basic-dap.exp disassembly test for PIE > > gdb/testsuite/gdb.dap/basic-dap.exp | 73 ++++++++++------- > gdb/testsuite/lib/dap-support.exp | 121 ++++++++++++++-------------- > 2 files changed, 102 insertions(+), 92 deletions(-) >