From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2098.outbound.protection.outlook.com [40.107.94.98]) by sourceware.org (Postfix) with ESMTPS id AB1073846410 for ; Wed, 3 Apr 2024 12:56:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB1073846410 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AB1073846410 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.94.98 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712149016; cv=pass; b=Tw5VPr0lecneot8y99XuFO0wG3hpFnA6QUDx2B+FpFI3WRopdfjiuAGrnTngA/VsRo7zXoC5yQrMC8vsL91caYgEKCH66DI3XYiALS5FAvRQsvub6Ie4rhv2gonYkGQBIRpi9TH4L2y7p+WNeHWMOGKoWGvU47vRvlT0CRuRQYg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712149016; c=relaxed/simple; bh=Y1IcXIx90A52au7nWGKCccb56pW7ck8fOcrgxfSeVl8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=Jn827sU8Pu7q5Gzwhj6Wpnoy6slRrNdtAscrTNimY2SXLl3TyvvuRvikwNPRJvq/kt8eWjwiozaV59HQVPcuDzMaDXcwaT+VRFgCTEFiiEQxFATTfAgEYneCRhLZTdVSjbRoyrx3hd4iCyhmEhM818UuKVa5wYiIc/0JIUjuoFk= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JkEpLWPsyeKnACLg2s45l9B0Tr9fU5zikYUwK72gt1U/shpx9fj9nAYaJndtsYPWb2Efj74r2RCl5D4uvzijy07D/cGyc6dp1gcpwjiFmd0sK3GpaF3s0FkKxnxWZho4hrPc4/weEQ21kOwxuIRjCqaVRHptvI02AO11bxfYVCEU0DCgDhTvYiU6nGEyYSBVGG1UxqDMBdIaOf4388DUQbkxaFSC8jKXWMIZRmEGcGtZrBzrrSMTf4KKhVgGjhdc/pSwfW5CZGpQlgwUWnjvA6Wuo5We1902JPzCW+1eJzDFOxlr30LUj5QfMqsYCnoNiP9NIhXaSkFb6k2L24Brsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MIDa86lPrc/XkJbZF3sF/4IMXfKacEUY3RtWLEzg7s4=; b=ABuOv/TNJcAU+S79XLN2INHvOz13mqkPwT7Ka/5EuKxcyt7j+g2NdSgoJnwg4DGBendv8yWVo6L3LntzfbmM4SCtcxb6tlcLom4TN1pIJqHOHdxSYveOKZ6ceI+WgO8rrB8k17qaOMKMhrVtjtYHJ77c8lg+QcIwsrNGBwzoXxVlgQjcw9v8+G6Uw8zWBfDNhGcYLCjXAcrXda+pMD8q3iDLxObITbIs0Y3KG0KF5Y7g/IU94DvvQpHRU5Ij7T/Kh6vP/ghDYuX6SZJaXKyixnvSksob5SBhY9mQ7UFsndFY4SJCLJgLrJCp5ddZtdXeu32OstClrna7BpLl5mtSdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MIDa86lPrc/XkJbZF3sF/4IMXfKacEUY3RtWLEzg7s4=; b=n0qY3hQpMFZcTPrFEWzdDbr2A60vRQXRIWOdN3PZdm4IZ1GWAk5AarSXGo/LsUnMyMccV/DoI7aAxuxk1g8JNfkJqa61My5hVoAPz7S50hGJeeH7HruJrAjj9QF+PqeJkbSkJJvjafePt8d2PD1Sk/iZwM8ziH7+9zjJ9CwS0ac= Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by CYXPR12MB9338.namprd12.prod.outlook.com (2603:10b6:930:e5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 3 Apr 2024 12:56:53 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::f98e:8d91:f485:89f9]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::f98e:8d91:f485:89f9%3]) with mapi id 15.20.7409.042; Wed, 3 Apr 2024 12:56:53 +0000 Message-ID: <36ffdc32-34e1-4ae0-851f-c50b49c938b8@amd.com> Date: Wed, 3 Apr 2024 13:56:48 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/compile: Use std::filesystem::remove_all in cleanup To: Tom Tromey Cc: gdb-patches@sourceware.org, lsix@lancelotsix.com References: <20240303164756.870514-1-lancelot.six@amd.com> <8734t0sn8d.fsf@tromey.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: <8734t0sn8d.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0425.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d1::12) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|CYXPR12MB9338:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: US3VevGpJXVU1O0Cv2R1QFvgNDC1JEuA7fPVfDj3YWGwc28d8eb+GHtHZDyfUr9qhsReWvLxy2LwVGUKz89KSbXw2y3twiMQar8DZrblK+KHow86ddZnJhrE7Hxq6kmeJz/HIVPInl0w5DRgDURoI+X+7YXpIrYLNb8/mTkjZ4P/5E9K6mlW8nx1n4fUejlRSOW8w9ynToM9EncsA4xyxxR3t36MypZE4rMivhnOAEnaTdQ5XcqOvf+OlbZvQ7pLaUZiAycx2lSXiSzT4+G9WXxGceXlk0JFMUWpOeaBuskegbdKnHOK+Gf+1c4JqwsJkkkKEAHk9TYNmbFrCNg1q3CsB0Xc2blN+7d7vEiF32IbJEKkZoX9lci69kUg0OcqB65X7y1Uxdjgz17OUOvWZzwNpcVhq3Vqgv5084ke4v+P0M7Xad3XCKfA49aSsvONbLLyimDK1+77MSRjFootK/FnMFPzUyhpJT35M+UJknUA5wYRYlHQXZVjJF/MbUK9dSrsHLsN4UKv8V4f3NWzeyBtFOTa/tdGf3gDzNbMdgBnYRuj2n3clFC1QK+b5qVSF3aEUiWU5WEdhWHQ7s0LSoqJt97je/VAJ/wKXWDx6XsF1dWMkfM8WBA+S6L5z3w2mml8pjZknppgaK3QWS4ZqS/bDxXGAgohxhKCwjVrq+U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB9079.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWFOeVA0VmhZbUdsbzZGVXBzbDRhVUdhZk9VNkVMb2FhVHNsWVhIUzNsOXFP?= =?utf-8?B?bnZML2x6TnRIY29DbGZRLzhSUzBLY2dsOTllMDlpMk1sdlYvTEhkV1NGdWFQ?= =?utf-8?B?cUtCczNqa2NtaE82Szc1MXUxNnROVUk4THlwQnNvQWxFSms0VFNaenhlY3k0?= =?utf-8?B?S2E4K0RKcXdXdUZnOVVrMHlrcy83bXRrVzE5OCtpQW5qRHhpcnVwMzYyU1ZF?= =?utf-8?B?emZmUzdubGpFeTNUaFZpbVc0RmlzRGdyOXBsMVlqbVpGT2ptOGgyTDlleTc2?= =?utf-8?B?ZmwrTnFEL0laWFNXcXRjY01FOTV3d1hUUFV0TWpQZ2VXSHR2L1lXY1dLa3pi?= =?utf-8?B?TlVHWEZxdzJTQ3ViRE9OTHBMQkdWRkFuTGZJS3BCcWFERERnSlJZa1MvT29w?= =?utf-8?B?TDFMNEZ0QmU2V2QrTHFtTGE2UTBmZnh3TXJ6ckRJU0p1VlgyWmFSYUcxOUFn?= =?utf-8?B?djB6aDVJQm5aYXNEZU9xYTIwYjUyV1BtdWgvd1NlblBsVEh2cG1RUHNZOEhI?= =?utf-8?B?ZUgzeEJFRDNqRW9OcnBXRHBmN1o2Z052d0x0M3A1L0ZYYWhscEhDWnYvV3Bk?= =?utf-8?B?REVwUENTOXRSMGdkQUJnZFlNWUVURDZaL0Y4UENGeDIxem9LVHIzb092Tk9S?= =?utf-8?B?SStWREloUy9CRlNrZWgzZVhGSTBIazVZb0pKVDZOZ04zcmFoVWdzVXNHWjdL?= =?utf-8?B?NTJ3VXNvUGxzVkl6WFVqNTVWZXk2Si9vK2NHUEZaaEl5eU93TGt0V1hkb3Z1?= =?utf-8?B?OHAvQ3dOKzFCSFd4bkFmVm0wVEkwTzQ5MkJCc3lseXRkVDdONjVCOTZpelR1?= =?utf-8?B?YlJnTTB5cXpoRXpVQ1NYNHFzcFpYazEwL2psaEdlcENuVkltZGc3WWhDQWZW?= =?utf-8?B?THp5V0NubzJRSHlHd2grMHQyUzluMEZ5bjFaVnBZTnVKV2lZcEpkaU81azN1?= =?utf-8?B?aUZuUmxoWkhaMzE4QjVDOC9BWnVrbmNNRVozbUJld0JoVDliTG9sVjNrQnNk?= =?utf-8?B?dSszSTFzV1lORUZyVHJDUHlNdS85VEpOYVYybkdLSm9kS3ltUjRESzVXS2xx?= =?utf-8?B?UzZBejBUT21DTVB2NmFtc3hLSTF2SldKTWNVWEdVaUNkK1c0ck8rcGVlMUhk?= =?utf-8?B?Q1V0aHNFdXErRkZiQlNobkZabllVZ1RwaEJ0SE1DM0VpVnV1L3JOMEk5ckox?= =?utf-8?B?QmYrd2dxaWlLbmt5TUZsYzl2dWl4L3NkR2RpTjdubCs3Z0JtQVp0eDNPaHNn?= =?utf-8?B?Z0lNU1RMYVZRMzBwNGY2VkNOY05laUhkTHA2Mkh2bXl0cUtjRDlBWk0ycEdL?= =?utf-8?B?VU5QTDU1RVdiZDg4TXk1bVRla1gxSHFHRytRVUYrTVJucktIVGZ4RDU3ZUJi?= =?utf-8?B?ckpMNzIzTjBuTEVPNkE1YXlqSlJobkdETjRtOFRUb0lxWTl1VVgraFI5eGln?= =?utf-8?B?K2hpcVF6TUNTZFgvZFduZkNVTUdVeGVSZzJvNnpCQU56M3B2K1k4UDFaZ3dv?= =?utf-8?B?M01EVlpmVUxpY0tXVjFRd0l3Q21WQzVIRUF5eENtK3l5NnJ5ZmNvWTV2bmor?= =?utf-8?B?cERmQnZDMDBTNkEwcVhXZlJrclRMeElyTzVkVUxsNVFHYXdKbmFvVmx0TC9Z?= =?utf-8?B?SnZWOXVLYVI5Yjd3TTcvb0lyU014ZWZldUtBNTBTMGk3MzQyb0tnMHJLOUg2?= =?utf-8?B?MHUrYkJtSkIybjF3cHVYUk9HV3ZxYjR5WkN3MFpBM1Bkb0ltSFlCUHl6MUNZ?= =?utf-8?B?SHdwMUY5bTRNZlhkZHhhQ0lhZ2RKZEx5MkRUcTA1elEvVjdsTkFSNy8wUFN3?= =?utf-8?B?blQ5SW9VUWh1c2dGWnJaelk2dnIyeEpxU2NBZ0d1enUyWWZkeWpZRkdscHRW?= =?utf-8?B?TXVzaVk2b0hUVmlLcjlUS0xLbUZkTlZFNXlJbUtpSDNiVmZoRjU5WCsycFlS?= =?utf-8?B?RHp1U3lSRitEUkszYzdnb1JWMVFRNlczUy9QbFV6MDZMY25EQUc0akxaTHpN?= =?utf-8?B?Z3A0dVBkNis5ZmYyOHcrTEc0VU5ybkhZY2ZsOWFieHcwZnBNTzB2VGpLYUE0?= =?utf-8?B?WGd2ZkxLVVoxOTdwenhkOVpxWk9aenRidjIxODV5eWUzM0tXb0RxQlNVbW9t?= =?utf-8?Q?B/d4m0Fg1mGgH8cH24p2XSRKW?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa3b6b76-2cbd-49f9-1a13-08dc53dd88ef X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 12:56:53.2536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E8r0kZWXA+sHRj1YPWFx9WamXnL+U+jZDxNCPFI442IYfSfec35JPiTySwo2shCg6cHfbKmz2GYi422FxxfU/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9338 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Thank you. I think this is ok. > > There might be some risk that there's a compiler that implements C++17 > but not std::filesystem. If this happens I suppose we can either > consider simply rejecting that compiler, or alternatively, revert this > patch. > > Approved-By: Tom Tromey > > Tom I have just pushed this patch. If it turns out that this causes any issue for some configuration, I'll revert the patch. Best, Lancelot.