From: Hannes Domani <ssbssa@yahoo.de>
To: Tom Tromey <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 5/5] Fix cast types for opencl
Date: Tue, 11 Jun 2024 19:34:06 +0000 (UTC) [thread overview]
Message-ID: <373040904.7646789.1718134446949@mail.yahoo.com> (raw)
In-Reply-To: <871q53gtsv.fsf@tromey.com>
Am Dienstag, 11. Juni 2024 um 21:31:48 MESZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
> >>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:
>
> Hannes> Apparently opencl doesn't have the 'signed' modifier for types, only
> Hannes> the 'unsigned' modifier.
> Hannes> Even 'char' is guaranteed to be signed if no modifier is used, so
> Hannes> this changes the casts to match this logic.
>
> I ran "make check" and see these opencl failures, so I think this ought
> to go in.
>
> Approved-By: Tom Tromey <tom@tromey.com>
>
> We were talking about landing this on gdb-15 as well... I'm in favor but
> perhaps others may comment as well.
Pushed on master, thanks.
Hannes
next prev parent reply other threads:[~2024-06-11 19:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240531114801.2745-1-ssbssa.ref@yahoo.de>
2024-05-31 11:47 ` [PATCH 1/5] Restore bitshift.exp tests Hannes Domani
2024-05-31 11:47 ` [PATCH 2/5] Fix right shift of negative numbers Hannes Domani
2024-06-11 18:15 ` Tom Tromey
2024-05-31 11:47 ` [PATCH 3/5] Fix too-large or negative " Hannes Domani
2024-06-11 18:16 ` Tom Tromey
2024-05-31 11:48 ` [PATCH 4/5] Fix 64-bit shifts where long only has 32-bit size Hannes Domani
2024-06-11 18:28 ` Tom Tromey
2024-05-31 11:48 ` [PATCH 5/5] Fix cast types for opencl Hannes Domani
2024-06-11 18:29 ` Tom Tromey
2024-06-11 19:31 ` Tom Tromey
2024-06-11 19:34 ` Hannes Domani [this message]
2024-06-11 18:11 ` [PATCH 1/5] Restore bitshift.exp tests Tom Tromey
2024-06-11 18:38 ` Hannes Domani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=373040904.7646789.1718134446949@mail.yahoo.com \
--to=ssbssa@yahoo.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).