Re: [PATCH] Fix AIX build break.

[Simon Marchi <simark@simark.ca>]

On 2024-06-09 01:38, Aditya Vidyadhar Kamath wrote:
> From: KamathForAIX <Aditya.Kamath1@ibm.com>
> 
> A recent commit https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=9102a6c15c756c55e77c0fa7deecfc58fa8a361e
> has broken AIX internal CI build for GDB.
> 
> The error is as follows:
> CXX    tui/tui-win.o
> tui/tui-win.c: In function 'void tui_sigwinch_handler(int)':
> tui/tui-win.c:532:3: error: 'mark_async_signal_handler' was not declared in this scope; did you mean 'async_signal_handler'?
>   532 |   mark_async_signal_handler (tui_sigwinch_token);
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~
>       |   async_signal_handler
> tui/tui-win.c: At global scope:
> tui/tui-win.c:538:1: error: variable or field 'tui_async_resize_screen' declared void
>   538 | tui_async_resize_screen (gdb_client_data arg)
>       | ^~~~~~~~~~~~~~~~~~~~~~~
> tui/tui-win.c:538:26: error: 'gdb_client_data' was not declared in this scope
>   538 | tui_async_resize_screen (gdb_client_data arg)
>       |                          ^~~~~~~~~~~~~~~
> tui/tui-win.c: In function 'void tui_initialize_win()':
> tui/tui-win.c:579:36: error: 'tui_async_resize_screen' was not declared in this scope
>   579 |     = create_async_signal_handler (tui_async_resize_screen, NULL,
>       |                                    ^~~~~~~~~~~~~~~~~~~~~~~
> tui/tui-win.c:579:7: error: 'create_async_signal_handler' was not declared in this scope; did you mean 'async_signal_handler'?
>   579 |     = create_async_signal_handler (tui_async_resize_screen, NULL,
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |       async_signal_handler
> gmake: *** [Makefile:1947: tui/tui-win.o] Error 1
> 
> To fix this we need to add #include "async-event.h" and this completes the build.
> 
> This patch does the same.
> ---
>  gdb/tui/tui-win.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c
> index 2f793e264e1..d3289d7edc1 100644
> --- a/gdb/tui/tui-win.c
> +++ b/gdb/tui/tui-win.c
> @@ -31,6 +31,7 @@
>  #include "cli/cli-style.h"
>  #include "ui-out.h"
>  #include "utils.h"
> +#include "async-event.h"
>  
>  #include "tui/tui.h"
>  #include "tui/tui-io.h"

Thanks for the report and patch.  See:

https://inbox.sourceware.org/gdb-patches/20240609141034.238889-1-simon.marchi@polymtl.ca/T/#u

I tested this series on the buildbot before sending it.  If we had an
AIX builder, this would have been caught.  Do you think it would be
possible for IBM to contribute an AIX builder to builder.sourceware.org?
I think it would be valuable for you, as you would have to chase less
regressions on AIX, they would be caught earlier.

Simon