From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by sourceware.org (Postfix) with ESMTPS id 704DA3858D34 for ; Wed, 21 Feb 2024 15:03:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 704DA3858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 704DA3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708527829; cv=none; b=FOLFlAkk87KwcvF+r/Z9lDIn+un2eoogReuDeWSrnf1g838iW4XHD63ejheTIDU3GUy/+FgbCVf005b3Za0b6zhh9VnCEGXpnbcD/cvRHwQUNJ9k9gi7ghc2PeuswtFRW3cR9SfZmPmSpSjC6+aKit/UrsitVs9jsqMD9oWrE5M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708527829; c=relaxed/simple; bh=rSEKTlKRqeTNm/1Zy78UqMi0MPQe3JCydmaYnmkS48E=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=mFuXv5jyoLU0p2pDRsWK9OY6YjqFyyLaBUUjVGVGHLuc8hwWyfNO+uuymNGl/KLLO0m2Nr2WjclRS7HO1jO7PRQIca1CtgBOlyvY7psUCRr3IeCcivg0ctYMQ8o717ekTLCBRm++4m8mlxhSO6cXRdZKIP/p+lseP+JiWz1+Vyc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-33d26da3e15so2932582f8f.1 for ; Wed, 21 Feb 2024 07:03:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708527824; x=1709132624; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dBnWY6ySDD/0j5cS4/CkFr34ggZGoMNzGwYeK3sHmCo=; b=k1DAfo7I4SWkn1UZsrjErkIeuridxwlD5aq7jozQrcEuN/4izdWX1dLISEOYxrj2Zh rLHJPZeZ3juaO/p+NkYwQfyetFK0HAsbcHIunVpsp089rkNYij5oXJwFUKV9YtU5nf+c 63t7VGWayZ3oK8YTvErmjhfNO709cT136Z5W4QCo5/M8yHCgCrNiUL9JMANV0LbdjndV nJIZLhXvtKEguofQ21AYaSVx5xqYadZZehEU11UDvTyxobrOt37DUOsktNngCVJtkeWc yk84c62XKiVXW+JWNbzfnBR7w6thiNZX3hZitTKv8ALSA05KcJ1HROzHyCh0+VGAwjw6 2Q/A== X-Forwarded-Encrypted: i=1; AJvYcCWEWWon+oQNGdTzmNaU7zGFEFptb/wa3aDn2nFxIMhXimd5FrXDjadC44/o8PlQ6eTqCHqB/oxhf3sKbfGSHIWOtU9MKHu1Wi2/bA== X-Gm-Message-State: AOJu0YzH0YeyxSYELw+wlg0+7Xl3L4m54lSo3i74yf8NkbJjqDPep096 Khpyef3z4V8ryizc+tu3wVV+Rmk+cGLb31iwP13hqmykmpBSkzVIP4WsqylkbJs= X-Google-Smtp-Source: AGHT+IE+Y0WM0XB7A6O6pCMi+W4Vq6NtU0Y09Th/A5xEjLTXBig97vF9rTyhC9zXhtE20w7tVBcV+w== X-Received: by 2002:a5d:67ce:0:b0:33d:3f23:eea7 with SMTP id n14-20020a5d67ce000000b0033d3f23eea7mr8039451wrw.35.1708527823899; Wed, 21 Feb 2024 07:03:43 -0800 (PST) Received: from ?IPV6:2001:8a0:f918:ab00:e0e8:3620:43e9:e37a? ([2001:8a0:f918:ab00:e0e8:3620:43e9:e37a]) by smtp.gmail.com with ESMTPSA id v4-20020a5d6784000000b0033d39626c27sm12758062wru.76.2024.02.21.07.03.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 07:03:43 -0800 (PST) Message-ID: <376e43c3-80b2-4824-87e7-d8564dbb74aa@palves.net> Date: Wed, 21 Feb 2024 15:03:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb: remove some GCC version checks To: Simon Marchi , gdb-patches@sourceware.org References: <20240221021939.5213-1-simon.marchi@efficios.com> Content-Language: en-US From: Pedro Alves In-Reply-To: <20240221021939.5213-1-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-02-21 02:19, Simon Marchi wrote: > > diff --git a/gdb/nat/x86-gcc-cpuid.h b/gdb/nat/x86-gcc-cpuid.h > index dfd12587d813..b2eda44a2294 100644 > --- a/gdb/nat/x86-gcc-cpuid.h > +++ b/gdb/nat/x86-gcc-cpuid.h > @@ -195,7 +195,6 @@ __get_cpuid_max (unsigned int __ext, unsigned int *__sig) > > #ifndef __x86_64__ > /* See if we can use cpuid. On AMD64 we always can. */ > -#if __GNUC__ >= 3 > __asm__ ("pushf{l|d}\n\t" > "pushf{l|d}\n\t" > "pop{l}\t%0\n\t" > @@ -208,22 +207,6 @@ __get_cpuid_max (unsigned int __ext, unsigned int *__sig) > "popf{l|d}\n\t" > : "=&r" (__eax), "=&r" (__ebx) > : "i" (0x00200000)); > -#else > -/* Host GCCs older than 3.0 weren't supporting Intel asm syntax > - nor alternatives in i386 code. */ > - __asm__ ("pushfl\n\t" > - "pushfl\n\t" > - "popl\t%0\n\t" > - "movl\t%0, %1\n\t" > - "xorl\t%2, %0\n\t" > - "pushl\t%0\n\t" > - "popfl\n\t" > - "pushfl\n\t" > - "popl\t%0\n\t" > - "popfl\n\t" > - : "=&r" (__eax), "=&r" (__ebx) > - : "i" (0x00200000)); > -#endif > > if (!((__eax ^ __ebx) & 0x00200000)) > return 0; It would be better IMO to avoid local changes to this file, especially if they're not really needed: /* * Helper cpuid.h file copied from gcc-6.0.0. Code in gdb should not ^^^^^^^^^^^^^^^^^^^^^ * include this directly, but pull in x86-cpuid.h and use that func. */ At some point, someone may want to pull a newer version from GCC, and local changes just make that a little more difficult. > diff --git a/gdbserver/tracepoint.h b/gdbserver/tracepoint.h > index 8b232324d2ec..6369e91aa276 100644 > --- a/gdbserver/tracepoint.h > +++ b/gdbserver/tracepoint.h > @@ -38,11 +38,7 @@ void initialize_tracepoint (void); > #if defined _WIN32 || defined __CYGWIN__ > # define EXPORTED_SYMBOL __declspec (dllexport) > #else > -# if __GNUC__ >= 4 > # define EXPORTED_SYMBOL __attribute__ ((visibility ("default"))) That "# define" line should be "reindented". > -# else > -# define EXPORTED_SYMBOL > -# endif > #endif