From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 0B59F385840A for ; Thu, 13 Apr 2023 15:05:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B59F385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3506021874; Thu, 13 Apr 2023 15:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681398335; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w/Bwr/RjItmRyMUt5+DoVAMFGYftdMzYaBq6MvzuSnE=; b=uSEmRABM1rvV8mnRglH6PlxA7A84FiDWo/Y0Gjk1rgjzGVd4eYLz2ZdaOsdnUEJqIxxO/R 2As1ItXdm6D1FyNKIrmMswG/Nv+7EPX4S5GQplMtENtrijidOmd0nhve7q73R5sxS6NH14 NrlG0lJaDVya/K8gmGblCQxxzpvqTto= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681398335; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w/Bwr/RjItmRyMUt5+DoVAMFGYftdMzYaBq6MvzuSnE=; b=xKe7mGqx+hs2j8yh0hR83CZRkG6WqlLoQaCBcermen8T6WBA4ezMz+3u73clqI4XIU/60m j3SaFaxL9qIgyrDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D23D1390E; Thu, 13 Apr 2023 15:05:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qYXyBT8aOGTbTgAAMHmgww (envelope-from ); Thu, 13 Apr 2023 15:05:35 +0000 Message-ID: <38190aa5-36f5-8b7b-0a2f-f7cfa03da574@suse.de> Date: Thu, 13 Apr 2023 17:05:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 2/3] [gdb/tui] Fix left margin in disassembly window Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org Cc: Tom Tromey References: <20230411082332.25052-1-tdevries@suse.de> <20230411082332.25052-2-tdevries@suse.de> <87leiwak03.fsf@redhat.com> <8de9c7c9-5d88-0923-403d-c291a8d64340@suse.de> <87ile09mdg.fsf@redhat.com> <87edoo9ls2.fsf@redhat.com> From: Tom de Vries In-Reply-To: <87edoo9ls2.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/13/23 11:25, Andrew Burgess wrote: > Andrew Burgess writes: > >> Tom de Vries writes: >> >>> On 4/12/23 23:06, Andrew Burgess wrote: >>>> I'm surprised there's no new test for this. I kind of assumed the new >>>> maint command (from patch #1) was to make writing the test easier... >>>> >>> >>> It certainly could be used for that, yes. My primary purpose though was >>> to make the problem easily visible. >>> >>> I haven't added a test because I'm still fixing issues I find with the >>> current testsuite... >>> >>> I might add a test-case for this eventually, or hijack one of the >>> existing tests. >> >> I don't understand -- aren't you proposing this patch for inclusion now? >> >> Patches should be accompanied by a corresponding test. >> >> I really think this should have a test before it's merged. > > Oh, I just noticed you merged this anyway. > > GDB development is usually done by consensus. That would mean if > someone raises a concern -- like a test is missing -- then you don't > merge a patch until the concern has been discussed and addressed. > > I've had plenty of patches on the list that have had an approval, and > then a concern raised by someone else. I don't just choose to see the > approval and merge the patch regardless -- that's just disrespectful to > a pretty legitimate concern I had about this patch. > Hi Andrew, I understand that the sequence of events can be read as such, but I went ahead and committed after seeing the approval by Tom, without seeing your reply, sorry about that. I only saw it when replying to Eli. > I know writing tests can be a real drag, but it really is critical to > making GDB a solid product. > I agree. And I don't consider it a drag, it's just that I felt a bit overwhelmed with other work (that also tries to make GDB a solid product). > Hopefully you can prioritise getting a test written for this patch. Yes, now that this ( https://sourceware.org/pipermail/gdb-patches/2023-April/198848.html ) is out of the door, I'll take a look. Thanks, - Tom