From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>,
Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Define GNULIB_NAMESPACE in unittests/string_view-selftests.c
Date: Fri, 04 May 2018 17:11:00 -0000 [thread overview]
Message-ID: <38335bd5-7e46-23e2-a45b-da970a1b8680@redhat.com> (raw)
In-Reply-To: <20180504165552.f4y7zcxzmgvwngel@adacore.com>
On 05/04/2018 05:55 PM, Joel Brobecker wrote:
> What worries me is that I don't see what's preventing us from hitting
> that issue outside of the unittests code? We know we can adjust our
> own classes, but this problem occured with a system class, so we had
> no choice but to use GNULIB_NAMESPACE. I worry that the transition
> from no GNULIB_NAMESPACE to using GNULIB_NAMESPACE in a given unit
> will leave some C system calls that should normally be covered by
> gnulib silently now reverting to the system (buggy) version.
Note that this is what led me to work on the whole wild/full matching
for C++, the TAB improvements, etc. See:
https://sourceware.org/ml/gdb-patches/2017-06/msg00012.html
I haven't rebased/updated the cxx-gdb-namespace branch since, as
I assumed it prudent to wait some time after a gdb is released
with support for wildmatching. That has happened, so maybe we can
consider going through with wrapping all of gdb in a namespace?
Or is it still too soon?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-05-04 17:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 21:25 Simon Marchi
2018-05-04 16:55 ` Joel Brobecker
2018-05-04 16:59 ` Joel Brobecker
2018-05-04 17:11 ` Pedro Alves [this message]
2018-05-04 17:24 ` Joel Brobecker
2018-05-08 20:47 ` Simon Marchi
2018-05-08 21:22 ` Joel Brobecker
2018-05-09 13:50 ` Pedro Alves
2018-05-09 14:00 ` Joel Brobecker
2018-05-09 15:19 ` Simon Marchi
2018-05-04 17:14 ` Simon Marchi
2018-05-04 17:20 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38335bd5-7e46-23e2-a45b-da970a1b8680@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).