RE: [PATCH 2/2] PowerPC, Fix-test-gdb.base-store.exp

[Carl Love <cel@us.ibm.com>]

Andrew:

On Mon, 2023-10-16 at 15:36 +0100, Andrew Burgess wrote:
> Carl Love <cel@us.ibm.com> writes:
> 
> > GDB maintainers:
> > 
> > This is the second patch which fixes the 128-bit floating point
> > register mappings.
> >  

<snip>
 
> > +static struct value *
> > +rs6000_value_from_register (struct gdbarch *gdbarch, struct type
> > *type,
> > +			    int regnum, struct frame_id frame_id)
> > +{
> > +  int len = type->length ();
> > +  struct value *value = value::allocate (type);
> > +  frame_info_ptr frame;
> > +
> > +  /* We have an IEEE 128-bit float need to change regnum mapping
> > from
> > +     fpr to vsr.  */
> > +  regnum = ieee_128_float_regnum_adjust (gdbarch, type, regnum);
> > +
> > +  value->set_lval (lval_register);
> > +  frame = frame_find_by_id (frame_id);
> 
> You can move the declaration of frame to here:
> 
>   frame_info_ptr frame = frame_find_by_id (frame_id);

OK, fixed.


> 
> which is the preferred GDB style these days.
> 
> Reviewed-By: Andrew Burgess <aburgess@redhat.com>
> 
> Thanks,
> Andrew
>