From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90842 invoked by alias); 2 May 2016 17:07:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90789 invoked by uid 89); 2 May 2016 17:07:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=annotation, Hx-languages-length:1160, H*r:112 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 02 May 2016 17:06:58 +0000 Received: by simark.ca (Postfix, from userid 112) id 4919D1E864; Mon, 2 May 2016 13:06:56 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 5A1E31E82D; Mon, 2 May 2016 13:06:55 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 02 May 2016 17:07:00 -0000 From: Simon Marchi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Fix annota-input-while-running.exp remote check In-Reply-To: <570BE706.3090804@redhat.com> References: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> <1459912543-15328-2-git-send-email-simon.marchi@polymtl.ca> <570BE706.3090804@redhat.com> Message-ID: <3845e867da67b2cf8206f6633ceef923@simark.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.1.3 X-SW-Source: 2016-05/txt/msg00014.txt.bz2 On 2016-04-11 14:03, Pedro Alves wrote: > On 04/06/2016 04:15 AM, Simon Marchi wrote: >> The comment says that we can't use runto_main here becore it doesn't >> know how to handle annotation. Instead, the test puts a breakpoint at >> main and calls run by hand. Therefore, it can't work with stub >> targets, >> since they can't "run". The check should be then changed to check the >> use_gdb_stub variable instead of [is_remote target]. >> >> But as an alternative, we can just use runto_main and enable >> annotations >> after, since the "run to main" part is not really part of what we want >> to test. >> >> I also removed the "set test..." line that is unused. >> > > I probably copied this from one of the other annotation tests, like > annota1.exp. Some of those do want to do annotation tests > before "run" though. Right. >> gdb/testsuite/ChangeLog: >> >> * gdb.base/annota-input-while-running.exp: Don't check for >> [is_remote target]. Enable annotations after running to main. >> Remove unused "set test..." line. > > OK. I have pushed this one, since it's valid itself. Thanks.