From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id BB2073858C98 for ; Thu, 4 Apr 2024 16:12:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB2073858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB2073858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712247182; cv=none; b=DuSxeXt0qfiXculis0rpYpTLHbAvHjB+ipkHe3B7CUcxY6BcNAlicAloffOXiORVQC8g5AG2XQxFC9Gj42TwP2zA1Z8GLGLXzagMaDwqTqg/djja/9nFA/YUVSMbiJEnwfLtqY5kfIKf4AeyElPkheIevrV0nmCnxyyUoW8dbx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712247182; c=relaxed/simple; bh=MWbpW4RDvt76HANqrn6vMsnTiqpRTxxD6um3PZUx2og=; h=DKIM-Signature:Subject:To:From:Message-ID:Date:MIME-Version; b=oxROC6lSUVav0uki1pKsvlwHOy3NeUKK4uQJ/LGScppoixGAzHLz6X/43pL40GULW0A95NU/1EIbQ88Iphn218qZE0fICpQQCjum9BmNG0hNavwESzlvnT7hgdavoMcHFM4EKfz2SFGXfYziL7FNbtdeU/V6Af0IPnsnB4k5SBc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1e2232e30f4so10475155ad.2 for ; Thu, 04 Apr 2024 09:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712247178; x=1712851978; darn=sourceware.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=3Mg0A4AR/bQZRSztKS6vjtBNGRHEkvr2UZ0vV9osnbw=; b=ZZMhsN06Mdteziog35NQ7SkhliM7AvoD9cl5y4fSAmFfaFZdWE3wQwHacwdLDqaGo9 Xq2GERuqVaR8HI1rgHrYY/bvW3Kc47vNSwkKPy+mc1mfvfmIdAYTsNeA7k2Iayoim9IE qi3VpwsJvwjDlVX7yTcPOafS0fMlcEb3ANQKA2JOL/Y+2yLxPllloQxX/hCdh9SNZ5IS WrKHhWfdDEg4DQnXWfuqKA/vEbW6GctfAIjDcxSsqDcWxVxYZNzPa46xITccf54wA4eM XcXQITB9TNLDHlxAclc4aYYdA+Ic1dOah41bZrqH2nj7rRyAbjsOImkGLcmwaPLAAQJA Whcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712247178; x=1712851978; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3Mg0A4AR/bQZRSztKS6vjtBNGRHEkvr2UZ0vV9osnbw=; b=vC7PG64IKHgneSTJMsWqhOSV5Bg1VaU42K9hGaoNnePPgpVJJYarHSxWxdAkgYcqbY DdLNOv6eeuhkgRJaJYNRVtO9i5/quW64TFzeZkNWpEtKF90i2yTWvk5CZphzcdkNiJox voUsIL71ESl4Bi542ATwhFxTNf3kcpatqGaGfoFiUh4YvQqWfUjsdIxUi/gbfUCJkoq0 G846qhPfQoyBnbpfM2s1jjs+SrHOWsnQkCoWWcjbkWeFxQeB7WnV1A9W+e6gR8Ez5CXE 4KP6TZwSuKjwygq6sJ9zyjDLtvgc2ZWiHLZgh2YCCezTvammIuDeDI7zn+E1C6UiAxsc fu/Q== X-Forwarded-Encrypted: i=1; AJvYcCUbTHjGZbXNYcVRyIZLC8aprlbtrZ+bcF9+uaqpnCz0zzUNGC70PYvRvxoFyFcVDSLPn7n3WnKk0S19ihzUTwqSsFLekuc/lMO2Yg== X-Gm-Message-State: AOJu0YzEC0zBuI4Z6Hx/DV8hoaPh5XClcs5192mbOpZuwU6cPDGuub/d 47k4RvAmBoPFHLILDuqGfcLHLlKQAK/supp8RXls5Q1elgQDn3z5s4hZrLKNG88= X-Google-Smtp-Source: AGHT+IG1uPSLPbQ6DNzbdFq40qNl988x5Jdzaex+FSSbaBphr//DoaSS6mEq27LOZ21hBVL4irHWTg== X-Received: by 2002:a17:902:cec4:b0:1e2:a325:4ca5 with SMTP id d4-20020a170902cec400b001e2a3254ca5mr3271788plg.29.1712247178058; Thu, 04 Apr 2024 09:12:58 -0700 (PDT) Received: from ?IPv6:2804:7f0:b402:d0dc:4f31:e30e:9a7a:2717? ([2804:7f0:b402:d0dc:4f31:e30e:9a7a:2717]) by smtp.gmail.com with ESMTPSA id p16-20020a170902e75000b001dd7a97a266sm15613469plf.282.2024.04.04.09.12.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 09:12:57 -0700 (PDT) Subject: Re: [PATCH v3 5/7] gdb: Introduce is_address_tagged target hook To: Luis Machado , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20240404064819.2848899-1-gustavo.romero@linaro.org> <20240404064819.2848899-6-gustavo.romero@linaro.org> From: Gustavo Romero Message-ID: <38508341-c27b-7623-790b-c00fabdc8d84@linaro.org> Date: Thu, 4 Apr 2024 13:12:54 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Luis, On 4/4/24 12:45 PM, Luis Machado wrote: > On 4/4/24 07:48, Gustavo Romero wrote: >> This commit introduces a new target hook, target_is_address_tagged, >> which is used instead of the gdbarch_tagged_address_p gdbarch hook in >> the upper layer (printcmd.c). >> >> This change allows the memory tagging address checking to be specialized >> easily per target in the future. Since target_is_address_tagged >> continues to use the gdbarch_tagged_address_p hook there is no change >> in behavior for the targets using the new target hook (the remote.c, >> aarch64-linux-nat.c, and corelow.c targets). > > The above block... > >> >> This change enables easy specialization of memory tagging address >> check per target in the future. As target_is_address_tagged continues >> to utilize the gdbarch_tagged_address_p hook, there is no change in >> behavior for all the targets that use the new target hook (i.e., the >> remote.c, aarch64-linux-nat.c, and corelow.c targets). > > ... seems to be somewhat duplicated above in the commit message. Right, it's duplicated. I'll drop the first block in v4. Thanks. > Also, as general rule, we usually make updates clear at the top of the > commit message. for instace: > > Updates in v3: > > - Something something. > - Fixed breakage. > > And then those update blocks don't get pushed when the series is > approved (sometimes some do push it). hmm, k, I'll put the updates at the top next, however I put them always in the cover letter and never in the commit messages. Are you recommending putting them per commit?" Cheers, Gustavo