From: Pedro Alves <palves@redhat.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>,
Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] GDB test suite: Add helper for locating core files
Date: Tue, 17 Oct 2017 09:22:00 -0000 [thread overview]
Message-ID: <3857f72c-17ca-b4d9-85c9-f2ef602c5d54@redhat.com> (raw)
In-Reply-To: <7c57a718-2986-c089-6fbf-2e352e8cf9d4@redhat.com>
On 10/12/2017 05:47 PM, Pedro Alves wrote:
> On 10/12/2017 02:47 PM, Pedro Alves wrote:
>> On 10/09/2017 07:46 PM, Andreas Arnez wrote:
>>
>>> @@ -5883,7 +5883,7 @@ proc run_and_get_core {binfile {arg ""}} {
>>> # specified. Return that path name, or "" if no core file was found.
>>>
>>> proc find_core {binfile coredir {destcore ""}} {
>>> - if {[is_remote target]} {
>>> + if {![isnative]} {
>>> warning "Can not access remote core file."
>>> return ""
>>> }
>>
>> This seems incorrect to me. "isnative" only checks
>> if the build and target _triplets_ are the same. So
>> foo-linux-gnu gdb x foo-linux-gnu gdbserver on separate
>> machine still returns isnative==true.
>>
>> I think the real problem is that the native-gdbserver board
>> returns true to is_remote, when I think it shouldn't.
>>
>> Doing that alone results in fallout in the testsuite, of
>> course. I'm seeing if fixing it is doable.
>
> It's doable. Below's what I have. This exposed a number of
> tests that were skipped for stale reasons.
>
> The new "set cwd" command helps with this, which is nice
> in the "I love it when a plan comes together" sense. :-)
>
> I should probably split this up and submit in pieces.
FYI, this is now fully done and all pushed to master.
The native-gdbserver board no longer returns true
to [is_remote target].
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-10-17 9:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 18:42 [PATCH 0/2] GDB test suite: Support targets with systemd-coredump Andreas Arnez
2017-09-18 18:43 ` [PATCH 1/2] GDB test suite: Add helper for locating core files Andreas Arnez
2017-10-07 16:45 ` Kevin Buettner
2017-10-09 18:46 ` Andreas Arnez
2017-10-11 8:17 ` Kevin Buettner
2017-10-11 14:53 ` Andreas Arnez
2017-10-12 13:47 ` Pedro Alves
2017-10-12 16:48 ` Pedro Alves
2017-10-17 9:22 ` Pedro Alves [this message]
2017-10-12 17:00 ` Andreas Arnez
2017-10-13 9:28 ` Maciej W. Rozycki
2017-10-13 10:56 ` Andreas Arnez
2017-10-17 13:58 ` Maciej W. Rozycki
2017-10-17 10:06 ` Pedro Alves
2017-10-17 10:01 ` Pedro Alves
2017-10-17 18:21 ` Maciej W. Rozycki
2017-10-18 11:46 ` Pedro Alves
2017-09-18 18:44 ` [PATCH 2/2] GDB test suite: Get core files on targets with systemd-coredump Andreas Arnez
2017-10-17 10:22 ` Pedro Alves
2017-10-17 17:37 ` Andreas Arnez
2017-10-17 18:09 ` Pedro Alves
2017-10-17 18:14 ` Pedro Alves
2017-10-17 18:17 ` Pedro Alves
2017-10-18 15:56 ` Andreas Arnez
2017-10-19 10:48 ` Pedro Alves
2017-10-23 13:41 ` Andreas Arnez
2017-10-23 14:30 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3857f72c-17ca-b4d9-85c9-f2ef602c5d54@redhat.com \
--to=palves@redhat.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).