From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 467803857351 for ; Fri, 21 Apr 2023 15:21:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 467803857351 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 774851FDE4; Fri, 21 Apr 2023 15:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682090506; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BU0lf/o5kdHo7MFLaTxVred+jbEG7I4xcW1naKOayg8=; b=r0NLtZVsA8u2dCmUmb6IlnB8NP0bdPg+QKgEUmtGYIBxYdUyvgW8vcnDPb+Q6daVxPORXM becDFZk9h+vxMfgwRf1XjvdOTny4T3i6mudDDFjbqD63lhzrt89AV9RsdTsEZisIJkB9BW iOCUrKDIbuRYOZHJBRjGvo5gO4Bkjr8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682090506; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BU0lf/o5kdHo7MFLaTxVred+jbEG7I4xcW1naKOayg8=; b=kGf8UcFnezN8JGPTbtTYKSDTxAkLoCeT14DQtj0b/TwlzmSe6bFXJhGKzFQTkX0wd5L97t Dtg/U5k1gko9lSAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 63BC31390E; Fri, 21 Apr 2023 15:21:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7CpBFwqqQmQzGgAAMHmgww (envelope-from ); Fri, 21 Apr 2023 15:21:46 +0000 Message-ID: <3871cc3c-9108-06c2-d23a-f54d1adf12e6@suse.de> Date: Fri, 21 Apr 2023 17:21:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] [gdb/cli] Add maint info screen To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20230417140906.25341-1-tdevries@suse.de> <83edoia0kz.fsf@gnu.org> Content-Language: en-US From: Tom de Vries In-Reply-To: <83edoia0kz.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/17/23 19:19, Eli Zaretskii wrote: >> Date: Mon, 17 Apr 2023 16:09:06 +0200 >> From: Tom de Vries via Gdb-patches >> >> gdb/doc/gdb.texinfo | 7 +++++ >> gdb/utils.c | 70 +++++++++++++++++++++++++++++++++++++++++++-- >> 2 files changed, 75 insertions(+), 2 deletions(-) > > Thanks for working on this. > >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -41363,6 +41363,13 @@ This option is @samp{on} by default for supported architectures. >> This option is useful for debugging @value{GDBN}'s use of the Pygments >> library when @value{GDBN} is built for an architecture that supports >> styling with the builtin disassembler >> + >> +@kindex maint info screen >> +@cindex Show screen characteristics > ^^^^ > Please avoid capital letters in index entries as much as possible. > That's because differences in letter-case can cause the index entries > be sorted in different order depending on the locale where the manual > is built, and we want to avoid this locale dependency if possible. > Ack, done. >> +@item maint info screen >> +Print various characteristics of the screen, such as various notions >> +of width and height. > > Maybe say what will this be useful for? > I haven't managed to come up with something meaningful here, so I've left it as is. I'm open to further suggestions, but I've committed to be able to use it in test-cases. > Reviewed-By: Eli Zaretskii Thanks for the review. - Tom