From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 39D5238582A1 for ; Wed, 14 Feb 2024 15:52:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 39D5238582A1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 39D5238582A1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707925969; cv=none; b=T9viEdevmEh9Rf+vNXx1uUsyrrVm5upXyahj87lNWc87aU6Kd+NkMnkUqY14tbBiaZiCjsSDptuoS935yl62kXJzB/UEmcQNT7GYwk0+XXsdV8+oyHByQOgwjOr1P6pZ+xC7BI2BUCYD7ohSRCgAeyqCB6d61v4zIJwWFqsggMo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707925969; c=relaxed/simple; bh=aRx0/U6BfOfF9Vm97+bH/zd+gRRyRxyO0dgHQSKg3hA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=iqXtiXr/2mfsoqMIeZcmLXjFO4jhTSb4D7VousWhDaR5EDd10si0Wz2DOS1fhg+e9xgxPnOnI2Ir49XjO+77l/syARGMGxj/rNShwdkFgkshpVYXWDAkqGrx4uKdC0ypDUBJJKXLLeIPVnU5HIG/qdjDUQuhKaNYVT0aPm8djc4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 319D621CD5; Wed, 14 Feb 2024 15:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707925966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A33FV34cZ3lFBaPv8EtgbRkO3mYHdWXDFWRMTNMm4Ck=; b=hcj+6JKev+1xpxOHj5UQsr+lwKlcGAFpE+igYbnk24Crgu1zMFPDU1310wuTDwWFoOxgE0 HAohssv6mAKu+b8z3zPvYVnNzZKe9vubgNoS+FY4ZtEUbALx8gjXHI3KSnxaHXiF7BiOdD +ITM/QmNuQfUQjSPaevPFktoDZR9y7M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707925966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A33FV34cZ3lFBaPv8EtgbRkO3mYHdWXDFWRMTNMm4Ck=; b=KgoL0barCgy1HQYKJxRvDhjKarcJyOvAN3Z+vliJDNlB47JNugXK7D5z6y7qOpYF2Yhhlv toJXJpYqardb1MCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707925966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A33FV34cZ3lFBaPv8EtgbRkO3mYHdWXDFWRMTNMm4Ck=; b=hcj+6JKev+1xpxOHj5UQsr+lwKlcGAFpE+igYbnk24Crgu1zMFPDU1310wuTDwWFoOxgE0 HAohssv6mAKu+b8z3zPvYVnNzZKe9vubgNoS+FY4ZtEUbALx8gjXHI3KSnxaHXiF7BiOdD +ITM/QmNuQfUQjSPaevPFktoDZR9y7M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707925966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A33FV34cZ3lFBaPv8EtgbRkO3mYHdWXDFWRMTNMm4Ck=; b=KgoL0barCgy1HQYKJxRvDhjKarcJyOvAN3Z+vliJDNlB47JNugXK7D5z6y7qOpYF2Yhhlv toJXJpYqardb1MCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 19CBB13A6D; Wed, 14 Feb 2024 15:52:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yUbUBM7hzGURLgAAD6G6ig (envelope-from ); Wed, 14 Feb 2024 15:52:46 +0000 Message-ID: <38759c3f-9a03-4468-9ddc-aa5ebb983074@suse.de> Date: Wed, 14 Feb 2024 16:53:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/3] [gdb/dap] Fix exit race Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240207090224.27521-1-tdevries@suse.de> <20240207090224.27521-2-tdevries@suse.de> <875xz0clgw.fsf@tromey.com> <0abb6b1d-52ce-43c5-ac49-fa98ad06a810@suse.de> <87il2s5jho.fsf@tromey.com> <8ac3e1d0-7a93-44f0-9568-49d01fe58f9f@suse.de> <87sf1v3vrl.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87sf1v3vrl.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hcj+6JKe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KgoL0bar X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.88 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-0.88)[85.78%]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_IN_DNSWL_HI(-0.50)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: -3.88 X-Rspamd-Queue-Id: 319D621CD5 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/14/24 16:34, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Anyway, I've now filed a separate PR for this issue, which I hope > Tom> makes the discussion a bit clearer, so we have: > Tom> - a PR for the assertion failure (PR31306) > Tom> - a PR for ensuring responses are flushed to client before exiting > Tom> (PR31380) > > Ok. FWIW I think the Queue idea seems totally fine, and combining these > patches seems natural to me. Sorry for going on this topic, but I'd like to understand why you think this. From my point of view, it's not a good idea to combine the patches because the PRs have distinct root causes, which makes the discussion about fixing them together confusing. So, it's not that I _want_ to do this, it's that I'm convinced by the evidence I've seen that this is the natural and obvious thing to do. Which might mean I'm misunderstanding or overlooking something. I start to wonder if perhaps you're thinking of a different race, which is actually not discussed in the two PRs. Thanks, - Tom