public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Sam James <sam@gentoo.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: Nick Clifton <nickc@redhat.com>, Andreas Schwab <schwab@suse.de>,
	Binutils <binutils@sourceware.org>,
	Nick Clifton via Gdb-patches <gdb-patches@sourceware.org>,
	Tzvetelin Katchov <katchov@gnu.org>
Subject: Re: RFC: Sort tarballs created by the src-release.sh script
Date: Mon, 3 Oct 2022 07:59:04 +0100	[thread overview]
Message-ID: <38F08F3E-EFA6-4ABA-9CEE-60306E872C25@gentoo.org> (raw)
In-Reply-To: <a88544d2-3e3f-c7aa-547e-56190efb96dc@suse.com>



> On 3 Oct 2022, at 07:56, Jan Beulich <jbeulich@suse.com> wrote:
> 
> On 02.10.2022 09:54, Sam James wrote:
>> 
>> 
>>>> On 30 Sep 2022, at 12:38, Nick Clifton via Binutils <binutils@sourceware.org> wrote:
>>> 
>>> Hi Guys,
>>> 
>>> Right, here is the latest and greatest - and hopefully last - version
>>> of the patch.  I added a parseable string to the --mtime option and a
>>> comment explaining why these options are being used.
>>> 
>>> Any more comments/suggestions ?
>>> 
>>> Cheers
>>> Nick
>>> 
>>> diff --git a/src-release.sh b/src-release.sh
>>> index 079b545ae7c..8a2ac125030 100755
>>> --- a/src-release.sh
>>> +++ b/src-release.sh
>>> @@ -184,9 +184,11 @@ do_tar()
>>>    ver=$2
>>>    echo "==> Making $package-$ver.tar"
>>>    rm -f $package-$ver.tar
>>> +    # The sort command and --mtime, --group and --owner options are
>>> +    # used in order to create consistent, reproducible tarballs.
>>>    find $package-$ver -follow \( $CVS_NAMES \) -prune \
>>> -       -o -type f -print \
>>> -       | tar cTfh - $package-$ver.tar
>>> +       -o -type f -print | LC_ALL=C sort \
>>> +       | tar cTfh - $package-$ver.tar --mtime="1970-01-01 00:00:00" --group=0 --owner=0
>>> }
>>> 
>>> # Compress the output with bzip2
>>> 
>> 
>> I think this might hit a problem I faced when trying to do this with Go tarballs: https://www.gnu.org/software/tar/manual/tar.html#warnings.
>> 
>> With that date, I got "implausibly old time stamp" warnings from tar. I haven't tested this patchthough (writing from mobile, apologies).
>> 
>> Maybe default to the creation date of Binutils and allow overriding via https://reproducible-builds.org/docs/source-date-epoch/?
> 
> Not sure what "creation date" might mean here.

I meant whatever date folks consider to have been the creation of the Binutils project. First commit, announcement, first release, whatever.

Not that it really matters, it just can't be the unix epoch.

  reply	other threads:[~2022-10-03  6:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 12:59 Nick Clifton
2022-09-28 13:05 ` Andreas Schwab
2022-09-28 13:34   ` Nick Clifton
2022-09-29 12:24     ` Nick Clifton
2022-09-29 12:36       ` Jan Beulich
2022-09-30 11:38         ` Nick Clifton
2022-10-02  7:54           ` Sam James
2022-10-02  7:54             ` Sam James
2022-10-03  6:55             ` Jan Beulich
2022-10-03  6:59               ` Sam James [this message]
2022-10-03  7:41                 ` Andreas Schwab
2022-10-03 14:40               ` Nick Clifton
2022-10-03 19:56                 ` Andreas Schwab
2022-10-04  7:10                 ` Jan Beulich
2022-10-05 12:23                   ` Nick Clifton
2022-10-05 13:00                     ` Jan Beulich
2022-10-03  7:47             ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38F08F3E-EFA6-4ABA-9CEE-60306E872C25@gentoo.org \
    --to=sam@gentoo.org \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jbeulich@suse.com \
    --cc=katchov@gnu.org \
    --cc=nickc@redhat.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).