From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id B9A593840C3D for ; Thu, 11 Jun 2020 10:34:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B9A593840C3D Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-73-AbDIWZELPxWJ1d-LHE98Kw-1; Thu, 11 Jun 2020 06:34:40 -0400 X-MC-Unique: AbDIWZELPxWJ1d-LHE98Kw-1 Received: by mail-wm1-f72.google.com with SMTP id b63so2779834wme.1 for ; Thu, 11 Jun 2020 03:34:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bWaXv6Nsc8RMpk6L6aataI08mtq1542pPbXS4y9mAWQ=; b=KYdy2+/fm/JfiOeQY0S49fR+FpmOKDlKy6N39vLkLWeXO+AlFWNhrzLULOdoj1n4iK BwdUn1dYPK+NvT9S27MMPYXiKHZEwp44Iucely58nf2Yl+NuCmmJ/jqfs36yAnaIeVa7 yJW/8UdcVy0VCRr81dEk87EL91OwZB87/kK88MWCWq3fuR3Eo/3rzfqTB1OHxkZ3neFb iUkV57MgrvlIMZZEt7/MzVlACmF7SetEACv/rrsV5d013+zeyEZrftbMtYD8EX6rG4Ys ullf62s9wa9uHsrC8kvpLLTNHcI3lCNAG7ObCxni5HlQWZlmUCcZ6zP0JoQoDjXASm6G OVFA== X-Gm-Message-State: AOAM530EdH75lSIXkxkUGeB4aFucAwA0gprVAYgnC55k8Q77vNntLeOX ugiF1D3XyjXaDO87aQVXPxllw8dDuwbD3ENviw3YC7wfCp2qLabAhPd1POyAZzHIAuCUFfwmD25 BJ8WMcgd8xymJAd/k3nnZlQ== X-Received: by 2002:a1c:6389:: with SMTP id x131mr7435740wmb.90.1591871678831; Thu, 11 Jun 2020 03:34:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdnm82iCPrsYzZ5NQ9GhvRc+vIt60ha3wmfoqWAZDusywl1VuvBBQZk57UNulg88BxoxvBtA== X-Received: by 2002:a1c:6389:: with SMTP id x131mr7435728wmb.90.1591871678562; Thu, 11 Jun 2020 03:34:38 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id q11sm4297348wrv.67.2020.06.11.03.34.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2020 03:34:37 -0700 (PDT) Subject: Re: TUI enhancement suggestion. To: Phi Debian References: Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <38b5d874-cdf2-50e7-dc76-aed3fee20334@redhat.com> Date: Thu, 11 Jun 2020 11:34:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2020 10:34:46 -0000 On 6/9/20 4:03 PM, Phi Debian via Gdb-patches wrote: > Here is the patch I made, I spotted a little typo in a comment, I leave it > in there for now, and provide this as a demonstrator. > Cool, thanks. Patches should be sent against current master, because new features are not going to be merged to the gdb 9 branch, only bugfixes. > I never submitted a patch so I don't really know the best practice, I > cutted it on top of 9.2 (latest pull) then the patch) > I used > > $ git format-patch -1 HEAD > That's good. The best way to send a patch is to then use git send-email 0001-whatever.patch but attaching it as you've done is also OK. Take a look here: https://sourceware.org/gdb/wiki/ContributionChecklist We will need to clear the copyright assignment issue: https://sourceware.org/gdb/wiki/ContributionChecklist#FSF_copyright_Assignment in order to be able to accept your contribution. Let me know and I'll get your started. As for the patch itself, how about, instead of: set tui point-underline on|off we make it an enum command like: set tui current-line-highlight none|reverse|underline An enum like this leaves it open for other styles in the future. "none" could be to just display the ">" on the left side and nothing else, like currently still done on the assembly window. Also, I'm suggesting set tui current-line-highlight and not set tui current-source-line-highlight because it seems like a bug to me that the assembly window doesn't highlight the current instruction in the same fashion as the current source window highlight the current source line. In your screenshot, the underline only goes up until the "printf", instead of underlining the actual source code text in the line as well. That seems like a bug. What happens if you disable styling, with "set style enabled off"? Does that cause the whole text line to be underlined? Thanks, Pedro Alves