From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 94B183858401 for ; Wed, 3 Apr 2024 14:51:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 94B183858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 94B183858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712155889; cv=none; b=s0MGxDxso6zDBpPj0wZsf44Za4Pm7lgaH1cqAcBMhqt3Runff+MNFA4Fi39QEXIdfFkBd83i4Oqxme5JTnh4cFVBnVcYjRf26jF5HL50+eCnl6uqWbe7/KLG2VOjIPtHCyLsQ+fEyebjlO4a6dkeIjRvZ6lNO8hNmkluTAPPDFQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712155889; c=relaxed/simple; bh=OkBUkcoxA+LZy1r8gK/vrFC/fnrjvyY1wjC38E7dNEo=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=PQAjqko21DFEdGv4z9X/yQsjF6wWPJPjN85Gg3dedqiEXcti9QibtmHxe1UgI9gkRs1TfxoY8p2RUJNdaF+R0MR8eDiySrncVJPTLrbD1GkLU4Aj4poamuiHdkLV3RzKsBFAjzgQqI18YiN5AAInjcepcWkkycg4ramtzDXPxH8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6CBA55CDB7; Wed, 3 Apr 2024 14:51:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712155886; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Tnnf09aWJKGyFr31J8uxvfAo2x1V60jVdbyjzyY/ck=; b=f+MnChScgYB3NagRPNXEk49Z7ljIBHyqvKSrGxwgE1VBX/irkMeXcjzcAqLYY7UoCk86TC SwM17b+PvGuCPDXXzofkitPPAv7dgnffJtPT6zvpPJT7/5TC2tSJisKIkwZ6jgD9Do2hIB rH2d2AE4hyCWGnz+zqVmLRmFe/2W/+A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712155886; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Tnnf09aWJKGyFr31J8uxvfAo2x1V60jVdbyjzyY/ck=; b=jzq8ehsanxOplNZISpTwTbpehNfriibrvM/xKVs7umjwqZ2b/TmhNyecay84jWynPiyN2D dRVEIjUOtCttYiCw== Authentication-Results: smtp-out2.suse.de; dkim=none Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 4B62213357; Wed, 3 Apr 2024 14:51:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id veAwEe5sDWZ3aAAAn2gu4w (envelope-from ); Wed, 03 Apr 2024 14:51:26 +0000 Message-ID: <38c53217-76b5-4ec4-8235-3eb8ca021d2c@suse.de> Date: Wed, 3 Apr 2024 16:51:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/compile: Use std::filesystem::remove_all in cleanup Content-Language: en-US To: Lancelot SIX , Tom Tromey Cc: gdb-patches@sourceware.org, lsix@lancelotsix.com References: <20240303164756.870514-1-lancelot.six@amd.com> <8734t0sn8d.fsf@tromey.com> <6689da3c-9229-4338-9cad-b3bbeb1bbecf@amd.com> From: Tom de Vries In-Reply-To: <6689da3c-9229-4338-9cad-b3bbeb1bbecf@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.55 X-Spamd-Bar: / X-Spamd-Result: default: False [-0.55 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(2.20)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-0.95)[86.65%]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_IN_DNSWL_HI(-0.50)[2a07:de40:b281:104:10:150:64:98:from]; RCVD_TLS_ALL(0.00)[] X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 6CBA55CDB7 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/3/24 16:47, Lancelot SIX wrote: >> >> This broke the build for me with gcc 7.5.0, which apparently falls into >> the category of "mostly implements C++17 but not std::filesystem". >> > > Sorry about that, I have sent > https://sourceware.org/pipermail/gdb-patches/2024-April/207760.html to > revert that change.  At least, we know it is best to stay away from > std::filesystem for now. > I wonder if there is a case for conditionally enabling this. That would ensure that the work is not lost, as well as used when using gcc >=8. Thanks, - Tom