From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id DE9A03857835 for ; Fri, 6 Oct 2023 22:06:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE9A03857835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4S2MwM4pKTz3Sj1; Fri, 6 Oct 2023 22:06:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S2MwM3gc4z4GYX; Fri, 6 Oct 2023 22:06:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696630019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lNFmxMg7OUE0fslpKkPQfiVpeEUcX0dNfnf8wBGEZis=; b=SXppE6SXabP/HAKAaQy4KRPoXZ/fmnYxXfSykzeQI9vfjfzrG64JcGxyk8hXIbvSra4deA qiENoiHmhDpi93aFhVMK3RKUEpmI8f7xpbduLsfyAFI5runvaPuNXNlQI07Cs91e3fzqdI VNVjstIs1h9OdfYAWMFH1A1I0pQ9tik/uw/1ddQv/uLaH8Dk+DUOwhCIzRWK6er3Y8TWPm 0u8zi3ebe31pS9LKSWB4a8pnPzoB7y1F0AZOoQiKjvj5Dkkfs/fAtwbdOkOe3kEDUqxo4S a9bbKNvoZcwKw0JwD6TYQo31+Ht+O88y7l9jmuJAxVgI7yopEWR7lrAa9hSEGA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696630019; a=rsa-sha256; cv=none; b=cXGjFpdNbEHDKf5Zt2zJd2+ARqiHS6X/NMVrGfVokIuzMEi0pcUJZU/SlWLiUdozQ6ABD5 3hLBSsAcGUlk2LlEmHje52YKAyB9z6VAz8fBUhGWh/ZREzyzJhDRPffekCiRfQM/oKiRI+ lP9GpIcRm+m3Pgo+pjUqNQv5I106UaQDL6FTahgALLpzXxPERSISQz1hnpWxoVj6cEPc1Y WpQvX9abcJIF8U25N4SJ3gDIIsMVnKZrei6iQA3pNqbU8KtKq4e47EuvXy1vqNAmWmUMRY SGWfeh02sTTzPhDidhl2KL/z1SCsMIKovD3j1gQpvFlFQK+z07+DiojfICC62w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696630019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lNFmxMg7OUE0fslpKkPQfiVpeEUcX0dNfnf8wBGEZis=; b=EL8JxYrkFVJo7P0AfAurqZkTw9LXtw5zrau3f3WZnBvW1hVfuqnZ13JPiRHvns7LJcUwAT rmimepHXABde/hdlfq9PXs0t0eI2XsqViiaH7V59BIvLiz2c7mk3KSSiahOVzcSWmusCUP vng+D+Y7mnrgEThkyFew6RnWhO1oZmuDZbKsXqgtLkbbVVrDFRMD3/zgKL7Tg5KE7o5XNT sP5IquPeYKTLZ77B4Svt1krYkjXyvWUP2APmAH+zlpw/0X4PDjW+7iHxvjZk6lPN/rCi9U 359DJKNH85mlGs+qZdpCe5r8hcoXWxfRgnp0kDmYtsOEymYS6/A8B9kB+fLLWQ== Received: from [IPV6:2601:648:8683:39a0:355d:333f:e690:4130] (unknown [IPv6:2601:648:8683:39a0:355d:333f:e690:4130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4S2MwL43ylzyF; Fri, 6 Oct 2023 22:06:58 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <38ed3f1d-847e-dc56-18d2-b98309c0a4b1@FreeBSD.org> Date: Fri, 6 Oct 2023 15:06:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.arch/i386-signal.exp on x86_64 Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org Cc: Jan Beulich References: <20231001111450.2719-1-tdevries@suse.de> From: John Baldwin In-Reply-To: <20231001111450.2719-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/1/23 7:14 AM, Tom de Vries via Gdb-patches wrote: > On x86_64-linux, with test-case gdb.arch/i386-signal.exp I run into: > ... > builtin_spawn -ignore SIGHUP gcc -fno-stack-protector i386-signal.c \ > -fdiagnostics-color=never -fno-pie -g -no-pie -lm -o i386-signal^M > /tmp/cc2xydTG.s: Assembler messages:^M > /tmp/cc2xydTG.s:50: Error: operand size mismatch for `push'^M > compiler exited with status 1 > output is: > /tmp/cc2xydTG.s: Assembler messages:^M > /tmp/cc2xydTG.s:50: Error: operand size mismatch for `push'^M > > gdb compile failed, /tmp/cc2xydTG.s: Assembler messages: > /tmp/cc2xydTG.s:50: Error: operand size mismatch for `push' > UNTESTED: gdb.arch/i386-signal.exp: failed to compile > ... > > This is with gas 2.41, it compiles without problems with gas 2.40. Some more > strict checking was added in commit 5cc007751cd ("x86: further adjust > extend-to-32bit-address conditions"). > > The offending bit is: > ... > " push $sigframe\n" > ... > which refers to a function: > ... > " .globl sigframe\n" > "sigframe:\n" > ... > > The test-case passes with target board unix/-m32. > > Make the test-case work by using pushq instead of push for the > is_amd64_regs_target case. > > Tested on x86_64-linux, with target boards: > - unix/-m64 (is_amd64_regs_target == 1), and > - unix/-m32 (is_amd64_regs_target == 0), > > PR testsuite/30928 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30928 > --- > gdb/testsuite/gdb.arch/i386-signal.c | 4 ++++ > gdb/testsuite/gdb.arch/i386-signal.exp | 7 ++++++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.arch/i386-signal.c b/gdb/testsuite/gdb.arch/i386-signal.c > index 19bb1bbaaf8..4bf97e5f159 100644 > --- a/gdb/testsuite/gdb.arch/i386-signal.c > +++ b/gdb/testsuite/gdb.arch/i386-signal.c > @@ -45,7 +45,11 @@ asm(".text\n" > " .align 8\n" > " .globl setup\n" > "setup:\n" > +#if IS_AMD64_REGS_TARGET > + " pushq $sigframe\n" > +#else > " push $sigframe\n" > +#endif > " jmp func\n" > "\n" > " .cfi_startproc\n" > diff --git a/gdb/testsuite/gdb.arch/i386-signal.exp b/gdb/testsuite/gdb.arch/i386-signal.exp > index f6a88719a40..a69172ed5cb 100644 > --- a/gdb/testsuite/gdb.arch/i386-signal.exp > +++ b/gdb/testsuite/gdb.arch/i386-signal.exp > @@ -19,8 +19,13 @@ require {is_any_target "i?86-*-*" "x86_64-*-*"} > > standard_testfile > > +set opts {} > +lappend opts debug > +lappend opts nopie > +lappend opts additional_flags=-DIS_AMD64_REGS_TARGET=[is_amd64_regs_target] > + > if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ > - executable { debug nopie }] != "" } { > + executable $opts] != "" } { > untested "failed to compile" > return -1 > } > > base-commit: 23b5268986d9b68b965939416a7aa96e8698e403 LGRM -- John Baldwin