Re: [PATCH] Replace SYMBOL_SET_LINKAGE_NAME with a member function

[Simon Marchi <simark@simark.ca>]

On 2019-11-26 3:43 p.m., Christian Biesinger via gdb-patches wrote:
> Easier to read, shorter, and will later make it possible to make the
> name field private.

Thanks, LGTM, with the nits below fixed.

> diff --git a/gdb/stabsread.c b/gdb/stabsread.c
> index 6ec9f971e1..3f3f0a624f 100644
> --- a/gdb/stabsread.c
> +++ b/gdb/stabsread.c
> @@ -399,8 +399,7 @@ patch_block_stabs (struct pending *symbols, struct pending_stabs *stabs,
>        /* for all the stab entries, find their corresponding symbols and 
>           patch their types!  */
>  
> -      for (ii = 0; ii < stabs->count; ++ii)
> -	{
> +      for (ii = 0; ii < stabs->count; ++ii) {

Unrelated change.

> diff --git a/gdb/symtab.h b/gdb/symtab.h
> index 897ffda76e..ff51069b6c 100644
> --- a/gdb/symtab.h
> +++ b/gdb/symtab.h
> @@ -407,8 +407,7 @@ struct general_symbol_info
>  
>    /* Return the demangled name for a symbol based on the language for
>       that symbol.  If no demangled name exists, return NULL.  */
> -  const char *demangled_name () const;
> -
> +  const char *demangled_name () const; 

Unrelated change.

Simon