From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BF1193858D20 for ; Wed, 17 Apr 2024 14:52:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF1193858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF1193858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713365555; cv=none; b=pRqDylOF/ZT2vsN6jwmNU67iYw2I2+mu4XiD3JF2cnrA1HnGW38Iv9TXMpcO4zTrn06KZsgzehCpxBSYWJzvLfw53bz8U1/fBng9FFWf77PXpiAfQxvnLIruoVOkgXRyS691xwIFrEEs+zO574i5EvibRCiIbo6crI4fevNExCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713365555; c=relaxed/simple; bh=0AQyaqoFrPnVEWx6uUoXdpf1D38tCu/Q9yZaQL+Zcv0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=coRKCttaSN0yKlzAeGY2Dv1O3iQD4LfIs3I1xBRtgk6Y0XYs08D6Qocg7CK/iob8z2CEawEtKWqbcZHzu0yoemnlTA55HkJyoX7nj4ygTRUfTbNG20DsX3y0rFXWmNfgiFRDqePt05Ir1JoQyWp2PhOgUEjIsuFZWBKsz9lN6qE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1713365553; bh=0AQyaqoFrPnVEWx6uUoXdpf1D38tCu/Q9yZaQL+Zcv0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EO6c1EhPgXyy3bWDwMYV7fcNIXmvmujmQfAlGgiAWZitk1CkST8NsMqDy9KrdvZK5 c5NecvuiMw3yZzlGxxiZvU2MORqSo1XPr/SAT8G2fuEYmxSPqCZ2y/F2oxope95Zf8 BDvLbjEP3EFRQzUDBHzoDk0C3QatAIbUjGBEPxgk= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 09BD11E092; Wed, 17 Apr 2024 10:52:32 -0400 (EDT) Message-ID: <39009b0a-8a19-42a5-a0bc-afe1290d15aa@simark.ca> Date: Wed, 17 Apr 2024 10:52:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdbsupport, gdbserver, gdb: use -Wno-vla-cxx-extension To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20240412175200.829114-1-simon.marchi@efficios.com> <87cyqq38b4.fsf@tromey.com> <8734rkhq6j.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <8734rkhq6j.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-16 18:56, Tom Tromey wrote: > Simon> Here's the list of those I see in my build (x86-64 Linux all targets): > > Simon> I think we should have a vector type with "small vector optimization", > Simon> it would be great to replace these uses of VLAs. I might give it a shot > Simon> at some point (or maybe someone else wants to try?). But until then, I > Simon> think it makes sense to silence the warning. > > I suppose I'm ok with that. Ok, pushed. Whoever takes on the project of removing VLAs can remove the flag. > On the whole I'd prefer we remove VLAs (since they aren't standard) and > alloca (since it is bad). I don't really care if we have a small vector > unless it's proven we need it. Agreed. Simon