From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by sourceware.org (Postfix) with ESMTPS id 591793982061 for ; Wed, 14 Apr 2021 15:47:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 591793982061 Received: by mail-qv1-xf2d.google.com with SMTP id o11so10083092qvh.11 for ; Wed, 14 Apr 2021 08:47:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ao+KjDPVCCwR7SzLviYAdqK1R1EyafGAvRkEHCqn2AE=; b=awI2J0yZMMKJsak42MtgBUVRWP8QVtuQzc8rCqg9AXh29bgtCFOq+988RhL/SzdWFz +a7yajuRjck6dyNSLqcj5i3Xhl38eVhT/F1ffh+F6jU3QK845C9jdIKe6wXe2uCIArqU OkVkEj5yzxG+DU/duuYP04/4t7Q0l0AwJ6Dnf7kuPEiDLhlHeHyZ1AsQnjf5AQOT9V0W HX9/ykwKP2qT7aQiwxncueOEc8jJQgysL34eCnB0CrHgXVNlHv/9m6wI8OjSCEirZofS pohqoCfuq9wBfmPX08g3V12WW9Bk3Bt8WroY4bRYN9mOF61X1hLE84pRu687LvwzIKv1 FOog== X-Gm-Message-State: AOAM533deRDcZZSmGVvHl65tZJShmoA5vbBf4kYubFrApvtnMNB/5lxJ Jnx28bDNjbZ66sWGrrKJlA0teVfyXau5uw== X-Google-Smtp-Source: ABdhPJwQnu26EAf/zzGAEFcigrMoyffIBJjd27ed8+iGb/1CO3TREXSUwHVmKmwKr7gDML5qenjpNQ== X-Received: by 2002:a05:6214:12e4:: with SMTP id w4mr33844326qvv.30.1618415264927; Wed, 14 Apr 2021 08:47:44 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2d9e:c125:8803:5a49:6b2a? ([2804:7f0:4841:2d9e:c125:8803:5a49:6b2a]) by smtp.gmail.com with ESMTPSA id y15sm3458298qkp.17.2021.04.14.08.47.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Apr 2021 08:47:44 -0700 (PDT) Subject: Re: [PATCH] Print bfloat16 DWARF types correctly To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" References: <20210414143528.1845401-1-luis.machado@linaro.org> <0adb6360213e4b8babf93c9fdd79097e@intel.com> From: Luis Machado Message-ID: <39037bcf-5735-632e-8239-de7ba1ba35f8@linaro.org> Date: Wed, 14 Apr 2021 12:47:41 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <0adb6360213e4b8babf93c9fdd79097e@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2021 15:47:47 -0000 On 4/14/21 12:45 PM, Willgerodt, Felix wrote: >> gdb/ChangeLog: >> >> YYYY-MM-DD Luis Machado >> >> * arch-utils.c (default_floatformat_for_type): Handle bfloat16. >> >> gdb/testsuite: >> >> YYYY-MM-DD Luis Machado >> >> * gdb.dwarf2/dw2-bfloat16.exp: New file. > > > It doesn't interfere with the avx512_bf16 support I added last year, as that is a register view only (no variables). I guess that is why you cc'ed me. I cc-ed you in case there was anything obviously wrong from x86's side. It sounds like there isn't, so that's good. :-) > > I don't know enough about it to judge if "__bf16" is the only string in use by different compilers. Looks ok to me other than that, but I am not an approver. That's fine. Thanks for checking.