From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 4BCD63858C54 for ; Mon, 27 Mar 2023 21:00:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BCD63858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4Pllb15TJcz4HV3; Mon, 27 Mar 2023 21:00:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pllb14jL9z3QZZ; Mon, 27 Mar 2023 21:00:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679950845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5WXqKeGidwXRGOLsiIan9isLI+YeQqvzAnmothPL+GY=; b=ZNkx7exApk9bSL35nw1L/5bCFwzB7RZ5y0ISxVTiDsJ1VNhL5enHW6sHD94AW99LCZStOp y5EkAO3o2ez92GeXACWluEqAgeKgM/6/G6q+lOOSLWoFz0NRt9Od9JvbaMvV9rYTQik6+3 UeDD7VECDol99rV9lkY6QxAE4vsVCdzaAlLzPcdDIC12sf0ES0orf8ldVroMznfN+S/YCs Lu4h2uyu/J2N0AD+aHigINNP26fcNmEsP8W1nFHdprrGkw5vwiP5NCvWPyAhOG4Kq686cj Ewj10xTNdfr24TjmZWAkrdp1djtMr3ZCfq+wZVbaPqr41+QzBd4LW73Gq+xV0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679950845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5WXqKeGidwXRGOLsiIan9isLI+YeQqvzAnmothPL+GY=; b=qEejmAfzfe7E/JiLE1/XZCiITPv8v0vohHQXLKGsDgMoItssLJ3/ZDidawkHefcqgLafxu r8fYN229e12djMCBqoZMS2uwPm5rSJFkghIWTigiuEAS2Tulm09v07dGmqkS2NAq8fUzhf AvClJDRlbmnX4AUj50ZEIrYmutbZmjYL/bDNJzEGLam/DMFuv1IW/GkfD9ADRatGwY0Vnp QMff61L4U325m3VuV9lBL6XeHsjmZa92Yp6g1cG8mgrhkqh66zLlzUWt1d33eCtLexUv0T 4SlmvaqBcz0EEa8nrWKSEs8/CAUH4i0D+GZqpWBV57NrDGwoqDU7M4A0pbTSAQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679950845; a=rsa-sha256; cv=none; b=YbsYdcXwpnoSgSYZZCBU9zWPldogeJaKivJN/bdDRoScH/NqHDwn0UOgxIfcKJQBcRZsnO +91YTBu2RxexuHmQ6Ozbf5NztoLHQGVlMxNYtdUCgbbvO5WcQOIIOfC/cfjKrdLEnxcbB9 +lvlbxqm9FA7bAxSn5FJyUH2EmLxkYTMNCQiqslYQQf9Y1HmSiqMVtLVJROqAiM3BS03Vn UOj5bFRlr70taNxlXaE3PnOiECKXriTAF0N0FhmXxCh2q1owf5AL7Y2nhTq16dbEYXbicM j/PIMck8uBpje33Epdgr6mU22nB7gKngT75dlUB4LSxq8ZK6Or8RU3lVoxSdzA== Received: from [IPV6:2601:648:8680:16b0:c10c:3358:4516:c03f] (unknown [IPv6:2601:648:8680:16b0:c10c:3358:4516:c03f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Pllb11gk3zLRD; Mon, 27 Mar 2023 21:00:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <3915abc2-7585-a33b-b1ea-4338d47dd0cc@FreeBSD.org> Date: Mon, 27 Mar 2023 14:00:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US From: John Baldwin To: Simon Marchi , gdb-patches@sourceware.org References: <20230228181845.99936-1-jhb@FreeBSD.org> <20230228181845.99936-5-jhb@FreeBSD.org> <8e52f898-c853-df46-52a8-6a4a4c292c5c@simark.ca> <1f5bad14-378e-47df-5386-b2c48710cf64@FreeBSD.org> Subject: Re: [PATCH 4/9] fbsd-nat: Add a list of pending events. In-Reply-To: <1f5bad14-378e-47df-5386-b2c48710cf64@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/27/23 1:24 PM, John Baldwin wrote: > On 3/20/23 11:35 AM, Simon Marchi wrote: >>> @@ -1110,21 +1143,18 @@ fbsd_next_vfork_done (void) >>> void >>> fbsd_nat_target::resume (ptid_t ptid, int step, enum gdb_signal signo) >> >> It would be a good time to rename the first parameter from ptid to >> scope_ptid, to match what was done here: >> >> https://gitlab.com/gnutools/binutils-gdb/-/commit/d51926f06a7f4854bebdd71dcb0a78dbaa2f4168 >> >> I think it helps understand the meaning of the parameter. > > Hmm, I might do the rename as a separate commit first to avoid adding noise > in this patch. Actually, I think I will do this in the patch that reworks resume() to properly handle multiple inferiors as that is when it starts to really be treated as scope_ptid. -- John Baldwin