From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 5F1E1395C03E for ; Tue, 8 Jun 2021 15:43:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5F1E1395C03E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 1456977E77; Tue, 8 Jun 2021 15:43:34 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FzvfF6x0Tz3Ll6; Tue, 8 Jun 2021 15:43:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 9791397C1; Tue, 8 Jun 2021 15:43:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH 3/3] sim: dv-sockser: enable for mingw targets too To: Mike Frysinger , gdb-patches@sourceware.org References: <20210608051036.24813-1-vapier@gentoo.org> <20210608051036.24813-3-vapier@gentoo.org> From: John Baldwin Message-ID: <3950ad01-f688-8425-b378-c86d113d4a0e@FreeBSD.org> Date: Tue, 8 Jun 2021 08:43:29 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210608051036.24813-3-vapier@gentoo.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2021 15:43:35 -0000 On 6/7/21 10:10 PM, Mike Frysinger via Gdb-patches wrote: > We have enough functionality from gnulib now to build sockser on > all platforms. > --- > sim/common/dv-sockser.c | 6 +++++- > sim/m4/sim_ac_option_hardware.m4 | 16 +++++----------- > 2 files changed, 10 insertions(+), 12 deletions(-) > > diff --git a/sim/common/dv-sockser.c b/sim/common/dv-sockser.c > index 7f1cf798e4b9..f1ef22a53a8e 100644 > --- a/sim/common/dv-sockser.c > +++ b/sim/common/dv-sockser.c > @@ -43,7 +43,7 @@ along with this program. If not, see . */ > #include > > #ifndef __CYGWIN32__ > -#include > +//#include > #endif > > #include "sim-assert.h" This hunk looks like a temporary testing change? Did you mean to remove the header entirely? -- John Baldwin