From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40698 invoked by alias); 3 Oct 2018 17:54:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40683 invoked by uid 89); 3 Oct 2018 17:54:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=violations, Hx-languages-length:795 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Oct 2018 17:54:41 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A52F130842AE; Wed, 3 Oct 2018 17:54:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 09612106225A; Wed, 3 Oct 2018 17:54:39 +0000 (UTC) Subject: Re: [PATCH v2 10/10] Add --enable-ubsan To: Tom Tromey , gdb-patches@sourceware.org References: <20181002044420.17628-1-tom@tromey.com> <20181002044420.17628-11-tom@tromey.com> From: Pedro Alves Message-ID: <39d959ba-b55b-8eb9-29ac-22eabc4cccfd@redhat.com> Date: Wed, 03 Oct 2018 17:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181002044420.17628-11-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00083.txt.bz2 On 10/02/2018 05:44 AM, Tom Tromey wrote: > This adds --enable-ubsan to gdb's configure. By default it is enabled > in development mode, and disabled otherwise. This passes both > -fsanitize=undefined and -fno-sanitize-recover=undefined to > compilations, so that undefined behavior violations will be sure to > cause test failures. Thanks much for all the docs additions, and all the preparatory work that came with it. > --- /dev/null > +++ b/gdb/sanitize.m4 > @@ -0,0 +1,46 @@ > +dnl Autoconf configure script for GDB, the GNU debugger. Nit: I guess this was copied from warning.m4, but, could you tweak this intro comment, which seems to have been originally blindly copied from configure.ac into warning.m4? Otherwise LGTM. Thanks, Pedro Alves