From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 412CE3858D39 for ; Wed, 3 Nov 2021 22:09:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 412CE3858D39 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43920) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miORW-0006Bx-5s for gdb-patches@sourceware.org; Wed, 03 Nov 2021 18:09:15 -0400 Received: from ip5f5a8d68.dynamic.kabel-deutschland.de ([95.90.141.104]:61952 helo=[192.168.111.41]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miORV-0000AO-U4 for gdb-patches@sourceware.org; Wed, 03 Nov 2021 18:09:14 -0400 From: Simon Sobisch To: gdb-patches@sourceware.org Subject: source search with correct return type for "Expression not found" Message-ID: <39e16d91-3de3-2558-9afc-9d777eef7edc@gnu.org> Date: Wed, 3 Nov 2021 23:09:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2021 22:09:17 -0000 Currently the user only gets output of this message, but not error. The later is especially different handled in GDB frontends and with mi gdb/source.c, line 1709: - printf_filtered (_("Expression not found\n")); + error (_("Expression not found")); Nice side effect: one msgid less, because on line 1649 it is actually used that way.