From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130055.outbound.protection.outlook.com [40.107.13.55]) by sourceware.org (Postfix) with ESMTPS id EF9373858D28 for ; Tue, 13 Sep 2022 16:01:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EF9373858D28 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NY+Wfd8zLH1PN0t7I+pMUWiCmQ93czt9AdJZaMJoqqnUkuunXoecWtiKbGX9A8WMVjOYYEwYZ4YhRj5YXhq+Lnq3TbfWcWnBGX1E+RuDvLCtvJJqGoYNEmIFEU8iArd0f6CGJDqc6XvlmA4wHxwvmMI9kWKAPCRry2yuZ5fNK0bHcUT7yCD9cnrHPNwRQKAOZWH6IHJLW/vWjQgWt3O+4MuTj1Aqv33tnYYB4bFfNiF8WXxu5LejiRWx8L5dDs5mvfcjCWHxmN4Yc/Xgk4S4rbe7ekkEwjgdyzWvu9i95G4klpGQ48T9G1LfFo6sAgJwtJRZjZytyk14G7NHnhexFg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AyAbA5c2tFDL/8qQDVnH0lnfsLElqDy9RLwKWLjwFRQ=; b=lfQWiA8FQZYAN4EfzVqNbygzSA3HR/VUPA5PS1Mi3XDG5EYzl9DG9u/x6ABRMn3ZK4/Mvv4W/VKdQFGADroX6Ohc+/qUEA2+2rgKyIXJn4XhFXkjoD8LQU7cL7dtHNNyQEJWeBTcBKugfCb96W7+EmKk9GTOfp9m8iUVQ7IaJIaA8VqJfVtbxwuh4aw2xFUZWLyepR8LEUIX0xIhT/n99azb/pNUvCSmAr9PHbnvmbrSq9BakHyzhDA3sBhmjsCMnTpjFD8o79hvCra5P6o/NDRysfE+4ds2q65Rhrzzd/yN5gk2DQo2tC40CXCMEOIYJQJVDge+Fgq8LyDeHGm+dA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM6PR08CA0033.eurprd08.prod.outlook.com (2603:10a6:20b:c0::21) by DB4PR08MB9406.eurprd08.prod.outlook.com (2603:10a6:10:3f2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Tue, 13 Sep 2022 16:00:57 +0000 Received: from AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:c0:cafe::50) by AM6PR08CA0033.outlook.office365.com (2603:10a6:20b:c0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Tue, 13 Sep 2022 16:00:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT047.mail.protection.outlook.com (100.127.140.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Tue, 13 Sep 2022 16:00:56 +0000 Received: ("Tessian outbound fc2405f9ecaf:v124"); Tue, 13 Sep 2022 16:00:56 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 260ccfb49778f773 X-CR-MTA-TID: 64aa7808 Received: from 57e9d4ddf571.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4CDB4059-0551-47B7-95ED-B96F4714527A.1; Tue, 13 Sep 2022 16:00:50 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 57e9d4ddf571.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 13 Sep 2022 16:00:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PmnKj9OVyNYgSfwL0ou+mKlxGf5OrJ5zSz0wmZbG3S2bt3zAmJ5jImnIoZH8cwJlR+Tx0813qHh6hf8qIAibEpyTdYAy3DdlLJdFACFHRQF6WiGaBa8WJHcGVZvXCrT5llDLXDQNLcficp56yNrtyuspLWMlHGrXaRW1jLJF310piOlXWBLI8GJAbcrlPpz2DjZ0X6Ma6m64SrB1GnMIwly01KTALyn7d58Hn9gEdAgGaGLYJc2a1jZUfgg4/j4k7LgAP9sEh0c3dANeMzsyRCZHx/XF7x73AKyRWBextyxfcgjp6bQYNU3JGpRto/UBsFwknRG44FqjKM+gCjlslg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AyAbA5c2tFDL/8qQDVnH0lnfsLElqDy9RLwKWLjwFRQ=; b=MpKkQRgJit5OhpBz/lBdSGBAEeCsIs1A/B9Cj2lGb1u+isUUNhEgtwCAhCDiA6IJGGBBZjgV+XedXLsiphd01DL3t1EVPbrTVSApGjzMyBf1vP4uDrnawSbmwLm4febz9/UT82z8XWX5fzcS2l3qOtgDlEh0XMEvSlfTBhGE/19SnWJsrTip0TQEElRfZHfOfPfWvj9X6a5N19bOHaa30F1y1b40P7VsQUMmPp81xLbAUj6R9o17PpTmhxbvGkY9dPAh4LwlAWg5RiRYq9sSjQ/8hIRrmlSLtzc/BdR2Bj5j2Y54aVDo1SVsbuM6lB+BJ+t+kWCXmLLK0H74vyJdPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by PA4PR08MB6079.eurprd08.prod.outlook.com (2603:10a6:102:ee::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Tue, 13 Sep 2022 16:00:49 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094%5]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 16:00:49 +0000 Message-ID: <39e382f2-b0e4-46b0-6745-83f0bfcc1c3d@arm.com> Date: Tue, 13 Sep 2022 17:00:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH][gdb/testsuite] Fix gdb.dwarf2/dw2-dir-file-name.exp for aarch64 Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20220913144800.GA27877@delia> From: Luis Machado In-Reply-To: <20220913144800.GA27877@delia> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0219.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::15) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|PA4PR08MB6079:EE_|AM7EUR03FT047:EE_|DB4PR08MB9406:EE_ X-MS-Office365-Filtering-Correlation-Id: efb15019-f77b-4400-7198-08da95a124f8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BtKxRA3sCSR7N4lBsY8rA63RhYn2fd3CWcPxXb3nEK1RmjxzvJIj7iR6zd7IwoIt4NUtBPmkGNj42SH/ebpEa8H+JNuswfE2kSBaNsw1L7BEOWxacwQKtW99OGYtMS7ytnd5js1jWtsSRsVL5H4MIQvZOhW1F/Bnq6e7G4L/mvnCYH61B+ZInr+zkqLqNIoH5YfSo2p+jQkf45WPK3zPZNrOFwSfQ86d7wDuKnzDdGSajzQNwD1SpjRZFffFpB2PBeaJ2Mo28xeLE36mTPa8ntHXZOQ4ljX3N3yuMGwaf5O4/xTDjaa99bnyQ8FBkRJauI92zqoJOdp6Q6ZfB0LRg6IhcuZqTulvb1v6O5ll5aZ13uWkeWxAzYboHZDyb/c/kNbJcmKeBljNUeT/vYj613RMiFmFyl1O3u0uE2wMJf9fKiIUS1n+jdrtyAej//B+9mj8k8FrHCabEX6rFJE0VTTOLJHWCB3I/is62vhziqPUZXnPlWABIo2hX2fF0YNWce0eJ/qJQIi9vDGuOOE/cYWFOUfvlgc9Of8q12Q3oShtmQ8IXooVtAY3MPq/jchmKoosz1A4t7i1ylqbsUd3lUuoZcvoEoxu+PO4zhs8vQJWlm3JTZuO2tEgqWXnCi7XonvpRYJ50I3Sgdj+uSo5lh7MH1qXrqjCY/f69ekIPpWMyh9VHLSkoaxGP/1bLqL7W/yvKCCCRxF2p7paesNssx9g+fYCaBgpRxQo1YKr8WIMg50QtkfNVUzzdu7QUvhgS+JD+xf8R43azsrqXLk4iRybQ8BLyFqEJH4OesxoQ0A= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(366004)(451199015)(66556008)(8936002)(66476007)(2906002)(5660300002)(44832011)(66946007)(6512007)(86362001)(186003)(316002)(8676002)(26005)(6506007)(38100700002)(83380400001)(478600001)(31686004)(2616005)(53546011)(31696002)(36756003)(41300700001)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6079 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5d200cc2-9ab8-44f5-029e-08da95a1202b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 120jx0eN6lPh+DRI+H490HU7WKqx6BL1wDqwpTeVg0F4avYM3S+Ja4wpKSaPeclQUvJxCU1Fo7QNBvgCf+MwVamQDFcDC8l8zWgBmgR6JhtSIIBzSsHL4/BEth3XaPk3fZkXcHyV0NvtoscD9a60fjOb5PPKhCOPM3gtBctMm6e7cmBpIRE7nx02eXcaK2+CoMKF6nrLe5FB9uYjRhXlwy19gQICOaBg1BNf3G7oqNs0ABpoTUG32MHZrtR608jAXJpa3EmHS+WAwFAqMsSNp5iOApPyNk/40a0TiYm5qbfLveHao/hYU5PS5Ee9W+98QYeLv7lnDm4HdNXnXSVdEhsqmq6rqQeJpNhF03+1qOPh6r0F3HtdU5qDcpdEZtovDJ9tRYZKYGa+fuxRfkx28+pCS3m68Y7nbi/ehRWGY8D1n2mEPGjMETOiq9QU0uFo5naX2C24qgXV5Z2UKIsfyjm/TZZtfZ7Mjr+j5ECjJ6N3xyfoZOMwSGft9fKvLpCNmjSUQeDTph+U6U2PjWfC67BKk0+BlHFm6nk0L2PLywzvkHUve8AXx7XQ0e4jO0ZwIcVCTe4HgtMD6lggPvJ5lbWh6984bI5KM6+8FGRX3yg8dNElbZyb1mIudxfXRVsNIbVktd/IleVanbRmy8ZqKvwRDMDjS8vLOJ82C0bmDNvmneGtU8fTWMMtYbE7omhKZeEAQgnsbc9i3i+3w3zIKrZzZnccTnnIqiPUQ45UhKHVlJMUPSzDY4Yp89po4JLlCQ1KaZEdiMq84psr5jvb6xZMJdH6W0Xh+qBQxbDji4Tw3ugZ2Ht4voPNDIDXAp7K X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199015)(46966006)(40470700004)(36840700001)(2616005)(8676002)(82740400003)(336012)(83380400001)(41300700001)(2906002)(44832011)(40460700003)(316002)(31696002)(356005)(81166007)(478600001)(36756003)(70586007)(31686004)(6512007)(70206006)(8936002)(6506007)(82310400005)(6486002)(47076005)(53546011)(86362001)(36860700001)(26005)(186003)(5660300002)(40480700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 16:00:56.8412 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: efb15019-f77b-4400-7198-08da95a124f8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9406 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2022 16:01:03 -0000 On 9/13/22 15:48, Tom de Vries wrote: > Hi, > > [ Another attempt at fixing the problem described in commit cd919f5533c > ("[gdb/testsuite] Fix gdb.dwarf2/dw2-dir-file-name.exp"). ] Tricky one. :-) > > When running the test-case gdb.dwarf2/dw2-dir-file-name.exp with > aarch64-linux, we run into: > ... > (gdb) continue^M > Continuing.^M > ^M > Breakpoint 2, compdir_missing__ldir_missing__file_basename () at \ > tmp-dw2-dir-file-name.c:999^M > (gdb) FAIL: gdb.dwarf2/dw2-dir-file-name.exp: \ > compdir_missing__ldir_missing__file_basename: continue to breakpoint: \ > compdir_missing__ldir_missing__file_basename > ... > > The breakpoint set at compdir_missing__ldir_missing__file_basename_label, > address 0x400608 starts at a line entry: > ... > CU: tmp-dw2-dir-file-name.c: > File name Line number Starting address View Stmt > tmp-dw2-dir-file-name.c 999 0x400608 x > tmp-dw2-dir-file-name.c 1000 0x40062c x > tmp-dw2-dir-file-name.c - 0x40062c > ... > and therefore the breakpoint is printed without instruction address. > > In contrast, for x86_64-linux, we have the breakpoint printed with instruction > address: > ... > (gdb) continue^M > Continuing.^M > ^M > Breakpoint 2, 0x004004c1 in compdir_missing__ldir_missing__file_basename () \ > at tmp-dw2-dir-file-name.c:999^M > (gdb) PASS: gdb.dwarf2/dw2-dir-file-name.exp: \ > compdir_missing__ldir_missing__file_basename: continue to breakpoint: \ > compdir_missing__ldir_missing__file_basename > ... > > The breakpoint set at compdir_missing__ldir_missing__file_basename_label, > address 0x004004c1 doesn't start at a line entry: > ... > CU: tmp-dw2-dir-file-name.c: > File name Line number Starting address View Stmt > tmp-dw2-dir-file-name.c 999 0x4004bd x > tmp-dw2-dir-file-name.c 1000 0x4004d3 x > tmp-dw2-dir-file-name.c - 0x4004d3 > ... > > Fix this by: > - unifying behaviour between the archs by adding an explicit line number entry > for the address compdir_missing__ldir_missing__file_basename_label, making > the FAIL reproducible on x86_64-linux. > - expecting the breakpoint to be printed without instruction address. > > Tested on x86_64-linux and aarch64-linux. > > Any comments? Thanks for the quick patch. From my end it looks good, and makes the tests pass again. > > Thanks, > - Tom > > [gdb/testsuite] Fix gdb.dwarf2/dw2-dir-file-name.exp for aarch64 > > --- > gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp > index 053f7229537..3827ed744b5 100644 > --- a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp > +++ b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp > @@ -188,13 +188,20 @@ proc out_line { name cu_dir cu_name line_dir line_name } { > > .Lline_${name}_lines: > .byte 3 /* DW_LNS_advance_line */ > - .sleb128 998 /* ... to 999 */ > + .sleb128 997 /* ... to 998 */ > .byte 0 /* DW_LNE_set_address */ > .uleb128 ${addr_len}+1 > .byte 2 > .${addr_len}byte $name_start > .byte 1 /* DW_LNS_copy */ > .byte 3 /* DW_LNS_advance_line */ > + .sleb128 1 /* ... to 999 */ > + .byte 0 /* DW_LNE_set_address */ > + .uleb128 ${addr_len}+1 > + .byte 2 > + .${addr_len}byte ${name}_label > + .byte 1 /* DW_LNS_copy */ > + .byte 3 /* DW_LNS_advance_line */ > .sleb128 1 /* ... to 1000 */ > .byte 0 /* DW_LNE_set_address */ > .uleb128 ${addr_len}+1 > @@ -451,19 +458,19 @@ proc test { func compdir filename } { > } > > gdb_breakpoint ${func}_label > - gdb_continue_to_breakpoint $func "$func \\(\\) at .*" > + gdb_test "continue" "$func \\(\\) at .*" "continue to $func" > > gdb_test_no_output "set filename-display absolute" > verbose -log "expect: ${absolute}" > - gdb_test "frame" " in $func \\(\\) at [string_to_regexp ${absolute}]:999" "absolute" > + gdb_test "frame" "$func \\(\\) at [string_to_regexp ${absolute}]:999" "absolute" > > gdb_test_no_output "set filename-display basename" > verbose -log "expect: [file tail $filename]" > - gdb_test "frame" " in $func \\(\\) at [string_to_regexp [file tail $filename]]:999" "basename" > + gdb_test "frame" "$func \\(\\) at [string_to_regexp [file tail $filename]]:999" "basename" > > gdb_test_no_output "set filename-display relative" > verbose -log "expect: $filename" > - gdb_test "frame" " in $func \\(\\) at [string_to_regexp $filename]:999" "relative" > + gdb_test "frame" "$func \\(\\) at [string_to_regexp $filename]:999" "relative" > } > } >