From: Simon Marchi <simark@simark.ca>
To: "Maciej W. Rozycki" <macro@wdc.com>, Jim Wilson <jimw@sifive.com>
Cc: jiangshuai_li@c-sky.com,
"Andrew Burgess" <andrew.burgess@embecosm.com>,
guoren@kernel.org, gdb-patches@sourceware.org,
夏立方 <lifang_xia@c-sky.com>, yunhai_shang <yunhai_shang@c-sky.com>
Subject: Re: [PATCH] riscv: add gdbserver support
Date: Tue, 21 Jan 2020 02:13:00 -0000 [thread overview]
Message-ID: <3a15e9f5-099f-3be0-e3f1-0e17c2959158@simark.ca> (raw)
In-Reply-To: <alpine.LFD.2.21.2001202307240.15714@redsun52.ssa.fujisawa.hgst.com>
On 2020-01-20 6:33 p.m., Maciej W. Rozycki wrote:
> Offhand I can see the proposal fails to implement XML register
> descriptions, which I think every modern port is expected to do (we also
> need to disallow non-XML-enabled RISC-V stubs in GDB proper, as we
> discussed before; I fail to understand why it wasn't done right away with
> the initial implementation, as it's quite straightforward and would have
> set the policy for debug stubs right from the beginning).
I would also expect new ports to use XML target descriptions. And I see
that there is already code in arch/riscv.c to build target descriptions based
on detected features... so should gdbserver use it?
Simon
[1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/arch/riscv.c;h=a3ab8a92909f082754dfd6eb9a70f19153b8684f;hb=HEAD
next prev parent reply other threads:[~2020-01-21 1:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 5:01 jiangshuai_li
2020-01-20 23:33 ` Jim Wilson
2020-01-21 0:30 ` Maciej W. Rozycki
2020-01-21 2:13 ` Simon Marchi [this message]
2020-01-21 2:17 ` Maciej W. Rozycki
2020-01-21 13:01 ` Andrew Burgess
2020-01-21 13:28 ` Andrew Burgess
2020-01-21 13:47 ` Andreas Schwab
2020-01-22 0:11 ` Jim Wilson
2020-01-22 0:45 ` Jim Wilson
2020-01-22 10:19 ` Jim Wilson
2020-01-22 14:08 ` Andrew Burgess
2020-01-21 17:11 ` Maciej W. Rozycki
2020-01-21 23:56 ` Jim Wilson
2020-01-22 5:26 ` Guo Ren
2020-01-22 6:15 ` Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a15e9f5-099f-3be0-e3f1-0e17c2959158@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=guoren@kernel.org \
--cc=jiangshuai_li@c-sky.com \
--cc=jimw@sifive.com \
--cc=lifang_xia@c-sky.com \
--cc=macro@wdc.com \
--cc=yunhai_shang@c-sky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).