From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by sourceware.org (Postfix) with ESMTPS id 70D5F3858D35 for ; Fri, 20 Oct 2023 14:40:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70D5F3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 70D5F3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697812841; cv=none; b=kI2VogIfejL7Et5VZjoI1h4MhFIUuXiJZgVmdm0HQC0GYOkwHx18teKuhL0dEky96Di5wgfQ0YIhPSoigVWX7qy6sgwR9PHiuMRxWHYiCP4CQ3ml5Pd9s3Klo7j0XWLN2vxogb6kP7arAefwmPN29uZT+OEwuZG2plUlwym90Ws= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697812841; c=relaxed/simple; bh=vCkZl3zcggs3OIPLOsraFKljUrUuv1NhijG+buMSOxQ=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=chrOEY5mi3WSylxeJGpyW4I+V1KRkGHptrEmxOeQLyCZhgiJgRYVQ1K6QtjwDewfk3qFPTs9roVvyqmDSMgrPCxov9PSI5I70F/I4PI7G2ErKGcBBElcP1OsFbL85rT+k9DGlydU4zfKg3N6924toE//vqOzd5FMJMlBp+CsZMc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-32db188e254so677984f8f.0 for ; Fri, 20 Oct 2023 07:40:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697812839; x=1698417639; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GmLJ0NYr/yYEtElO4Cg1prOQLNmr9HjJDzjgpG6Q0Fo=; b=gtPbmI6fMwKoo/jQetp/xsRxcTbHdREphArDvxkSevNY2MhGs7aS1K+xjDFJBA3wfZ AWhjJnGQXgSIVW5EljzfYrK2ZEVf0eoPwm+qYf0b2sZXp2KsBR2OglDaw772oJR6cyZC jPJyTMuRQD7qSHSsjLKnz/4D8lhRARtD0+IfTOqN4gVO31QD4T55VVqe8h9MrWksVYiI kOfds0BRy9tvmp2ImTbLeFdJeSJer2s8vNjRTRyxcG4JLZuFR7nhXLcSv9jb4sVlblid H8VsyIrKm1pkezqtI94XinM10Biq72j1qTOMK+aNiufpLtIJvAZloHGrey63Bm8EKbXa B9NQ== X-Gm-Message-State: AOJu0Yyeqbb8cw/EpNIAC8syDC/0tdvvCXm4CG/v6ySGKv1hT/DLGvvL R9twVljRsTPaRpLThfKFR+AaF4cgcnM= X-Google-Smtp-Source: AGHT+IFwWv29uu8JCWan8mlSmWOnBHcawyK/rSMOoEScF/90ZuWtVvQeE70up60aJ5YKm/b5QMrfCA== X-Received: by 2002:a5d:538d:0:b0:32d:ae31:4595 with SMTP id d13-20020a5d538d000000b0032dae314595mr1387609wrv.65.1697812839232; Fri, 20 Oct 2023 07:40:39 -0700 (PDT) Received: from ?IPV6:2001:8a0:f939:d200:ee35:b4ad:7014:7dd5? ([2001:8a0:f939:d200:ee35:b4ad:7014:7dd5]) by smtp.gmail.com with ESMTPSA id cc17-20020a5d5c11000000b0031c52e81490sm1859890wrb.72.2023.10.20.07.40.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Oct 2023 07:40:38 -0700 (PDT) Message-ID: <3a16a619-3f34-478b-8ba1-5767b7a13fab@palves.net> Date: Fri, 20 Oct 2023 15:40:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/24] C++ification of struct so_list Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20231010204213.111285-1-simon.marchi@efficios.com> From: Pedro Alves In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-17 20:53, Simon Marchi wrote: > On 10/17/23 15:20, Pedro Alves wrote: >> On 2023-10-10 21:39, Simon Marchi wrote: >>> This series modernizes the struct so_list area by C++ifying it a little >>> bit and replacing the manual linked list implementation with >>> intrusive_list. It also contains a few other cleanups written along the >>> way. >> >> Very nicely split. Thanks. I sent a few comments, but nothing too serious. >> The only thing on my end that requires some churn is the pointer vs reference >> thing in the disposer. Otherwise, all LGTM. > > I dropped the "use reference in disposer" patch. Right, thanks. I somehow thought that that would have some cascading effect in the following patches. That's what I meant by churn.