From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 606F7385B513 for ; Wed, 22 Mar 2023 13:59:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 606F7385B513 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A22C71E110; Wed, 22 Mar 2023 09:59:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1679493565; bh=RdYTTxyjfOwVsuJtpsYGCYxCHmgSVwRGQbaxrpeVupI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ipOaKpO1+XoLQ9A8cQM6zV/FPmNV+ocnVgoX33w0DWDr2THDCMZjTA14apn0hfaZC ZiDBGrGW1rRBauHwuvdjR93OgJGjIpdrTaPvpgdhdl/+tkffdpFU9AIUETqb3jiWww AUo4mY9gCRVUXl+3V79i+4ixx1Qt/DxFTzwIzjzI= Message-ID: <3a38867b-e481-c4be-95db-0058afbaf2b3@simark.ca> Date: Wed, 22 Mar 2023 09:59:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/1] gdb: Update doc of the "maintenance info line-table" Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org, simon.marchi@efficios.com Cc: lsix@lancelotsix.com References: <7c2ba695-c6ec-5854-c81a-e84db28cc66b@simark.ca> <20230322102642.510635-1-lancelot.six@amd.com> <20230322102642.510635-2-lancelot.six@amd.com> From: Simon Marchi In-Reply-To: <20230322102642.510635-2-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/22/23 06:26, Lancelot SIX via Gdb-patches wrote: > Commit 904d9b02a18 (gdb: make "maintenance info line-table" show > relocated addresses again) have updated the "maintenance info > line-table" command, but did not update the associated documentation. > > This patch updates the documentation to reflect the new command output. Thanks, I didn't think that a maintenance command would have so much details in the doc. > --- > gdb/doc/gdb.texinfo | 32 +++++++++++++++++++------------- > 1 file changed, 19 insertions(+), 13 deletions(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 6c811b8be2e..dbb6267f3fd 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -20345,21 +20345,27 @@ objfile: /home/gnu/build/a.out ((struct objfile *) 0x6120000e0d40) > compunit_symtab: simple.cpp ((struct compunit_symtab *) 0x6210000ff450) > symtab: /home/gnu/src/simple.cpp ((struct symtab *) 0x6210000ff4d0) > linetable: ((struct linetable *) 0x62100012b760): > -INDEX LINE ADDRESS IS-STMT PROLOGUE-END > -0 3 0x0000000000401110 Y > -1 4 0x0000000000401114 Y Y > -2 9 0x0000000000401120 Y > -3 10 0x0000000000401124 Y Y > -4 10 0x0000000000401129 > -5 15 0x0000000000401130 Y > -6 16 0x0000000000401134 Y Y > -7 16 0x0000000000401139 > -8 21 0x0000000000401140 Y > -9 22 0x000000000040114f Y Y > -10 22 0x0000000000401154 > -11 END 0x000000000040115a Y > +INDEX LINE REL-ADDRESS UNREL-ADDRESS IS-STMT PROLOGUE-END > +0 3 0x0000555555955110 0x0000000000401110 Y > +1 4 0x0000555555955114 0x0000000000401114 Y Y > +2 9 0x0000555555955120 0x0000000000401120 Y > +3 10 0x0000555555955124 0x0000000000401124 Y Y > +4 10 0x0000555555955129 0x0000000000401129 > +5 15 0x0000555555955130 0x0000000000401130 Y > +6 16 0x0000555555955134 0x0000000000401134 Y Y > +7 16 0x0000555555955139 0x0000000000401139 > +8 21 0x0000555555955140 0x0000000000401140 Y > +9 22 0x000055555595514f 0x000000000040114f Y Y > +10 22 0x0000555555955154 0x0000000000401154 > +11 END 0x000055555595515a 0x000000000040115a Y > @end smallexample > @noindent > +The @samp{UNREL-ADDRESS} column gives the unrelocated address of the > +instruction as read from the debug information. The @samp{REL-ADDRESS} column > +gives the corresponding address in the process memory (relocated address). If process -> inferior, to be generic? You could also say "in the current inferior's memory" to be more precise, as the relocated address is given based on the current inferior. > +no process is started when executing this command, the relocated address is the And therefore here, "If the current inferior is not running when executing the command...". > +same as the unrelocated address. The two addresses can also be the same if the executable doesn't require relocation. But your formulation doesn't imply that you are describing all cases where addresses are equal, so perhaps we can leave that detail out. Simon