public inbox for
 help / color / mirror / Atom feed
From: Bruno Larsen <>
To: Keith Seitz <>, Aaron Merey <>,
Subject: Re: [PATCH] gdb/source: Fix open_source_file error handling
Date: Thu, 2 Feb 2023 11:29:42 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 01/02/2023 20:45, Keith Seitz via Gdb-patches wrote:
> On 1/27/23 19:37, Aaron Merey via Gdb-patches wrote:
>> Fix this by having open_source_file return a negative errno if it fails
>> to open a source file.  Use this value to generate the error message
>> instead of errno. Also add new function throw_sys_errmsg for reporting
>> this value.
> Thanks for the patch. This LGTM [warning: I am not a maintainer], but 
> I just
> have two observations (nits?). 

Friendly reminder that this is exactly what reviewed-by and approved-by 
tags were introduced to solve :-)


  parent reply	other threads:[~2023-02-02 10:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-28  3:37 Aaron Merey
2023-02-01 19:45 ` Keith Seitz
2023-02-02  1:38   ` Aaron Merey
2023-02-08 17:53     ` Tom Tromey
2023-02-02 10:29   ` Bruno Larsen [this message]
2023-02-08 17:44 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).