From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0F2013858C74 for ; Thu, 2 Feb 2023 10:29:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F2013858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675333785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6+pS+Cu2eUDrr9PJbgKuOvuA7Vp0LjTgkPI7esCPrvQ=; b=S+fDuh7POTgdER56FAuYiRPck93ewuqtcfwuq6ckNMHaQ3u+RkU4pXQPqYgCRBt6f3aq4+ 15lb/Kr2gVEQk88yNB6J8zpRkHL9dQpxrdpCtv/m16qQzfxFTKEpmiAXYEIkt0B+IYzOp6 2U8ZdBjOP/Y9lA4CAiewERXWlZEELBE= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-674-l7bYNOGQMvGdLRauWkmX_g-1; Thu, 02 Feb 2023 05:29:44 -0500 X-MC-Unique: l7bYNOGQMvGdLRauWkmX_g-1 Received: by mail-qv1-f71.google.com with SMTP id e5-20020a056214110500b0053547681552so703784qvs.8 for ; Thu, 02 Feb 2023 02:29:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6+pS+Cu2eUDrr9PJbgKuOvuA7Vp0LjTgkPI7esCPrvQ=; b=drBlm/0jiQna/zWWiBa0V1wuW6UJTEmy3OzEfT2rTdBaL3fP4mogaTg0jRmNPNtRgK DU8F9CxrUdw3uxk9Z/vyb1P16M4CRTxtwM7If2o5LI2Q//pthLw4RLSv9hA6RXbG2KuY gPvXXMu68iIeb/8m+j932CabszUJA+iZ13Z4FEhOl2Jjtw5W3FQhDmG/A+ccy0r/kn6q a2T2OGyCD2IiQNn/oR07UIgLQF1ljp9JPkDpsPyM9R/EQKjcHw7HBkV+5CIjhw0C7dUs 3alGREVAIk4e7Z7RmrIUw2PfeUEhJtxHOo0pwn42ue+6dYGSQUOL0BP2FHxuJAkMTedY /UBg== X-Gm-Message-State: AO0yUKV2Cd0wFvu/Voz57jV+OaHLLw+ln23dXg6xSl8V8TVh9uAGjRSw iHuxmLHp98VNCE4BswrkYMwZ9JFai72aVSAbCXulX8jv5bBfTWZveV+kn+hZNh9Inl/IgWS2kW+ 7QsGpLbHDLYGVHl9hshJTgw== X-Received: by 2002:ac8:7d51:0:b0:3b8:525e:15ea with SMTP id h17-20020ac87d51000000b003b8525e15eamr9678036qtb.60.1675333784138; Thu, 02 Feb 2023 02:29:44 -0800 (PST) X-Google-Smtp-Source: AK7set+f3WTV9EDlO4KL/HkHi+ixRE7SplEkm0UmObGmjv8TqY1JO/WQEV1BxC+eG2ZSchWNLVQxgQ== X-Received: by 2002:ac8:7d51:0:b0:3b8:525e:15ea with SMTP id h17-20020ac87d51000000b003b8525e15eamr9678028qtb.60.1675333783929; Thu, 02 Feb 2023 02:29:43 -0800 (PST) Received: from [10.43.2.210] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id e6-20020a05620a014600b006f9f3c0c63csm1240844qkn.32.2023.02.02.02.29.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 02:29:43 -0800 (PST) Message-ID: <3a5401d9-ce71-a2ce-4673-24809182d245@redhat.com> Date: Thu, 2 Feb 2023 11:29:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] gdb/source: Fix open_source_file error handling To: Keith Seitz , Aaron Merey , gdb-patches@sourceware.org References: <20230128033748.2839360-1-amerey@redhat.com> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01/02/2023 20:45, Keith Seitz via Gdb-patches wrote: > On 1/27/23 19:37, Aaron Merey via Gdb-patches wrote: >> >> Fix this by having open_source_file return a negative errno if it fails >> to open a source file.  Use this value to generate the error message >> instead of errno. Also add new function throw_sys_errmsg for reporting >> this value. > > Thanks for the patch. This LGTM [warning: I am not a maintainer], but > I just > have two observations (nits?). Friendly reminder that this is exactly what reviewed-by and approved-by tags were introduced to solve :-) -- Cheers, Bruno