From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by sourceware.org (Postfix) with ESMTPS id 05D9A3853D0F for ; Wed, 23 Aug 2023 15:43:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 05D9A3853D0F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-31969580797so5147670f8f.3 for ; Wed, 23 Aug 2023 08:43:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692805414; x=1693410214; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+n+rNB0x/ydH5GyCzkPCdlq4uZBHYg3cX/GUwL8TwH0=; b=V+8tFwlF20cK9pOesPsZcWu+oPGOh0h5ATJ7+eAmg88X/kWaAW89dZQQpdfjbk2gjD 0qIwkoYWNUfdRPnFmQ7N6atHLZlxbr5PZE7ctkO9wwLk8Cmt7o4Wst/4hixOwlAdSSIR 34QYDNu7gHCfJQF5MwB/GaqUh7TUr4cCTL2m1/J7Ul/WyFmSnoxzvOVzWyKeyiPp8Yxm ktUNUq/QpRTa/0+UnyM64kx7IkXxdmaUkK64wsSNbrEfzgkUD0EIzBBxve3rb15tveJd OgN8PVWK9dmEQOezRzWXG8Spdc0vJraLSJ2ppX/P+58RFsjtzy8NVWmTP09qp1qodhN5 fcPg== X-Gm-Message-State: AOJu0Yzmc4hxsrXnMRkbJsJbw4U9GwRkfNDcTMissjYPmEW7ZWw4Dx2M jlWO5mT9uOll12GZPWaurDI= X-Google-Smtp-Source: AGHT+IG5oq9B5AykoviR4rfOC+d/Ce1l1GmotddfuBmFMlhHit5wyNsAAuR7s3MyRXaGv7BC+TN2Tw== X-Received: by 2002:a5d:452c:0:b0:317:ddd3:1aed with SMTP id j12-20020a5d452c000000b00317ddd31aedmr8448813wra.68.1692805413628; Wed, 23 Aug 2023 08:43:33 -0700 (PDT) Received: from ?IPV6:2001:8a0:f90f:8600:1c58:11cc:d925:aeac? ([2001:8a0:f90f:8600:1c58:11cc:d925:aeac]) by smtp.gmail.com with ESMTPSA id g16-20020adff3d0000000b00318147fd2d3sm19415529wrp.41.2023.08.23.08.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Aug 2023 08:43:33 -0700 (PDT) Message-ID: <3a579dd3-869f-be70-740e-3b69c6dd0d1e@palves.net> Date: Wed, 23 Aug 2023 16:43:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] [gdb/build] Support reference return type in make-target-delegates.py Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20230821105356.869-1-tdevries@suse.de> From: Pedro Alves In-Reply-To: <20230821105356.869-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/08/23 11:53, Tom de Vries via Gdb-patches wrote: > When doing this in target.h: > ... > - virtual gdb::byte_vector thread_info_to_thread_handle (struct thread_info *) > + virtual gdb::byte_vector &thread_info_to_thread_handle (struct thread_info *) > ... > make-target-delegates.py drops the function. > > By handling '&' in POINTER_PART we can prevent that the function is dropped, > but when recompiling target.o we get: > ... > gdb/target-delegates.c: In member function ‘virtual gdb::byte_vector& \ > debug_target::thread_info_to_thread_handle(thread_info*)’: > gdb/target-delegates.c:1889:22: error: ‘result’ declared as reference but not \ > initialized > gdb::byte_vector & result; > ^~~~~~ > make: *** [Makefile:1923: target.o] Error 1 > ... > > Fix this by making sure result is initialized. > > Regenerate target-delegates.c using this new style. > > Tested on x86_64-linux. Approved-By: Pedro Alves